Re: [PATCH V2 09/12] soc/tegra: pmc: add pmc wake support for tegra210

2019-05-29 Thread Thierry Reding
On Tue, May 28, 2019 at 04:08:53PM -0700, Sowjanya Komatineni wrote: > This patch implements PMC wakeup sequence for Tegra210 and defines > common used wake events of RTC alarm and power key. > > Signed-off-by: Sowjanya Komatineni > --- > drivers/soc/tegra/pmc.c | 113 >

Re: [PATCH V2 09/12] soc/tegra: pmc: add pmc wake support for tegra210

2019-05-28 Thread JC Kuo
Hi Sowjanya, usleep_range() in tegra210_pmc_irq_set_wake() should be replaced with udelay() because caller irq_set_irq_wake() acquired spinlock and made this context atomic. Thanks, JC On 5/29/19 7:08 AM, Sowjanya Komatineni wrote: This patch implements PMC wakeup sequence for Tegra210

[PATCH V2 09/12] soc/tegra: pmc: add pmc wake support for tegra210

2019-05-28 Thread Sowjanya Komatineni
This patch implements PMC wakeup sequence for Tegra210 and defines common used wake events of RTC alarm and power key. Signed-off-by: Sowjanya Komatineni --- drivers/soc/tegra/pmc.c | 113 1 file changed, 113 insertions(+) diff --git