Re: [PATCH V2 1/1] can: sja1000: f81601: add Fintek F81601 support

2019-07-24 Thread Saeed Mahameed
On Wed, 2019-07-24 at 13:19 +0800, Ji-Ze Hong (Peter Hong) wrote: > Hi, > > Saeed Mahameed 於 2019/7/24 上午 05:38 寫道: > > On Mon, 2019-07-22 at 14:22 +0800, Ji-Ze Hong (Peter Hong) wrote: > > > This patch add support for Fintek PCIE to 2 CAN controller > > > support > > > > > > Signed-off-by:

Re: [PATCH V2 1/1] can: sja1000: f81601: add Fintek F81601 support

2019-07-23 Thread Ji-Ze Hong (Peter Hong)
Hi, Saeed Mahameed 於 2019/7/24 上午 05:38 寫道: On Mon, 2019-07-22 at 14:22 +0800, Ji-Ze Hong (Peter Hong) wrote: This patch add support for Fintek PCIE to 2 CAN controller support Signed-off-by: Ji-Ze Hong (Peter Hong) --- Changelog: v2: 1: Fix comment on the spinlock with write

Re: [PATCH V2 1/1] can: sja1000: f81601: add Fintek F81601 support

2019-07-23 Thread Saeed Mahameed
On Mon, 2019-07-22 at 14:22 +0800, Ji-Ze Hong (Peter Hong) wrote: > This patch add support for Fintek PCIE to 2 CAN controller support > > Signed-off-by: Ji-Ze Hong (Peter Hong) > > --- > Changelog: > v2: > 1: Fix comment on the spinlock with write access. > 2: Use ARRAY_SIZE instead

Re: [PATCH V2 1/1] can: sja1000: f81601: add Fintek F81601 support

2019-07-22 Thread Marc Kleine-Budde
On 7/22/19 8:22 AM, Ji-Ze Hong (Peter Hong) wrote: > This patch add support for Fintek PCIE to 2 CAN controller support > > Signed-off-by: Ji-Ze Hong (Peter Hong) > --- > Changelog: > v2: > 1: Fix comment on the spinlock with write access. > 2: Use ARRAY_SIZE instead of

Re: [PATCH V2 1/1] can: sja1000: f81601: add Fintek F81601 support

2019-07-22 Thread Marc Kleine-Budde
On 7/22/19 10:36 AM, Ji-Ze Hong (Peter Hong) wrote: > Hi Marc, > > Marc Kleine-Budde 於 2019/7/22 下午 04:15 寫道: >> On 7/22/19 8:22 AM, Ji-Ze Hong (Peter Hong) wrote: >> +/* Probe F81601 based >> device for the SJA1000 chips and register each >>> + * available CAN channel to SJA1000 Socket-CAN

Re: [PATCH V2 1/1] can: sja1000: f81601: add Fintek F81601 support

2019-07-22 Thread Ji-Ze Hong (Peter Hong)
Hi Marc, Marc Kleine-Budde 於 2019/7/22 下午 04:15 寫道: On 7/22/19 8:22 AM, Ji-Ze Hong (Peter Hong) wrote: >> +/* Probe F81601 based device for the SJA1000 chips and register each + * available CAN channel to SJA1000 Socket-CAN subsystem. + */ +static int f81601_pci_add_card(struct pci_dev *pdev,

Re: [PATCH V2 1/1] can: sja1000: f81601: add Fintek F81601 support

2019-07-22 Thread Marc Kleine-Budde
On 7/22/19 8:22 AM, Ji-Ze Hong (Peter Hong) wrote: > This patch add support for Fintek PCIE to 2 CAN controller support > > Signed-off-by: Ji-Ze Hong (Peter Hong) > --- > Changelog: > v2: > 1: Fix comment on the spinlock with write access. > 2: Use ARRAY_SIZE instead of

[PATCH V2 1/1] can: sja1000: f81601: add Fintek F81601 support

2019-07-22 Thread Ji-Ze Hong (Peter Hong)
This patch add support for Fintek PCIE to 2 CAN controller support Signed-off-by: Ji-Ze Hong (Peter Hong) --- Changelog: v2: 1: Fix comment on the spinlock with write access. 2: Use ARRAY_SIZE instead of F81601_PCI_MAX_CHAN. 3: Check the strap pin outside the loop.