Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-13 Thread Jon Hunter
On 12/10/15 18:51, Stephen Warren wrote: > On 10/12/2015 07:55 AM, Jon Hunter wrote: >> >> On 09/10/15 16:26, Stephen Warren wrote: >>> On 10/09/2015 04:20 AM, Jon Hunter wrote: On 08/10/15 15:27, Stephen Warren wrote: > On 10/08/2015 03:58 AM, Jon Hunter wrote: [snip]

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-13 Thread Jon Hunter
On 12/10/15 18:51, Stephen Warren wrote: > On 10/12/2015 07:55 AM, Jon Hunter wrote: >> >> On 09/10/15 16:26, Stephen Warren wrote: >>> On 10/09/2015 04:20 AM, Jon Hunter wrote: On 08/10/15 15:27, Stephen Warren wrote: > On 10/08/2015 03:58 AM, Jon Hunter wrote: [snip]

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-12 Thread Stephen Warren
On 10/12/2015 07:55 AM, Jon Hunter wrote: On 09/10/15 16:26, Stephen Warren wrote: On 10/09/2015 04:20 AM, Jon Hunter wrote: On 08/10/15 15:27, Stephen Warren wrote: On 10/08/2015 03:58 AM, Jon Hunter wrote: [snip] That's fine. From my perspective I don't have a strong objection either

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-12 Thread Jon Hunter
On 09/10/15 16:26, Stephen Warren wrote: > On 10/09/2015 04:20 AM, Jon Hunter wrote: >> >> On 08/10/15 15:27, Stephen Warren wrote: >>> On 10/08/2015 03:58 AM, Jon Hunter wrote: >> >> [snip] >> That's fine. From my perspective I don't have a strong objection either way, however, I can

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-12 Thread Jon Hunter
On 09/10/15 16:26, Stephen Warren wrote: > On 10/09/2015 04:20 AM, Jon Hunter wrote: >> >> On 08/10/15 15:27, Stephen Warren wrote: >>> On 10/08/2015 03:58 AM, Jon Hunter wrote: >> >> [snip] >> That's fine. From my perspective I don't have a strong objection either way, however, I can

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-12 Thread Stephen Warren
On 10/12/2015 07:55 AM, Jon Hunter wrote: On 09/10/15 16:26, Stephen Warren wrote: On 10/09/2015 04:20 AM, Jon Hunter wrote: On 08/10/15 15:27, Stephen Warren wrote: On 10/08/2015 03:58 AM, Jon Hunter wrote: [snip] That's fine. From my perspective I don't have a strong objection either

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-09 Thread Stephen Warren
On 10/09/2015 04:20 AM, Jon Hunter wrote: On 08/10/15 15:27, Stephen Warren wrote: On 10/08/2015 03:58 AM, Jon Hunter wrote: [snip] That's fine. From my perspective I don't have a strong objection either way, however, I can see that given that the name indicates rx or tx, then the

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-09 Thread Jon Hunter
On 08/10/15 15:27, Stephen Warren wrote: > On 10/08/2015 03:58 AM, Jon Hunter wrote: [snip] >> That's fine. From my perspective I don't have a strong objection either >> way, however, I can see that given that the name indicates rx or tx, >> then the direction in the binding could be seen as

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-09 Thread Jon Hunter
On 08/10/15 15:27, Stephen Warren wrote: > On 10/08/2015 03:58 AM, Jon Hunter wrote: [snip] >> That's fine. From my perspective I don't have a strong objection either >> way, however, I can see that given that the name indicates rx or tx, >> then the direction in the binding could be seen as

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-09 Thread Stephen Warren
On 10/09/2015 04:20 AM, Jon Hunter wrote: On 08/10/15 15:27, Stephen Warren wrote: On 10/08/2015 03:58 AM, Jon Hunter wrote: [snip] That's fine. From my perspective I don't have a strong objection either way, however, I can see that given that the name indicates rx or tx, then the

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-08 Thread Stephen Warren
On 10/08/2015 03:58 AM, Jon Hunter wrote: On 07/10/15 20:36, Stephen Warren wrote: On 10/07/2015 10:19 AM, Jon Hunter wrote: On 07/10/15 17:09, Stephen Warren wrote: On 10/07/2015 02:43 AM, Jon Hunter wrote: On 07/10/15 00:04, Stephen Warren wrote: On 10/05/2015 06:10 AM, Jon Hunter

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-08 Thread Jon Hunter
On 07/10/15 20:36, Stephen Warren wrote: > On 10/07/2015 10:19 AM, Jon Hunter wrote: >> >> On 07/10/15 17:09, Stephen Warren wrote: >>> On 10/07/2015 02:43 AM, Jon Hunter wrote: On 07/10/15 00:04, Stephen Warren wrote: > On 10/05/2015 06:10 AM, Jon Hunter wrote: >> Add

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-08 Thread Jon Hunter
On 07/10/15 20:36, Stephen Warren wrote: > On 10/07/2015 10:19 AM, Jon Hunter wrote: >> >> On 07/10/15 17:09, Stephen Warren wrote: >>> On 10/07/2015 02:43 AM, Jon Hunter wrote: On 07/10/15 00:04, Stephen Warren wrote: > On 10/05/2015 06:10 AM, Jon Hunter wrote: >> Add

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-08 Thread Stephen Warren
On 10/08/2015 03:58 AM, Jon Hunter wrote: On 07/10/15 20:36, Stephen Warren wrote: On 10/07/2015 10:19 AM, Jon Hunter wrote: On 07/10/15 17:09, Stephen Warren wrote: On 10/07/2015 02:43 AM, Jon Hunter wrote: On 07/10/15 00:04, Stephen Warren wrote: On 10/05/2015 06:10 AM, Jon Hunter

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-07 Thread Stephen Warren
On 10/07/2015 10:19 AM, Jon Hunter wrote: On 07/10/15 17:09, Stephen Warren wrote: On 10/07/2015 02:43 AM, Jon Hunter wrote: On 07/10/15 00:04, Stephen Warren wrote: On 10/05/2015 06:10 AM, Jon Hunter wrote: Add device-tree binding documentation for the Tegra210 Audio DMA controller.

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-07 Thread Mark Rutland
On Wed, Oct 07, 2015 at 09:43:45AM +0100, Jon Hunter wrote: > > On 07/10/15 00:04, Stephen Warren wrote: > > On 10/05/2015 06:10 AM, Jon Hunter wrote: > >> Add device-tree binding documentation for the Tegra210 Audio DMA > >> controller. > > > >> diff --git

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-07 Thread Mark Rutland
[...] > >+- dma-channels: Must be 22. Defines the number of DMA channels > >supported > >+ by the DMA controller. > > If this has to be a fixed value, why is it necessary? Why does the > driver not just know this? > > Are there other instances of this IP block

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-07 Thread Jon Hunter
On 07/10/15 17:09, Stephen Warren wrote: > On 10/07/2015 02:43 AM, Jon Hunter wrote: >> >> On 07/10/15 00:04, Stephen Warren wrote: >>> On 10/05/2015 06:10 AM, Jon Hunter wrote: Add device-tree binding documentation for the Tegra210 Audio DMA controller. >>> diff --git

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-07 Thread Stephen Warren
On 10/07/2015 02:43 AM, Jon Hunter wrote: On 07/10/15 00:04, Stephen Warren wrote: On 10/05/2015 06:10 AM, Jon Hunter wrote: Add device-tree binding documentation for the Tegra210 Audio DMA controller. diff --git a/Documentation/devicetree/bindings/dma/tegra210-adma.txt

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-07 Thread Stephen Warren
On 10/07/2015 09:26 AM, Jon Hunter wrote: On 06/10/15 23:57, Stephen Warren wrote: On 10/06/2015 03:16 AM, Jon Hunter wrote: On 05/10/15 14:12, Mark Rutland wrote: On Mon, Oct 05, 2015 at 01:10:06PM +0100, Jon Hunter wrote: Add device-tree binding documentation for the Tegra210 Audio DMA

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-07 Thread Jon Hunter
On 06/10/15 23:57, Stephen Warren wrote: > On 10/06/2015 03:16 AM, Jon Hunter wrote: >> >> On 05/10/15 14:12, Mark Rutland wrote: >>> On Mon, Oct 05, 2015 at 01:10:06PM +0100, Jon Hunter wrote: Add device-tree binding documentation for the Tegra210 Audio DMA controller.

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-07 Thread Jon Hunter
On 07/10/15 00:04, Stephen Warren wrote: > On 10/05/2015 06:10 AM, Jon Hunter wrote: >> Add device-tree binding documentation for the Tegra210 Audio DMA >> controller. > >> diff --git a/Documentation/devicetree/bindings/dma/tegra210-adma.txt >>

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-07 Thread Jon Hunter
On 07/10/15 00:04, Stephen Warren wrote: > On 10/05/2015 06:10 AM, Jon Hunter wrote: >> Add device-tree binding documentation for the Tegra210 Audio DMA >> controller. > >> diff --git a/Documentation/devicetree/bindings/dma/tegra210-adma.txt >>

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-07 Thread Stephen Warren
On 10/07/2015 10:19 AM, Jon Hunter wrote: On 07/10/15 17:09, Stephen Warren wrote: On 10/07/2015 02:43 AM, Jon Hunter wrote: On 07/10/15 00:04, Stephen Warren wrote: On 10/05/2015 06:10 AM, Jon Hunter wrote: Add device-tree binding documentation for the Tegra210 Audio DMA controller.

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-07 Thread Jon Hunter
On 06/10/15 23:57, Stephen Warren wrote: > On 10/06/2015 03:16 AM, Jon Hunter wrote: >> >> On 05/10/15 14:12, Mark Rutland wrote: >>> On Mon, Oct 05, 2015 at 01:10:06PM +0100, Jon Hunter wrote: Add device-tree binding documentation for the Tegra210 Audio DMA controller.

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-07 Thread Stephen Warren
On 10/07/2015 09:26 AM, Jon Hunter wrote: On 06/10/15 23:57, Stephen Warren wrote: On 10/06/2015 03:16 AM, Jon Hunter wrote: On 05/10/15 14:12, Mark Rutland wrote: On Mon, Oct 05, 2015 at 01:10:06PM +0100, Jon Hunter wrote: Add device-tree binding documentation for the Tegra210 Audio DMA

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-07 Thread Stephen Warren
On 10/07/2015 02:43 AM, Jon Hunter wrote: On 07/10/15 00:04, Stephen Warren wrote: On 10/05/2015 06:10 AM, Jon Hunter wrote: Add device-tree binding documentation for the Tegra210 Audio DMA controller. diff --git a/Documentation/devicetree/bindings/dma/tegra210-adma.txt

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-07 Thread Jon Hunter
On 07/10/15 17:09, Stephen Warren wrote: > On 10/07/2015 02:43 AM, Jon Hunter wrote: >> >> On 07/10/15 00:04, Stephen Warren wrote: >>> On 10/05/2015 06:10 AM, Jon Hunter wrote: Add device-tree binding documentation for the Tegra210 Audio DMA controller. >>> diff --git

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-07 Thread Mark Rutland
[...] > >+- dma-channels: Must be 22. Defines the number of DMA channels > >supported > >+ by the DMA controller. > > If this has to be a fixed value, why is it necessary? Why does the > driver not just know this? > > Are there other instances of this IP block

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-07 Thread Mark Rutland
On Wed, Oct 07, 2015 at 09:43:45AM +0100, Jon Hunter wrote: > > On 07/10/15 00:04, Stephen Warren wrote: > > On 10/05/2015 06:10 AM, Jon Hunter wrote: > >> Add device-tree binding documentation for the Tegra210 Audio DMA > >> controller. > > > >> diff --git

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-06 Thread Stephen Warren
On 10/05/2015 06:10 AM, Jon Hunter wrote: Add device-tree binding documentation for the Tegra210 Audio DMA controller. diff --git a/Documentation/devicetree/bindings/dma/tegra210-adma.txt b/Documentation/devicetree/bindings/dma/tegra210-adma.txt +- #dma-cells : Must be <2>. The first cell

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-06 Thread Stephen Warren
On 10/06/2015 03:16 AM, Jon Hunter wrote: On 05/10/15 14:12, Mark Rutland wrote: On Mon, Oct 05, 2015 at 01:10:06PM +0100, Jon Hunter wrote: Add device-tree binding documentation for the Tegra210 Audio DMA controller. Signed-off-by: Jon Hunter ---

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-06 Thread Jon Hunter
On 05/10/15 14:12, Mark Rutland wrote: > On Mon, Oct 05, 2015 at 01:10:06PM +0100, Jon Hunter wrote: >> Add device-tree binding documentation for the Tegra210 Audio DMA >> controller. >> >> Signed-off-by: Jon Hunter >> --- >> .../devicetree/bindings/dma/tegra210-adma.txt | 63 >>

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-06 Thread Jon Hunter
On 05/10/15 14:12, Mark Rutland wrote: > On Mon, Oct 05, 2015 at 01:10:06PM +0100, Jon Hunter wrote: >> Add device-tree binding documentation for the Tegra210 Audio DMA >> controller. >> >> Signed-off-by: Jon Hunter >> --- >> .../devicetree/bindings/dma/tegra210-adma.txt

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-06 Thread Stephen Warren
On 10/06/2015 03:16 AM, Jon Hunter wrote: On 05/10/15 14:12, Mark Rutland wrote: On Mon, Oct 05, 2015 at 01:10:06PM +0100, Jon Hunter wrote: Add device-tree binding documentation for the Tegra210 Audio DMA controller. Signed-off-by: Jon Hunter ---

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-06 Thread Stephen Warren
On 10/05/2015 06:10 AM, Jon Hunter wrote: Add device-tree binding documentation for the Tegra210 Audio DMA controller. diff --git a/Documentation/devicetree/bindings/dma/tegra210-adma.txt b/Documentation/devicetree/bindings/dma/tegra210-adma.txt +- #dma-cells : Must be <2>. The first cell

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-05 Thread Mark Rutland
On Mon, Oct 05, 2015 at 01:10:06PM +0100, Jon Hunter wrote: > Add device-tree binding documentation for the Tegra210 Audio DMA > controller. > > Signed-off-by: Jon Hunter > --- > .../devicetree/bindings/dma/tegra210-adma.txt | 63 > ++ > 1 file changed, 63

[PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-05 Thread Jon Hunter
Add device-tree binding documentation for the Tegra210 Audio DMA controller. Signed-off-by: Jon Hunter --- .../devicetree/bindings/dma/tegra210-adma.txt | 63 ++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/dma/tegra210-adma.txt

Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-05 Thread Mark Rutland
On Mon, Oct 05, 2015 at 01:10:06PM +0100, Jon Hunter wrote: > Add device-tree binding documentation for the Tegra210 Audio DMA > controller. > > Signed-off-by: Jon Hunter > --- > .../devicetree/bindings/dma/tegra210-adma.txt | 63 > ++ > 1 file

[PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA

2015-10-05 Thread Jon Hunter
Add device-tree binding documentation for the Tegra210 Audio DMA controller. Signed-off-by: Jon Hunter --- .../devicetree/bindings/dma/tegra210-adma.txt | 63 ++ 1 file changed, 63 insertions(+) create mode 100644