Re: [PATCH V2 1/4] drivers: qcom: rpmh-rsc: simplify TCS locking

2019-07-24 Thread Lina Iyer
On Wed, Jul 24 2019 at 12:32 -0600, Stephen Boyd wrote: Quoting Lina Iyer (2019-07-24 07:54:52) On Tue, Jul 23 2019 at 14:19 -0600, Stephen Boyd wrote: >Quoting Lina Iyer (2019-07-23 12:21:59) >> On Tue, Jul 23 2019 at 12:22 -0600, Stephen Boyd wrote: >> >Can you keep irq saving and restoring

Re: [PATCH V2 1/4] drivers: qcom: rpmh-rsc: simplify TCS locking

2019-07-24 Thread Stephen Boyd
Quoting Lina Iyer (2019-07-24 07:54:52) > On Tue, Jul 23 2019 at 14:19 -0600, Stephen Boyd wrote: > >Quoting Lina Iyer (2019-07-23 12:21:59) > >> On Tue, Jul 23 2019 at 12:22 -0600, Stephen Boyd wrote: > >> >Can you keep irq saving and restoring in this patch and then remove that > >> >in the next

Re: [PATCH V2 1/4] drivers: qcom: rpmh-rsc: simplify TCS locking

2019-07-24 Thread Lina Iyer
On Tue, Jul 23 2019 at 14:19 -0600, Stephen Boyd wrote: Quoting Lina Iyer (2019-07-23 12:21:59) On Tue, Jul 23 2019 at 12:22 -0600, Stephen Boyd wrote: >Quoting Lina Iyer (2019-07-22 14:53:37) >> From: "Raju P.L.S.S.S.N" >> >> The tcs->lock was introduced to serialize access with in TCS group.

Re: [PATCH V2 1/4] drivers: qcom: rpmh-rsc: simplify TCS locking

2019-07-23 Thread Stephen Boyd
Quoting Lina Iyer (2019-07-23 12:21:59) > On Tue, Jul 23 2019 at 12:22 -0600, Stephen Boyd wrote: > >Quoting Lina Iyer (2019-07-22 14:53:37) > >> From: "Raju P.L.S.S.S.N" > >> > >> The tcs->lock was introduced to serialize access with in TCS group. But, > >> drv->lock is still needed to

Re: [PATCH V2 1/4] drivers: qcom: rpmh-rsc: simplify TCS locking

2019-07-23 Thread Lina Iyer
On Tue, Jul 23 2019 at 12:22 -0600, Stephen Boyd wrote: Quoting Lina Iyer (2019-07-22 14:53:37) From: "Raju P.L.S.S.S.N" The tcs->lock was introduced to serialize access with in TCS group. But, drv->lock is still needed to synchronize core aspects of the communication. This puts the drv->lock

Re: [PATCH V2 1/4] drivers: qcom: rpmh-rsc: simplify TCS locking

2019-07-23 Thread Stephen Boyd
Quoting Lina Iyer (2019-07-22 14:53:37) > From: "Raju P.L.S.S.S.N" > > The tcs->lock was introduced to serialize access with in TCS group. But, > drv->lock is still needed to synchronize core aspects of the > communication. This puts the drv->lock in the critical and high latency > path of

[PATCH V2 1/4] drivers: qcom: rpmh-rsc: simplify TCS locking

2019-07-22 Thread Lina Iyer
From: "Raju P.L.S.S.S.N" The tcs->lock was introduced to serialize access with in TCS group. But, drv->lock is still needed to synchronize core aspects of the communication. This puts the drv->lock in the critical and high latency path of sending a request. drv->lock provides the all necessary