Re: [PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute

2017-07-26 Thread Peter Zijlstra
On Wed, Jul 26, 2017 at 11:12:03AM +0530, Pratyush Anand wrote: > I too had thought to put it under include/linux/perf_event.h : struct > perf_event. But, see hw_break_module_init() which does not have knowledge of > this structure, and we need to have some way so that none-perf kernel module >

Re: [PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute

2017-07-26 Thread Peter Zijlstra
On Wed, Jul 26, 2017 at 11:12:03AM +0530, Pratyush Anand wrote: > I too had thought to put it under include/linux/perf_event.h : struct > perf_event. But, see hw_break_module_init() which does not have knowledge of > this structure, and we need to have some way so that none-perf kernel module >

Re: [PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute

2017-07-25 Thread Pratyush Anand
On Tuesday 25 July 2017 06:57 PM, Will Deacon wrote: On Fri, Jul 07, 2017 at 05:33:57PM +0530, Pratyush Anand wrote: Architecture like ARM64 currently allows to use default hw breakpoint single step handler only to perf. However, some other users like few systemtap tests or kernel test in

Re: [PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute

2017-07-25 Thread Pratyush Anand
On Tuesday 25 July 2017 06:57 PM, Will Deacon wrote: On Fri, Jul 07, 2017 at 05:33:57PM +0530, Pratyush Anand wrote: Architecture like ARM64 currently allows to use default hw breakpoint single step handler only to perf. However, some other users like few systemtap tests or kernel test in

Re: [PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute

2017-07-25 Thread Mark Rutland
On Tue, Jul 25, 2017 at 04:14:23PM +0200, Peter Zijlstra wrote: > On Tue, Jul 25, 2017 at 02:27:38PM +0100, Will Deacon wrote: > > On Fri, Jul 07, 2017 at 05:33:57PM +0530, Pratyush Anand wrote: > > > Architecture like ARM64 currently allows to use default hw breakpoint > > > single step handler

Re: [PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute

2017-07-25 Thread Mark Rutland
On Tue, Jul 25, 2017 at 04:14:23PM +0200, Peter Zijlstra wrote: > On Tue, Jul 25, 2017 at 02:27:38PM +0100, Will Deacon wrote: > > On Fri, Jul 07, 2017 at 05:33:57PM +0530, Pratyush Anand wrote: > > > Architecture like ARM64 currently allows to use default hw breakpoint > > > single step handler

Re: [PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute

2017-07-25 Thread Peter Zijlstra
On Tue, Jul 25, 2017 at 02:27:38PM +0100, Will Deacon wrote: > On Fri, Jul 07, 2017 at 05:33:57PM +0530, Pratyush Anand wrote: > > Architecture like ARM64 currently allows to use default hw breakpoint > > single step handler only to perf. However, some other users like few > > systemtap tests or

Re: [PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute

2017-07-25 Thread Peter Zijlstra
On Tue, Jul 25, 2017 at 02:27:38PM +0100, Will Deacon wrote: > On Fri, Jul 07, 2017 at 05:33:57PM +0530, Pratyush Anand wrote: > > Architecture like ARM64 currently allows to use default hw breakpoint > > single step handler only to perf. However, some other users like few > > systemtap tests or

Re: [PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute

2017-07-25 Thread Will Deacon
On Fri, Jul 07, 2017 at 05:33:57PM +0530, Pratyush Anand wrote: > Architecture like ARM64 currently allows to use default hw breakpoint > single step handler only to perf. However, some other users like few > systemtap tests or kernel test in > samples/hw_breakpoint/data_breakpoint.c can also work

Re: [PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute

2017-07-25 Thread Will Deacon
On Fri, Jul 07, 2017 at 05:33:57PM +0530, Pratyush Anand wrote: > Architecture like ARM64 currently allows to use default hw breakpoint > single step handler only to perf. However, some other users like few > systemtap tests or kernel test in > samples/hw_breakpoint/data_breakpoint.c can also work

[PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute

2017-07-07 Thread Pratyush Anand
Architecture like ARM64 currently allows to use default hw breakpoint single step handler only to perf. However, some other users like few systemtap tests or kernel test in samples/hw_breakpoint/data_breakpoint.c can also work with default step handler implementation. At the same time, some other

[PATCH V2 1/4] hw_breakpoint: Add step_needed event attribute

2017-07-07 Thread Pratyush Anand
Architecture like ARM64 currently allows to use default hw breakpoint single step handler only to perf. However, some other users like few systemtap tests or kernel test in samples/hw_breakpoint/data_breakpoint.c can also work with default step handler implementation. At the same time, some other