Re: Re: [PATCH V2 2/2] Input: rotaty-encoder - Add DT binding document

2019-03-21 Thread Alexey Slepov
Hello, i used this rotary-encoder patch in my embedded project and found two errors: First, in drivers/input/misc/rotary_encoder.c, at @@ -237,6 +244,16 @@: instead of +    if (err) +    dev_err(dev, "unable to get keycodes: %d\n", err); +    return err; it must be +   

Re: [PATCH V2 2/2] Input: rotaty-encoder - Add DT binding document

2019-01-15 Thread Rob Herring
On Mon, Jan 14, 2019 at 07:52:21PM -0800, Dmitry Torokhov wrote: > On Tue, Jan 08, 2019 at 01:42:49AM +0900, Donghoon Han wrote: > > Add DT binding document for rotary-encoder, keycode options. > > > > Signed-off-by: Donghoon Han > > Cc: Dmitry Torokhov > > Cc: Daniel Mack > > Cc:

Re: [PATCH V2 2/2] Input: rotaty-encoder - Add DT binding document

2019-01-14 Thread Dmitry Torokhov
[ resending to Rob... ] On Tue, Jan 08, 2019 at 01:42:49AM +0900, Donghoon Han wrote: > Add DT binding document for rotary-encoder, keycode options. > > Signed-off-by: Donghoon Han > Cc: Dmitry Torokhov > Cc: Daniel Mack > Cc: devicet...@vger.kernel.org > To: linux-in...@vger.kernel.org > ---

Re: [PATCH V2 2/2] Input: rotaty-encoder - Add DT binding document

2019-01-14 Thread Dmitry Torokhov
On Tue, Jan 08, 2019 at 01:42:49AM +0900, Donghoon Han wrote: > Add DT binding document for rotary-encoder, keycode options. > > Signed-off-by: Donghoon Han > Cc: Dmitry Torokhov > Cc: Daniel Mack > Cc: devicet...@vger.kernel.org > To: linux-in...@vger.kernel.org > --- >

[PATCH V2 2/2] Input: rotaty-encoder - Add DT binding document

2019-01-07 Thread Donghoon Han
Add DT binding document for rotary-encoder, keycode options. Signed-off-by: Donghoon Han Cc: Dmitry Torokhov Cc: Daniel Mack Cc: devicet...@vger.kernel.org To: linux-in...@vger.kernel.org --- .../devicetree/bindings/input/rotary-encoder.txt | 12 1 file changed, 12