Re: [PATCH V2 2/2] apple_gmux: Add support for newer hardware

2012-08-15 Thread Bernhard Froemel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/14/2012 07:11 PM, Bernhard Froemel wrote: > Need to play around further.. I think I solved the communication problems concerning byte writes to the gmux device. This: http://luna.vmars.tuwien.ac.at/~froemel/rmbp/patch-apple-gmux_v2.txt works

Re: [PATCH V2 2/2] apple_gmux: Add support for newer hardware

2012-08-15 Thread Bernhard Froemel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/14/2012 07:11 PM, Bernhard Froemel wrote: Need to play around further.. I think I solved the communication problems concerning byte writes to the gmux device. This: http://luna.vmars.tuwien.ac.at/~froemel/rmbp/patch-apple-gmux_v2.txt works

Re: [PATCH V2 2/2] apple_gmux: Add support for newer hardware

2012-08-14 Thread Bernhard Froemel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/14/2012 05:15 PM, Seth Forshee wrote: > On Tue, Aug 14, 2012 at 04:53:47PM +0200, Bernhard Froemel wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> Only in relation to Seth's future apple-gmux patch series about >> vgaswitcheroo

Re: [PATCH V2 2/2] apple_gmux: Add support for newer hardware

2012-08-14 Thread Seth Forshee
On Tue, Aug 14, 2012 at 04:53:47PM +0200, Bernhard Froemel wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Only in relation to Seth's future apple-gmux patch series about > vgaswitcheroo and restoring the gmux device configuration across > suspend/resume [1]: > On resume the gmux

Re: [PATCH V2 2/2] apple_gmux: Add support for newer hardware

2012-08-14 Thread Bernhard Froemel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Please reduce the delay in the gmux_index_wait_[ready|complete] functions: 100ms is way too long. 1 ms is more than enough. I never experienced any problems with 100 us. The version information can also be extracted in the new gmux device (see my

Re: [PATCH V2 2/2] apple_gmux: Add support for newer hardware

2012-08-14 Thread Bernhard Froemel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Only in relation to Seth's future apple-gmux patch series about vgaswitcheroo and restoring the gmux device configuration across suspend/resume [1]: On resume the gmux registers 0x28 (DDC) and 0x10 (SWITCH_DISPLAY) (i.e., the first two writes) are not

Re: [PATCH V2 2/2] apple_gmux: Add support for newer hardware

2012-08-14 Thread Bernhard Froemel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Only in relation to Seth's future apple-gmux patch series about vgaswitcheroo and restoring the gmux device configuration across suspend/resume [1]: On resume the gmux registers 0x28 (DDC) and 0x10 (SWITCH_DISPLAY) (i.e., the first two writes) are not

Re: [PATCH V2 2/2] apple_gmux: Add support for newer hardware

2012-08-14 Thread Bernhard Froemel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Please reduce the delay in the gmux_index_wait_[ready|complete] functions: 100ms is way too long. 1 ms is more than enough. I never experienced any problems with 100 us. The version information can also be extracted in the new gmux device (see my

Re: [PATCH V2 2/2] apple_gmux: Add support for newer hardware

2012-08-14 Thread Seth Forshee
On Tue, Aug 14, 2012 at 04:53:47PM +0200, Bernhard Froemel wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Only in relation to Seth's future apple-gmux patch series about vgaswitcheroo and restoring the gmux device configuration across suspend/resume [1]: On resume the gmux registers

Re: [PATCH V2 2/2] apple_gmux: Add support for newer hardware

2012-08-14 Thread Bernhard Froemel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/14/2012 05:15 PM, Seth Forshee wrote: On Tue, Aug 14, 2012 at 04:53:47PM +0200, Bernhard Froemel wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Only in relation to Seth's future apple-gmux patch series about vgaswitcheroo and

Re: [PATCH V2 2/2] apple_gmux: Add support for newer hardware

2012-08-13 Thread Seth Forshee
On Mon, Aug 13, 2012 at 06:52:49PM -0400, Matthew Garrett wrote: > New gmux devices have a different method for accessing the registers. > Update the driver to cope. Incorporates feedback from Bernhard Froemel. > > Signed-off-by: Matthew Garrett > Cc: Bernhard Froemel > Cc: Seth Forshee

[PATCH V2 2/2] apple_gmux: Add support for newer hardware

2012-08-13 Thread Matthew Garrett
New gmux devices have a different method for accessing the registers. Update the driver to cope. Incorporates feedback from Bernhard Froemel. Signed-off-by: Matthew Garrett Cc: Bernhard Froemel Cc: Seth Forshee --- drivers/platform/x86/apple-gmux.c | 179 +++---

[PATCH V2 2/2] apple_gmux: Add support for newer hardware

2012-08-13 Thread Matthew Garrett
New gmux devices have a different method for accessing the registers. Update the driver to cope. Incorporates feedback from Bernhard Froemel. Signed-off-by: Matthew Garrett m...@redhat.com Cc: Bernhard Froemel froe...@vmars.tuwien.ac.at Cc: Seth Forshee seth.fors...@canonical.com ---

Re: [PATCH V2 2/2] apple_gmux: Add support for newer hardware

2012-08-13 Thread Seth Forshee
On Mon, Aug 13, 2012 at 06:52:49PM -0400, Matthew Garrett wrote: New gmux devices have a different method for accessing the registers. Update the driver to cope. Incorporates feedback from Bernhard Froemel. Signed-off-by: Matthew Garrett m...@redhat.com Cc: Bernhard Froemel