Re: [PATCH V2 2/2] hrtimer: Iterate only over active clock-bases

2015-04-08 Thread Viresh Kumar
On 9 April 2015 at 01:41, Thomas Gleixner wrote: > I'm really not too excited about this incomprehensible macro mess and > especially not about the code it generates. > > x86_64 i386ARM power > > Mainline76686942807710253 > > + Patch 8068

Re: [PATCH V2 2/2] hrtimer: Iterate only over active clock-bases

2015-04-08 Thread Thomas Gleixner
On Tue, 7 Apr 2015, Viresh Kumar wrote: > At several instances we iterate over all possible clock-bases for a > particular cpu-base. Whereas, we only need to iterate over active bases. > > We already have per cpu-base 'active_bases' field, which is updated on > addition/removal of hrtimers. > >

Re: [PATCH V2 2/2] hrtimer: Iterate only over active clock-bases

2015-04-08 Thread Peter Zijlstra
On Tue, Apr 07, 2015 at 07:40:53AM +0530, Viresh Kumar wrote: > At several instances we iterate over all possible clock-bases for a > particular cpu-base. Whereas, we only need to iterate over active bases. > > We already have per cpu-base 'active_bases' field, which is updated on >

Re: [PATCH V2 2/2] hrtimer: Iterate only over active clock-bases

2015-04-08 Thread Peter Zijlstra
On Tue, Apr 07, 2015 at 07:40:53AM +0530, Viresh Kumar wrote: At several instances we iterate over all possible clock-bases for a particular cpu-base. Whereas, we only need to iterate over active bases. We already have per cpu-base 'active_bases' field, which is updated on addition/removal

Re: [PATCH V2 2/2] hrtimer: Iterate only over active clock-bases

2015-04-08 Thread Thomas Gleixner
On Tue, 7 Apr 2015, Viresh Kumar wrote: At several instances we iterate over all possible clock-bases for a particular cpu-base. Whereas, we only need to iterate over active bases. We already have per cpu-base 'active_bases' field, which is updated on addition/removal of hrtimers. This

Re: [PATCH V2 2/2] hrtimer: Iterate only over active clock-bases

2015-04-08 Thread Viresh Kumar
On 9 April 2015 at 01:41, Thomas Gleixner t...@linutronix.de wrote: I'm really not too excited about this incomprehensible macro mess and especially not about the code it generates. x86_64 i386ARM power Mainline76686942807710253 + Patch

[PATCH V2 2/2] hrtimer: Iterate only over active clock-bases

2015-04-06 Thread Viresh Kumar
At several instances we iterate over all possible clock-bases for a particular cpu-base. Whereas, we only need to iterate over active bases. We already have per cpu-base 'active_bases' field, which is updated on addition/removal of hrtimers. This patch creates for_each_active_base(), which uses

[PATCH V2 2/2] hrtimer: Iterate only over active clock-bases

2015-04-06 Thread Viresh Kumar
At several instances we iterate over all possible clock-bases for a particular cpu-base. Whereas, we only need to iterate over active bases. We already have per cpu-base 'active_bases' field, which is updated on addition/removal of hrtimers. This patch creates for_each_active_base(), which uses