Re: [PATCH V2 2/2] hrtimer: use __ffs() to iterate over valid bits from active_bases

2014-03-26 Thread Viresh Kumar
On 27 March 2014 11:10, Thomas Gleixner wrote: > What if this is a spurious interrupt and active_bases is 0? Hmm.. haven't thought about that actually.. I thought it would be guaranteed here that active_bases isn't zero. Will fix it as the current code would end up in a infinite loop. -- To unsu

Re: [PATCH V2 2/2] hrtimer: use __ffs() to iterate over valid bits from active_bases

2014-03-26 Thread Thomas Gleixner
On Thu, 27 Mar 2014, Viresh Kumar wrote: > Currently we are iterating over all possible (currently four) bits of > active_bases to see if corresponding clock bases are active. This is good > enough > for cases where 3 or 4 bases are used but if only 1 or 2 are used then it > makes > more sense t

[PATCH V2 2/2] hrtimer: use __ffs() to iterate over valid bits from active_bases

2014-03-26 Thread Viresh Kumar
Currently we are iterating over all possible (currently four) bits of active_bases to see if corresponding clock bases are active. This is good enough for cases where 3 or 4 bases are used but if only 1 or 2 are used then it makes more sense to use __ffs() to find the right bit directly. Suggested