Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-06-08 Thread Bhuvanchandra DV
On 06/08/2015 02:42 PM, Russell King - ARM Linux wrote: On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote: +/* + * CTS/RTS can _only_ be handled + * automatically by the hardware. + */ That's really not acceptable. You need to do something here so that you can

Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-06-08 Thread Russell King - ARM Linux
On Mon, Jun 08, 2015 at 08:41:13AM +0200, Uwe Kleine-König wrote: > >From reading the commit log I would expect that you only touch the > set_mctrl function, but not get_mctrl. Assuming your code change is > right, can you mention this in the commit log please? The bits > UARTMODEM_TXCTSE and

Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-06-08 Thread Russell King - ARM Linux
On Mon, Jun 08, 2015 at 08:41:13AM +0200, Uwe Kleine-König wrote: > Hello, > > On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote: > > The LPUART does not provide manual control of RTS/CTS signals, > > those can only be controlled by the hardware directly. Therefore > > manual

Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-06-08 Thread Russell King - ARM Linux
On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote: > +/* > + * CTS/RTS can _only_ be handled > + * automatically by the hardware. > + */ That's really not acceptable. You need to do something here so that you can _force_ RTS to be deasserted when the kernel buffers

Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-06-08 Thread Bhuvanchandra DV
Hello, On 06/08/2015 12:11 PM, Uwe Kleine-König wrote: Hello, On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote: The LPUART does not provide manual control of RTS/CTS signals, those can only be controlled by the hardware directly. Therefore manual control of those signals

Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-06-08 Thread Uwe Kleine-König
Hello, On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote: > The LPUART does not provide manual control of RTS/CTS signals, > those can only be controlled by the hardware directly. Therefore > manual control of those signals through mctrl can not be provided. > The current

Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-06-08 Thread Bhuvanchandra DV
On 06/08/2015 02:42 PM, Russell King - ARM Linux wrote: On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote: +/* + * CTS/RTS can _only_ be handled + * automatically by the hardware. + */ That's really not acceptable. You need to do something here so that you can

Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-06-08 Thread Bhuvanchandra DV
Hello, On 06/08/2015 12:11 PM, Uwe Kleine-König wrote: Hello, On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote: The LPUART does not provide manual control of RTS/CTS signals, those can only be controlled by the hardware directly. Therefore manual control of those signals

Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-06-08 Thread Uwe Kleine-König
Hello, On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote: The LPUART does not provide manual control of RTS/CTS signals, those can only be controlled by the hardware directly. Therefore manual control of those signals through mctrl can not be provided. The current

Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-06-08 Thread Russell King - ARM Linux
On Mon, Jun 08, 2015 at 08:41:13AM +0200, Uwe Kleine-König wrote: Hello, On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote: The LPUART does not provide manual control of RTS/CTS signals, those can only be controlled by the hardware directly. Therefore manual control of

Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-06-08 Thread Russell King - ARM Linux
On Mon, Jun 08, 2015 at 08:41:13AM +0200, Uwe Kleine-König wrote: From reading the commit log I would expect that you only touch the set_mctrl function, but not get_mctrl. Assuming your code change is right, can you mention this in the commit log please? The bits UARTMODEM_TXCTSE and

Re: [PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-06-08 Thread Russell King - ARM Linux
On Mon, Jun 01, 2015 at 10:51:06AM +0530, Bhuvanchandra DV wrote: +/* + * CTS/RTS can _only_ be handled + * automatically by the hardware. + */ That's really not acceptable. You need to do something here so that you can _force_ RTS to be deasserted when the kernel buffers

[PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-05-31 Thread Bhuvanchandra DV
The LPUART does not provide manual control of RTS/CTS signals, those can only be controlled by the hardware directly. Therefore manual control of those signals through mctrl can not be provided. The current implementation enables/disables the automatic control, which is not what mctrl should do,

[PATCH V2 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl

2015-05-31 Thread Bhuvanchandra DV
The LPUART does not provide manual control of RTS/CTS signals, those can only be controlled by the hardware directly. Therefore manual control of those signals through mctrl can not be provided. The current implementation enables/disables the automatic control, which is not what mctrl should do,