Re: [PATCH V2 2/4] drivers: qcom: rpmh-rsc: avoid locking in the interrupt handler

2019-07-30 Thread Lina Iyer
On Mon, Jul 29 2019 at 14:56 -0600, Stephen Boyd wrote: Quoting Lina Iyer (2019-07-29 12:01:39) On Thu, Jul 25 2019 at 09:44 -0600, Doug Anderson wrote: >On Thu, Jul 25, 2019 at 8:18 AM Lina Iyer wrote: >> >> On Wed, Jul 24 2019 at 17:28 -0600, Doug Anderson wrote: >> > >> >Jumping in without

Re: [PATCH V2 2/4] drivers: qcom: rpmh-rsc: avoid locking in the interrupt handler

2019-07-29 Thread Stephen Boyd
Quoting Lina Iyer (2019-07-29 12:01:39) > On Thu, Jul 25 2019 at 09:44 -0600, Doug Anderson wrote: > >On Thu, Jul 25, 2019 at 8:18 AM Lina Iyer wrote: > >> > >> On Wed, Jul 24 2019 at 17:28 -0600, Doug Anderson wrote: > >> > > >> >Jumping in without reading all the context, but I saw this fly by

Re: [PATCH V2 2/4] drivers: qcom: rpmh-rsc: avoid locking in the interrupt handler

2019-07-29 Thread Lina Iyer
On Thu, Jul 25 2019 at 09:44 -0600, Doug Anderson wrote: Hi, On Thu, Jul 25, 2019 at 8:18 AM Lina Iyer wrote: On Wed, Jul 24 2019 at 17:28 -0600, Doug Anderson wrote: >Hi, > >On Wed, Jul 24, 2019 at 1:36 PM Lina Iyer wrote: >> >> On Wed, Jul 24 2019 at 13:38 -0600, Stephen Boyd wrote: >>

Re: [PATCH V2 2/4] drivers: qcom: rpmh-rsc: avoid locking in the interrupt handler

2019-07-25 Thread Doug Anderson
Hi, On Thu, Jul 25, 2019 at 8:18 AM Lina Iyer wrote: > > On Wed, Jul 24 2019 at 17:28 -0600, Doug Anderson wrote: > >Hi, > > > >On Wed, Jul 24, 2019 at 1:36 PM Lina Iyer wrote: > >> > >> On Wed, Jul 24 2019 at 13:38 -0600, Stephen Boyd wrote: > >> >Quoting Lina Iyer (2019-07-24 07:52:51) > >>

Re: [PATCH V2 2/4] drivers: qcom: rpmh-rsc: avoid locking in the interrupt handler

2019-07-25 Thread Lina Iyer
On Wed, Jul 24 2019 at 17:28 -0600, Doug Anderson wrote: Hi, On Wed, Jul 24, 2019 at 1:36 PM Lina Iyer wrote: On Wed, Jul 24 2019 at 13:38 -0600, Stephen Boyd wrote: >Quoting Lina Iyer (2019-07-24 07:52:51) >> On Tue, Jul 23 2019 at 14:11 -0600, Stephen Boyd wrote: >> >Quoting Lina Iyer

Re: [PATCH V2 2/4] drivers: qcom: rpmh-rsc: avoid locking in the interrupt handler

2019-07-24 Thread Doug Anderson
Hi, On Wed, Jul 24, 2019 at 1:36 PM Lina Iyer wrote: > > On Wed, Jul 24 2019 at 13:38 -0600, Stephen Boyd wrote: > >Quoting Lina Iyer (2019-07-24 07:52:51) > >> On Tue, Jul 23 2019 at 14:11 -0600, Stephen Boyd wrote: > >> >Quoting Lina Iyer (2019-07-22 14:53:38) > >> >> Avoid locking in the

Re: [PATCH V2 2/4] drivers: qcom: rpmh-rsc: avoid locking in the interrupt handler

2019-07-24 Thread Lina Iyer
On Wed, Jul 24 2019 at 13:38 -0600, Stephen Boyd wrote: Quoting Lina Iyer (2019-07-24 07:52:51) On Tue, Jul 23 2019 at 14:11 -0600, Stephen Boyd wrote: >Quoting Lina Iyer (2019-07-22 14:53:38) >> Avoid locking in the interrupt context to improve latency. Since we >> don't lock in the interrupt

Re: [PATCH V2 2/4] drivers: qcom: rpmh-rsc: avoid locking in the interrupt handler

2019-07-24 Thread Stephen Boyd
Quoting Lina Iyer (2019-07-24 07:52:51) > On Tue, Jul 23 2019 at 14:11 -0600, Stephen Boyd wrote: > >Quoting Lina Iyer (2019-07-22 14:53:38) > >> Avoid locking in the interrupt context to improve latency. Since we > >> don't lock in the interrupt context, it is possible that we now could > >> race

Re: [PATCH V2 2/4] drivers: qcom: rpmh-rsc: avoid locking in the interrupt handler

2019-07-24 Thread Lina Iyer
On Tue, Jul 23 2019 at 14:11 -0600, Stephen Boyd wrote: Quoting Lina Iyer (2019-07-22 14:53:38) Avoid locking in the interrupt context to improve latency. Since we don't lock in the interrupt context, it is possible that we now could race with the DRV_CONTROL register that writes the enable

Re: [PATCH V2 2/4] drivers: qcom: rpmh-rsc: avoid locking in the interrupt handler

2019-07-23 Thread Stephen Boyd
Quoting Lina Iyer (2019-07-22 14:53:38) > Avoid locking in the interrupt context to improve latency. Since we > don't lock in the interrupt context, it is possible that we now could > race with the DRV_CONTROL register that writes the enable register and > cleared by the interrupt handler. For

[PATCH V2 2/4] drivers: qcom: rpmh-rsc: avoid locking in the interrupt handler

2019-07-22 Thread Lina Iyer
Avoid locking in the interrupt context to improve latency. Since we don't lock in the interrupt context, it is possible that we now could race with the DRV_CONTROL register that writes the enable register and cleared by the interrupt handler. For fire-n-forget requests, the interrupt may be raised