Re: [PATCH V2 2/4] gpio: gpio-f81504: Add Fintek F81504/508/512 PCIE-to-UART/GPIO GPIOLIB support

2016-02-15 Thread Peter Hung
Hi Linus, Linus Walleij 於 2016/2/10 下午 05:08 寫道: On Thu, Jan 28, 2016 at 10:20 AM, Peter Hung wrote: +#include +#include Drivers should just #include ok. +static struct f81504_gpio_chip *gpio_to_f81504_chip(struct gpio_chip *chip) +{ + return container_of(chip, struct f81504_gpi

Re: [PATCH V2 2/4] gpio: gpio-f81504: Add Fintek F81504/508/512 PCIE-to-UART/GPIO GPIOLIB support

2016-02-10 Thread Linus Walleij
On Thu, Jan 28, 2016 at 10:20 AM, Peter Hung wrote: > This driver is GPIOLIB driver for F81504/508/512, it'll handle the > GPIOLIB operation of this device. This module will depend on > MFD_FINTEK_F81504_CORE. > > IC function list: > F81504: Max 2x8 GPIOs and max 4 serial ports > port

Re: [PATCH V2 2/4] gpio: gpio-f81504: Add Fintek F81504/508/512 PCIE-to-UART/GPIO GPIOLIB support

2016-01-29 Thread Peter Hung
Hi Andy, Andy Shevchenko 於 2016/1/28 下午 08:03 寫道: On Thu, 2016-01-28 at 17:20 +0800, Peter Hung wrote: + /* set output data */ + tmp = inb(priv->gpio_ioaddr + gc->idx); ioread8 is a bit better since it automatically works with IO space and MMIO. But if you are certain you will alw

Re: [PATCH V2 2/4] gpio: gpio-f81504: Add Fintek F81504/508/512 PCIE-to-UART/GPIO GPIOLIB support

2016-01-28 Thread Andy Shevchenko
On Thu, 2016-01-28 at 17:20 +0800, Peter Hung wrote: > This driver is GPIOLIB driver for F81504/508/512, it'll handle the > GPIOLIB operation of this device. This module will depend on > MFD_FINTEK_F81504_CORE. > > + /* > +  * The GPIO default driven mode for this device is open- > drai

Re: [PATCH V2 2/4] gpio: gpio-f81504: Add Fintek F81504/508/512 PCIE-to-UART/GPIO GPIOLIB support

2016-01-28 Thread kbuild test robot
Hi Peter, [auto build test ERROR on gpio/for-next] [also build test ERROR on v4.5-rc1 next-20160128] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Peter-Hung/Transform-Fintek-PCIE-driver-from

[PATCH V2 2/4] gpio: gpio-f81504: Add Fintek F81504/508/512 PCIE-to-UART/GPIO GPIOLIB support

2016-01-28 Thread Peter Hung
This driver is GPIOLIB driver for F81504/508/512, it'll handle the GPIOLIB operation of this device. This module will depend on MFD_FINTEK_F81504_CORE. IC function list: F81504: Max 2x8 GPIOs and max 4 serial ports port2/3 are multi-function F81508: Max 6x8 GPIOs and max 8 serial p