RE: [PATCH V2 2/8] perf tools: rewrite perf mmap read for overwrite

2017-12-19 Thread Liang, Kan
> >>> +int perf_mmap__read_catchup(struct perf_mmap *map, > >>> + bool overwrite, > >>> + u64 *start, u64 *end, > >>> + unsigned long *size) > >>>{ > >>> - u64 head; > >>> + u64 head = perf_mmap__read_head(map); > >>> + u64 old = map->

Re: [PATCH V2 2/8] perf tools: rewrite perf mmap read for overwrite

2017-12-18 Thread Wangnan (F)
On 2017/12/19 3:07, Liang, Kan wrote: -union perf_event *perf_mmap__read_backward(struct perf_mmap *map) +union perf_event *perf_mmap__read_backward(struct perf_mmap *map, + u64 *start, u64 end) { - u64 head, end; - u64 start = map->prev;

RE: [PATCH V2 2/8] perf tools: rewrite perf mmap read for overwrite

2017-12-18 Thread Liang, Kan
> > -union perf_event *perf_mmap__read_backward(struct perf_mmap *map) > > +union perf_event *perf_mmap__read_backward(struct perf_mmap *map, > > + u64 *start, u64 end) > > { > > - u64 head, end; > > - u64 start = map->prev; > > - > > - /* > > -* Ch

Re: [PATCH V2 2/8] perf tools: rewrite perf mmap read for overwrite

2017-12-18 Thread Wangnan (F)
On 2017/12/7 7:32, kan.li...@intel.com wrote: From: Kan Liang perf_mmap__read_catchup and perf_mmap__read_backward are used to read events one by one from ring buffer under overwrite mode. It always read the stale buffer which is already processed. Because the previous location of processed r

[PATCH V2 2/8] perf tools: rewrite perf mmap read for overwrite

2017-12-06 Thread kan . liang
From: Kan Liang perf_mmap__read_catchup and perf_mmap__read_backward are used to read events one by one from ring buffer under overwrite mode. It always read the stale buffer which is already processed. Because the previous location of processed ring buffer is discarded. Introducing the perf_mma