Re: [PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-29 Thread Rafael J. Wysocki
On Wednesday, October 29, 2014 09:54:43 AM Kevin Hilman wrote: > Daniel Lezcano writes: > > > On 10/28/2014 08:01 AM, Preeti Murthy wrote: > >> On Thu, Oct 23, 2014 at 2:31 PM, Daniel Lezcano > >> wrote: > >>> In the current code, the check to reflect or not the outcoming state is > >>> done >

Re: [PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-29 Thread Kevin Hilman
Daniel Lezcano writes: > On 10/28/2014 08:01 AM, Preeti Murthy wrote: >> On Thu, Oct 23, 2014 at 2:31 PM, Daniel Lezcano >> wrote: >>> In the current code, the check to reflect or not the outcoming state is done >>> against the idle state which has been chosen and its value. >>> >>> Instead of

Re: [PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-29 Thread Kevin Hilman
Daniel Lezcano daniel.lezc...@linaro.org writes: On 10/28/2014 08:01 AM, Preeti Murthy wrote: On Thu, Oct 23, 2014 at 2:31 PM, Daniel Lezcano daniel.lezc...@linaro.org wrote: In the current code, the check to reflect or not the outcoming state is done against the idle state which has been

Re: [PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-29 Thread Rafael J. Wysocki
On Wednesday, October 29, 2014 09:54:43 AM Kevin Hilman wrote: Daniel Lezcano daniel.lezc...@linaro.org writes: On 10/28/2014 08:01 AM, Preeti Murthy wrote: On Thu, Oct 23, 2014 at 2:31 PM, Daniel Lezcano daniel.lezc...@linaro.org wrote: In the current code, the check to reflect or not

Re: [PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-28 Thread Preeti U Murthy
On 10/28/2014 11:58 PM, Daniel Lezcano wrote: > On 10/28/2014 08:01 AM, Preeti Murthy wrote: >> On Thu, Oct 23, 2014 at 2:31 PM, Daniel Lezcano >> wrote: >>> In the current code, the check to reflect or not the outcoming state >>> is done >>> against the idle state which has been chosen and its

Re: [PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-28 Thread Daniel Lezcano
On 10/28/2014 03:01 AM, Len Brown wrote: On Thu, Oct 23, 2014 at 5:01 AM, Daniel Lezcano wrote: In the current code, the check to reflect or not the outcoming state is done against the idle state which has been chosen and its value. Instead of doing a check in each of the reflect functions,

Re: [PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-28 Thread Daniel Lezcano
On 10/28/2014 08:01 AM, Preeti Murthy wrote: On Thu, Oct 23, 2014 at 2:31 PM, Daniel Lezcano wrote: In the current code, the check to reflect or not the outcoming state is done against the idle state which has been chosen and its value. Instead of doing a check in each of the reflect

Re: [PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-28 Thread Preeti Murthy
On Thu, Oct 23, 2014 at 2:31 PM, Daniel Lezcano wrote: > In the current code, the check to reflect or not the outcoming state is done > against the idle state which has been chosen and its value. > > Instead of doing a check in each of the reflect functions, just don't call > reflect > if

Re: [PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-28 Thread Preeti Murthy
On Thu, Oct 23, 2014 at 2:31 PM, Daniel Lezcano daniel.lezc...@linaro.org wrote: In the current code, the check to reflect or not the outcoming state is done against the idle state which has been chosen and its value. Instead of doing a check in each of the reflect functions, just don't call

Re: [PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-28 Thread Daniel Lezcano
On 10/28/2014 08:01 AM, Preeti Murthy wrote: On Thu, Oct 23, 2014 at 2:31 PM, Daniel Lezcano daniel.lezc...@linaro.org wrote: In the current code, the check to reflect or not the outcoming state is done against the idle state which has been chosen and its value. Instead of doing a check in

Re: [PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-28 Thread Daniel Lezcano
On 10/28/2014 03:01 AM, Len Brown wrote: On Thu, Oct 23, 2014 at 5:01 AM, Daniel Lezcano daniel.lezc...@linaro.org wrote: In the current code, the check to reflect or not the outcoming state is done against the idle state which has been chosen and its value. Instead of doing a check in each of

Re: [PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-28 Thread Preeti U Murthy
On 10/28/2014 11:58 PM, Daniel Lezcano wrote: On 10/28/2014 08:01 AM, Preeti Murthy wrote: On Thu, Oct 23, 2014 at 2:31 PM, Daniel Lezcano daniel.lezc...@linaro.org wrote: In the current code, the check to reflect or not the outcoming state is done against the idle state which has been

Re: [PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-27 Thread Len Brown
On Thu, Oct 23, 2014 at 5:01 AM, Daniel Lezcano wrote: > In the current code, the check to reflect or not the outcoming state is done > against the idle state which has been chosen and its value. > > Instead of doing a check in each of the reflect functions, just don't call > reflect > if

Re: [PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-27 Thread Len Brown
On Thu, Oct 23, 2014 at 5:01 AM, Daniel Lezcano daniel.lezc...@linaro.org wrote: In the current code, the check to reflect or not the outcoming state is done against the idle state which has been chosen and its value. Instead of doing a check in each of the reflect functions, just don't call

[PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-23 Thread Daniel Lezcano
In the current code, the check to reflect or not the outcoming state is done against the idle state which has been chosen and its value. Instead of doing a check in each of the reflect functions, just don't call reflect if something went wrong in the idle path. Signed-off-by: Daniel Lezcano

[PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-23 Thread Daniel Lezcano
In the current code, the check to reflect or not the outcoming state is done against the idle state which has been chosen and its value. Instead of doing a check in each of the reflect functions, just don't call reflect if something went wrong in the idle path. Signed-off-by: Daniel Lezcano