Re: [PATCH V2 4/5] arch_topology: Return 0 or -ve errors from topology_parse_cpu_capacity()

2017-06-22 Thread Juri Lelli
On 22/06/17 19:58, Viresh Kumar wrote: > On 22-06-17, 10:39, Juri Lelli wrote: > > Hi, > > > > On 21/06/17 10:16, Viresh Kumar wrote: > > > Use the standard way of returning errors instead of returning 0(failure) > > > OR 1(success) and making it hard to read. > > > > > > Signed-off-by: Viresh

Re: [PATCH V2 4/5] arch_topology: Return 0 or -ve errors from topology_parse_cpu_capacity()

2017-06-22 Thread Juri Lelli
On 22/06/17 19:58, Viresh Kumar wrote: > On 22-06-17, 10:39, Juri Lelli wrote: > > Hi, > > > > On 21/06/17 10:16, Viresh Kumar wrote: > > > Use the standard way of returning errors instead of returning 0(failure) > > > OR 1(success) and making it hard to read. > > > > > > Signed-off-by: Viresh

Re: [PATCH V2 4/5] arch_topology: Return 0 or -ve errors from topology_parse_cpu_capacity()

2017-06-22 Thread Viresh Kumar
On 22-06-17, 10:39, Juri Lelli wrote: > Hi, > > On 21/06/17 10:16, Viresh Kumar wrote: > > Use the standard way of returning errors instead of returning 0(failure) > > OR 1(success) and making it hard to read. > > > > Signed-off-by: Viresh Kumar > > --- > >

Re: [PATCH V2 4/5] arch_topology: Return 0 or -ve errors from topology_parse_cpu_capacity()

2017-06-22 Thread Viresh Kumar
On 22-06-17, 10:39, Juri Lelli wrote: > Hi, > > On 21/06/17 10:16, Viresh Kumar wrote: > > Use the standard way of returning errors instead of returning 0(failure) > > OR 1(success) and making it hard to read. > > > > Signed-off-by: Viresh Kumar > > --- > > arch/arm/kernel/topology.c | 2 +-

Re: [PATCH V2 4/5] arch_topology: Return 0 or -ve errors from topology_parse_cpu_capacity()

2017-06-22 Thread Juri Lelli
Hi, On 21/06/17 10:16, Viresh Kumar wrote: > Use the standard way of returning errors instead of returning 0(failure) > OR 1(success) and making it hard to read. > > Signed-off-by: Viresh Kumar > --- > arch/arm/kernel/topology.c | 2 +- > drivers/base/arch_topology.c

Re: [PATCH V2 4/5] arch_topology: Return 0 or -ve errors from topology_parse_cpu_capacity()

2017-06-22 Thread Juri Lelli
Hi, On 21/06/17 10:16, Viresh Kumar wrote: > Use the standard way of returning errors instead of returning 0(failure) > OR 1(success) and making it hard to read. > > Signed-off-by: Viresh Kumar > --- > arch/arm/kernel/topology.c | 2 +- > drivers/base/arch_topology.c | 8 > 2 files

[PATCH V2 4/5] arch_topology: Return 0 or -ve errors from topology_parse_cpu_capacity()

2017-06-20 Thread Viresh Kumar
Use the standard way of returning errors instead of returning 0(failure) OR 1(success) and making it hard to read. Signed-off-by: Viresh Kumar --- arch/arm/kernel/topology.c | 2 +- drivers/base/arch_topology.c | 8 2 files changed, 5 insertions(+), 5

[PATCH V2 4/5] arch_topology: Return 0 or -ve errors from topology_parse_cpu_capacity()

2017-06-20 Thread Viresh Kumar
Use the standard way of returning errors instead of returning 0(failure) OR 1(success) and making it hard to read. Signed-off-by: Viresh Kumar --- arch/arm/kernel/topology.c | 2 +- drivers/base/arch_topology.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git