Re: [PATCH V2 6/6] gicv2m: acpi: Introducing GICv2m ACPI support

2015-10-15 Thread Suravee Suthikulanit
Hi Tomasz, On 10/15/2015 9:03 AM, Suravee Suthikulanit wrote: +if (!data) +return NULL; + +return data->fwnode; +} + +static int __init +acpi_parse_madt_msi(struct acpi_subtable_header *header, +const unsigned long end) +{ +int ret; +struct resource res; +

Re: [PATCH V2 6/6] gicv2m: acpi: Introducing GICv2m ACPI support

2015-10-15 Thread Suravee Suthikulanit
Hi Tomasz, Thanks for the feedback. On 10/15/2015 1:15 AM, Tomasz Nowicki wrote: [..] @@ -138,6 +140,11 @@ static int gicv2m_irq_gic_domain_alloc(struct irq_domain *domain, fwspec.param[0] = 0; fwspec.param[1] = hwirq - 32; fwspec.param[2] = IRQ_TYPE_EDGE_RISING; +

Re: [PATCH V2 6/6] gicv2m: acpi: Introducing GICv2m ACPI support

2015-10-14 Thread Tomasz Nowicki
On 15.10.2015 08:15, Tomasz Nowicki wrote: Hi Suravee, [...] Moreover, seems we need to add irq_domain_free_fwnode to gicv2m_teardown(): static void gicv2m_teardown(void) { struct v2m_data *v2m, *tmp; list_for_each_entry_safe(v2m, tmp, &v2m_nodes, entry) { +struct fw

Re: [PATCH V2 6/6] gicv2m: acpi: Introducing GICv2m ACPI support

2015-10-14 Thread Tomasz Nowicki
Hi Suravee, On 15.10.2015 01:25, Suravee Suthikulpanit wrote: This patch introduces gicv2m_acpi_init(), which uses information in MADT GIC MSI frames structure to initialize GICv2m driver. Signed-off-by: Suravee Suthikulpanit Signed-off-by: Hanjun Guo --- drivers/irqchip/irq-gic-v2m.c | 9

[PATCH V2 6/6] gicv2m: acpi: Introducing GICv2m ACPI support

2015-10-14 Thread Suravee Suthikulpanit
This patch introduces gicv2m_acpi_init(), which uses information in MADT GIC MSI frames structure to initialize GICv2m driver. Signed-off-by: Suravee Suthikulpanit Signed-off-by: Hanjun Guo --- drivers/irqchip/irq-gic-v2m.c | 94 + drivers/irqchip/irq-g