Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Jeff Merkey
I cleaned up the areas you identified and I am building and testing the the patch with the debugger test harness. As soon as it passes the build completes and it passes the test harness I will submit v4 of the patch. Jeff On 12/19/15, Thomas Gleixner wrote: > On Mon, 14 Dec 2015, Jeff Merkey

Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Jeff Merkey
On 12/19/15, Thomas Gleixner wrote: > On Mon, 14 Dec 2015, Jeff Merkey wrote: >> +/* >> +* check if we got an execute breakpoint >> +* from the dr7 register. if we did, set >> +* the resume flag to avoid int1 recursion. > > Malformatted comment as

Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Thomas Gleixner
On Mon, 14 Dec 2015, Jeff Merkey wrote: > + /* > + * check if we got an execute breakpoint > + * from the dr7 register. if we did, set > + * the resume flag to avoid int1 recursion. Malformatted comment as any other comment you touched. > +

Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Jeff Merkey
On 12/19/15, Thomas Gleixner wrote: > On Mon, 14 Dec 2015, Jeff Merkey wrote: >> +/* >> +* check if we got an execute breakpoint >> +* from the dr7 register. if we did, set >> +* the resume flag to avoid int1 recursion. > >

Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Jeff Merkey
I cleaned up the areas you identified and I am building and testing the the patch with the debugger test harness. As soon as it passes the build completes and it passes the test harness I will submit v4 of the patch. Jeff On 12/19/15, Thomas Gleixner wrote: > On Mon, 14

Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

2015-12-19 Thread Thomas Gleixner
On Mon, 14 Dec 2015, Jeff Merkey wrote: > + /* > + * check if we got an execute breakpoint > + * from the dr7 register. if we did, set > + * the resume flag to avoid int1 recursion. Malformatted comment as any other comment you touched. > +

Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

2015-12-15 Thread Jeff Merkey
Please let me know if there is anything else that needs to be added to this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

2015-12-15 Thread Jeff Merkey
> kgdb/kdb and the perf event system both present garbage status in dr6 > then subsequently write this status into the thread.debugreg6 variable, > then in some cases call hw_breakpoint_restore() which writes this > status back into the dr6 hardware register. > I wanted to note here that this is

Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

2015-12-15 Thread Jeff Merkey
> kgdb/kdb and the perf event system both present garbage status in dr6 > then subsequently write this status into the thread.debugreg6 variable, > then in some cases call hw_breakpoint_restore() which writes this > status back into the dr6 hardware register. > I wanted to note here that this is

Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

2015-12-15 Thread Jeff Merkey
Please let me know if there is anything else that needs to be added to this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

[PATCH V3] Fix INT1 Recursion with unregistered breakpoints

2015-12-14 Thread Jeff Merkey
Please consider the attached patch. SUMMARY This patch corrects a hard lockup failure of the system kernel if the operating system receives a breakpoint exception at a code execution address which was not registered with the operating system. The patch allows kernel debuggers, application

[PATCH V3] Fix INT1 Recursion with unregistered breakpoints

2015-12-14 Thread Jeff Merkey
Please consider the attached patch. SUMMARY This patch corrects a hard lockup failure of the system kernel if the operating system receives a breakpoint exception at a code execution address which was not registered with the operating system. The patch allows kernel debuggers, application