Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-29 Thread SF Markus Elfring
> I hope you had information you wanted from Julia ? Yes. - I am waiting on another Coccinelle software release which will contain improvements for my feature requests and bug reports. I'm curious when I should retry proposed filter patterns. Regards, Markus -- To unsubscribe from this

Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-29 Thread SF Markus Elfring
>> https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html >> http://marc.info/?l=kernel-janitors=139405971927100=2 > Regular expressions do not allow taking advantage of the optimizations > provided by Coccinelle and are not easy for a reader to understand. I find that the application of

Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-29 Thread Fabian Frederick
On Sat, 28 Jun 2014 23:00:22 +0200 SF Markus Elfring wrote: > > Sorry but I'm not working on coccinelle ; just did a small script for > > kernel tree. > > I would appreciate a more constructive feedback for my update suggestions > around > the topic "Deletion of unnecessary checks before

Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-29 Thread Fabian Frederick
On Sat, 28 Jun 2014 23:00:22 +0200 SF Markus Elfring elfr...@users.sourceforge.net wrote: Sorry but I'm not working on coccinelle ; just did a small script for kernel tree. I would appreciate a more constructive feedback for my update suggestions around the topic Deletion of

Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-29 Thread SF Markus Elfring
https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html http://marc.info/?l=kernel-janitorsm=139405971927100w=2 Regular expressions do not allow taking advantage of the optimizations provided by Coccinelle and are not easy for a reader to understand. I find that the application of

Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-29 Thread SF Markus Elfring
I hope you had information you wanted from Julia ? Yes. - I am waiting on another Coccinelle software release which will contain improvements for my feature requests and bug reports. I'm curious when I should retry proposed filter patterns. Regards, Markus -- To unsubscribe from this

Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread Julia Lawall
On Sat, 28 Jun 2014, SF Markus Elfring wrote: > > Sorry but I'm not working on coccinelle ; just did a small script for > > kernel tree. > > I would appreciate a more constructive feedback for my update suggestions > around > the topic "Deletion of unnecessary checks before specific function

Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread SF Markus Elfring
> Sorry but I'm not working on coccinelle ; just did a small script for kernel > tree. I would appreciate a more constructive feedback for my update suggestions around the topic "Deletion of unnecessary checks before specific function calls". - Did you look at the concrete patches? - How do you

Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread Julia Lawall
On Sat, 28 Jun 2014, SF Markus Elfring wrote: > > > V3: > >-Update print_main message. > > Does the discussion topic need also an adjustment? > > How do you think about my previous update suggestion "Deletion of > unnecessary checks before specific function calls"? >

Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread Fabian Frederick
On Sat, 28 Jun 2014 13:38:15 +0200 SF Markus Elfring wrote: > > >> How do you think about my previous update suggestion "Deletion of > >> unnecessary checks before specific function calls"? > >> https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html > >>

Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread SF Markus Elfring
>> How do you think about my previous update suggestion "Deletion of >> unnecessary checks before specific function calls"? >> https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html >> https://lkml.org/lkml/2014/3/5/344 > I didn't see you made the same kind of script. Will my

Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread Fabian Frederick
On Sat, 28 Jun 2014 11:08:35 +0200 SF Markus Elfring wrote: > > > V3: > >-Update print_main message. > > Does the discussion topic need also an adjustment? > > How do you think about my previous update suggestion "Deletion of > unnecessary checks before specific function calls"? >

Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread SF Markus Elfring
> V3: >-Update print_main message. Does the discussion topic need also an adjustment? How do you think about my previous update suggestion "Deletion of unnecessary checks before specific function calls"? https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html

Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread SF Markus Elfring
V3: -Update print_main message. Does the discussion topic need also an adjustment? How do you think about my previous update suggestion Deletion of unnecessary checks before specific function calls? https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html

Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread Fabian Frederick
On Sat, 28 Jun 2014 11:08:35 +0200 SF Markus Elfring elfr...@users.sourceforge.net wrote: V3: -Update print_main message. Does the discussion topic need also an adjustment? How do you think about my previous update suggestion Deletion of unnecessary checks before specific

Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread SF Markus Elfring
How do you think about my previous update suggestion Deletion of unnecessary checks before specific function calls? https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html https://lkml.org/lkml/2014/3/5/344 I didn't see you made the same kind of script. Will my approach become a

Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread Fabian Frederick
On Sat, 28 Jun 2014 13:38:15 +0200 SF Markus Elfring elfr...@users.sourceforge.net wrote: How do you think about my previous update suggestion Deletion of unnecessary checks before specific function calls? https://systeme.lip6.fr/pipermail/cocci/2014-March/000675.html

Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread Julia Lawall
On Sat, 28 Jun 2014, SF Markus Elfring wrote: V3: -Update print_main message. Does the discussion topic need also an adjustment? How do you think about my previous update suggestion Deletion of unnecessary checks before specific function calls?

Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread SF Markus Elfring
Sorry but I'm not working on coccinelle ; just did a small script for kernel tree. I would appreciate a more constructive feedback for my update suggestions around the topic Deletion of unnecessary checks before specific function calls. - Did you look at the concrete patches? - How do you

Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread Julia Lawall
On Sat, 28 Jun 2014, SF Markus Elfring wrote: Sorry but I'm not working on coccinelle ; just did a small script for kernel tree. I would appreciate a more constructive feedback for my update suggestions around the topic Deletion of unnecessary checks before specific function calls. -