Re: [PATCH V3 1/2] sched/fair: Fix load_balance() affinity redo path

2017-05-23 Thread Jeffrey Hugo
On 5/23/2017 5:45 AM, Dietmar Eggemann wrote: Hey Austin, On 22/05/17 20:57, Christ, Austin wrote: Hey Dietmar, On 5/22/2017 3:48 AM, Dietmar Eggemann wrote: On 19/05/17 14:31, Dietmar Eggemann wrote: On 18/05/17 20:36, Jeffrey Hugo wrote: [...] diff --git a/kernel/sched/fair.c

Re: [PATCH V3 1/2] sched/fair: Fix load_balance() affinity redo path

2017-05-23 Thread Jeffrey Hugo
On 5/23/2017 5:45 AM, Dietmar Eggemann wrote: Hey Austin, On 22/05/17 20:57, Christ, Austin wrote: Hey Dietmar, On 5/22/2017 3:48 AM, Dietmar Eggemann wrote: On 19/05/17 14:31, Dietmar Eggemann wrote: On 18/05/17 20:36, Jeffrey Hugo wrote: [...] diff --git a/kernel/sched/fair.c

Re: [PATCH V3 1/2] sched/fair: Fix load_balance() affinity redo path

2017-05-23 Thread Dietmar Eggemann
Hey Austin, On 22/05/17 20:57, Christ, Austin wrote: > Hey Dietmar, > > > On 5/22/2017 3:48 AM, Dietmar Eggemann wrote: >> On 19/05/17 14:31, Dietmar Eggemann wrote: >>> On 18/05/17 20:36, Jeffrey Hugo wrote: >>> >>> [...] >>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c

Re: [PATCH V3 1/2] sched/fair: Fix load_balance() affinity redo path

2017-05-23 Thread Dietmar Eggemann
Hey Austin, On 22/05/17 20:57, Christ, Austin wrote: > Hey Dietmar, > > > On 5/22/2017 3:48 AM, Dietmar Eggemann wrote: >> On 19/05/17 14:31, Dietmar Eggemann wrote: >>> On 18/05/17 20:36, Jeffrey Hugo wrote: >>> >>> [...] >>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c

Re: [PATCH V3 1/2] sched/fair: Fix load_balance() affinity redo path

2017-05-22 Thread Christ, Austin
Hey Dietmar, On 5/22/2017 3:48 AM, Dietmar Eggemann wrote: On 19/05/17 14:31, Dietmar Eggemann wrote: On 18/05/17 20:36, Jeffrey Hugo wrote: [...] diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index d711093..a5d41b1 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@

Re: [PATCH V3 1/2] sched/fair: Fix load_balance() affinity redo path

2017-05-22 Thread Christ, Austin
Hey Dietmar, On 5/22/2017 3:48 AM, Dietmar Eggemann wrote: On 19/05/17 14:31, Dietmar Eggemann wrote: On 18/05/17 20:36, Jeffrey Hugo wrote: [...] diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index d711093..a5d41b1 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@

Re: [PATCH V3 1/2] sched/fair: Fix load_balance() affinity redo path

2017-05-22 Thread Dietmar Eggemann
On 19/05/17 14:31, Dietmar Eggemann wrote: > On 18/05/17 20:36, Jeffrey Hugo wrote: > > [...] > >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> index d711093..a5d41b1 100644 >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c >> @@ -8220,7 +8220,24 @@ static int

Re: [PATCH V3 1/2] sched/fair: Fix load_balance() affinity redo path

2017-05-22 Thread Dietmar Eggemann
On 19/05/17 14:31, Dietmar Eggemann wrote: > On 18/05/17 20:36, Jeffrey Hugo wrote: > > [...] > >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> index d711093..a5d41b1 100644 >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c >> @@ -8220,7 +8220,24 @@ static int

Re: [PATCH V3 1/2] sched/fair: Fix load_balance() affinity redo path

2017-05-19 Thread Dietmar Eggemann
On 18/05/17 20:36, Jeffrey Hugo wrote: [...] > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index d711093..a5d41b1 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -8220,7 +8220,24 @@ static int load_balance(int this_cpu, struct rq > *this_rq, > /*

Re: [PATCH V3 1/2] sched/fair: Fix load_balance() affinity redo path

2017-05-19 Thread Dietmar Eggemann
On 18/05/17 20:36, Jeffrey Hugo wrote: [...] > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index d711093..a5d41b1 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -8220,7 +8220,24 @@ static int load_balance(int this_cpu, struct rq > *this_rq, > /*

[PATCH V3 1/2] sched/fair: Fix load_balance() affinity redo path

2017-05-18 Thread Jeffrey Hugo
If load_balance() fails to migrate any tasks because all tasks were affined, load_balance() removes the source cpu from consideration and attempts to redo and balance among the new subset of cpus. There is a bug in this code path where the algorithm considers all active cpus in the system (minus

[PATCH V3 1/2] sched/fair: Fix load_balance() affinity redo path

2017-05-18 Thread Jeffrey Hugo
If load_balance() fails to migrate any tasks because all tasks were affined, load_balance() removes the source cpu from consideration and attempts to redo and balance among the new subset of cpus. There is a bug in this code path where the algorithm considers all active cpus in the system (minus