Re: [PATCH V3 1/3] cpufreq: Fix locking issues with governors

2020-06-29 Thread Rafael J. Wysocki
On Mon, Jun 29, 2020 at 4:13 AM Viresh Kumar wrote: > > On 26-06-20, 09:24, Quentin Perret wrote: > > On Friday 26 Jun 2020 at 09:21:42 (+0530), Viresh Kumar wrote: > > > The locking around governors handling isn't adequate currently. The list > > > of governors should never be traversed without

Re: [PATCH V3 1/3] cpufreq: Fix locking issues with governors

2020-06-29 Thread Quentin Perret
On Monday 29 Jun 2020 at 07:43:09 (+0530), Viresh Kumar wrote: > I described why I chose to keep it that way in the other email, but I > am all for dropping the variable. And so what about this ? > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index

Re: [PATCH V3 1/3] cpufreq: Fix locking issues with governors

2020-06-28 Thread Viresh Kumar
On 26-06-20, 09:24, Quentin Perret wrote: > On Friday 26 Jun 2020 at 09:21:42 (+0530), Viresh Kumar wrote: > > The locking around governors handling isn't adequate currently. The list > > of governors should never be traversed without locking in place. Also we > > must make sure the governor isn't

Re: [PATCH V3 1/3] cpufreq: Fix locking issues with governors

2020-06-26 Thread Quentin Perret
On Friday 26 Jun 2020 at 09:21:42 (+0530), Viresh Kumar wrote: > The locking around governors handling isn't adequate currently. The list > of governors should never be traversed without locking in place. Also we > must make sure the governor isn't removed while it is still referenced > by code. >

[PATCH V3 1/3] cpufreq: Fix locking issues with governors

2020-06-25 Thread Viresh Kumar
The locking around governors handling isn't adequate currently. The list of governors should never be traversed without locking in place. Also we must make sure the governor isn't removed while it is still referenced by code. Reported-by: Quentin Perret Signed-off-by: Viresh Kumar ---