Re: [PATCH V3 2/2] tee: add OP-TEE driver

2015-06-18 Thread Jens Wiklander
On Fri, Jun 05, 2015 at 11:48:14AM +0100, Mark Rutland wrote: [...] > > The OP-TEE message protocol is primarily for the OP-TEE driver. Other > > TEE drivers plugging into this framwork may use this protocol too, but I > > guess that most will use their own message protocol. > > > > Provided that

Re: [PATCH V3 2/2] tee: add OP-TEE driver

2015-06-18 Thread Jens Wiklander
On Fri, Jun 05, 2015 at 11:48:14AM +0100, Mark Rutland wrote: [...] The OP-TEE message protocol is primarily for the OP-TEE driver. Other TEE drivers plugging into this framwork may use this protocol too, but I guess that most will use their own message protocol. Provided that each TEE

Re: [PATCH V3 2/2] tee: add OP-TEE driver

2015-06-05 Thread Mark Rutland
> > > > I'm also very concerned that the interface exposed to userspace is > > > > hideously low-level. Surely we'd expect kernel-side drivers to be doing > > > > the bulk of direct communication to the OP-TEE instance? In the lack of > > > > a provided rationale I don't see why the current

Re: [PATCH V3 2/2] tee: add OP-TEE driver

2015-06-05 Thread Mark Rutland
I'm also very concerned that the interface exposed to userspace is hideously low-level. Surely we'd expect kernel-side drivers to be doing the bulk of direct communication to the OP-TEE instance? In the lack of a provided rationale I don't see why the current messaging interface

Re: [PATCH V3 2/2] tee: add OP-TEE driver

2015-06-04 Thread Mark Brown
On Wed, May 20, 2015 at 02:16:48PM +0200, Jens Wiklander wrote: > > > +#define OPTEE_SMC_SHM_NONCACHED0ULL > > > +#define OPTEE_SMC_SHM_CACHED 1ULL > > What precise set of memory attributes do these imply? ... > OP-TEE is more or less always compiled for a specific

Re: [PATCH V3 2/2] tee: add OP-TEE driver

2015-06-04 Thread Mark Brown
On Wed, May 20, 2015 at 02:16:48PM +0200, Jens Wiklander wrote: +#define OPTEE_SMC_SHM_NONCACHED0ULL +#define OPTEE_SMC_SHM_CACHED 1ULL What precise set of memory attributes do these imply? ... OP-TEE is more or less always compiled for a specific platform so

Re: [PATCH V3 2/2] tee: add OP-TEE driver

2015-05-25 Thread Jens Wiklander
On Fri, May 22, 2015 at 05:27:59PM +0100, Mark Rutland wrote: > On Wed, May 20, 2015 at 01:16:48PM +0100, Jens Wiklander wrote: > > Hi, > > > > On Mon, May 18, 2015 at 02:18:50PM +0100, Mark Rutland wrote: > > > Hi, > > > > > > On Fri, May 15, 2015 at 07:34:27AM +0100, Jens Wiklander wrote: > > >

Re: [PATCH V3 2/2] tee: add OP-TEE driver

2015-05-25 Thread Jens Wiklander
On Fri, May 22, 2015 at 05:27:59PM +0100, Mark Rutland wrote: On Wed, May 20, 2015 at 01:16:48PM +0100, Jens Wiklander wrote: Hi, On Mon, May 18, 2015 at 02:18:50PM +0100, Mark Rutland wrote: Hi, On Fri, May 15, 2015 at 07:34:27AM +0100, Jens Wiklander wrote: Adds a OP-TEE

Re: [PATCH V3 2/2] tee: add OP-TEE driver

2015-05-22 Thread Mark Rutland
On Wed, May 20, 2015 at 01:16:48PM +0100, Jens Wiklander wrote: > Hi, > > On Mon, May 18, 2015 at 02:18:50PM +0100, Mark Rutland wrote: > > Hi, > > > > On Fri, May 15, 2015 at 07:34:27AM +0100, Jens Wiklander wrote: > > > Adds a OP-TEE driver which also can be compiled as a loadable module. > > >

Re: [PATCH V3 2/2] tee: add OP-TEE driver

2015-05-22 Thread Mark Rutland
On Wed, May 20, 2015 at 01:16:48PM +0100, Jens Wiklander wrote: Hi, On Mon, May 18, 2015 at 02:18:50PM +0100, Mark Rutland wrote: Hi, On Fri, May 15, 2015 at 07:34:27AM +0100, Jens Wiklander wrote: Adds a OP-TEE driver which also can be compiled as a loadable module. * Targets

Re: [PATCH V3 2/2] tee: add OP-TEE driver

2015-05-20 Thread Javier González
Hi, Just for completeness, > On 20 May 2015, at 14:16, Jens Wiklander wrote: > > Hi, > > On Mon, May 18, 2015 at 02:18:50PM +0100, Mark Rutland wrote: >> Hi, >> >> On Fri, May 15, 2015 at 07:34:27AM +0100, Jens Wiklander wrote: > […] >> >> I'm also very concerned that the interface exposed

Re: [PATCH V3 2/2] tee: add OP-TEE driver

2015-05-20 Thread Jens Wiklander
Hi, On Mon, May 18, 2015 at 02:18:50PM +0100, Mark Rutland wrote: > Hi, > > On Fri, May 15, 2015 at 07:34:27AM +0100, Jens Wiklander wrote: > > Adds a OP-TEE driver which also can be compiled as a loadable module. > > > > * Targets ARM and ARM64 > > * Supports using reserved memory from OP-TEE

Re: [PATCH V3 2/2] tee: add OP-TEE driver

2015-05-20 Thread Jens Wiklander
Hi, On Mon, May 18, 2015 at 02:18:50PM +0100, Mark Rutland wrote: Hi, On Fri, May 15, 2015 at 07:34:27AM +0100, Jens Wiklander wrote: Adds a OP-TEE driver which also can be compiled as a loadable module. * Targets ARM and ARM64 * Supports using reserved memory from OP-TEE as shared

Re: [PATCH V3 2/2] tee: add OP-TEE driver

2015-05-20 Thread Javier González
Hi, Just for completeness, On 20 May 2015, at 14:16, Jens Wiklander jens.wiklan...@linaro.org wrote: Hi, On Mon, May 18, 2015 at 02:18:50PM +0100, Mark Rutland wrote: Hi, On Fri, May 15, 2015 at 07:34:27AM +0100, Jens Wiklander wrote: […] I'm also very concerned that the

Re: [PATCH V3 2/2] tee: add OP-TEE driver

2015-05-18 Thread Mark Rutland
Hi, On Fri, May 15, 2015 at 07:34:27AM +0100, Jens Wiklander wrote: > Adds a OP-TEE driver which also can be compiled as a loadable module. > > * Targets ARM and ARM64 > * Supports using reserved memory from OP-TEE as shared memory > * CMA as shared memory is optional and only tried if OP-TEE

Re: [PATCH V3 2/2] tee: add OP-TEE driver

2015-05-18 Thread Mark Rutland
Hi, On Fri, May 15, 2015 at 07:34:27AM +0100, Jens Wiklander wrote: Adds a OP-TEE driver which also can be compiled as a loadable module. * Targets ARM and ARM64 * Supports using reserved memory from OP-TEE as shared memory * CMA as shared memory is optional and only tried if OP-TEE doesn't

[PATCH V3 2/2] tee: add OP-TEE driver

2015-05-15 Thread Jens Wiklander
Adds a OP-TEE driver which also can be compiled as a loadable module. * Targets ARM and ARM64 * Supports using reserved memory from OP-TEE as shared memory * CMA as shared memory is optional and only tried if OP-TEE doesn't supply a reserved shared memory region * Probes OP-TEE version using

[PATCH V3 2/2] tee: add OP-TEE driver

2015-05-15 Thread Jens Wiklander
Adds a OP-TEE driver which also can be compiled as a loadable module. * Targets ARM and ARM64 * Supports using reserved memory from OP-TEE as shared memory * CMA as shared memory is optional and only tried if OP-TEE doesn't supply a reserved shared memory region * Probes OP-TEE version using