Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors

2013-03-27 Thread Viresh Kumar
On 27 March 2013 17:05, Viresh Kumar wrote: > On 27 March 2013 15:34, Viresh Kumar wrote: >> I am still stuck at a issue, which i am not able to fix. >> - cat of */cpufreq/ondemand/** isn't showing anything on console, but all >> pointers are correctly set and i can see the right values with pr

Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors

2013-03-27 Thread Viresh Kumar
On 27 March 2013 15:34, Viresh Kumar wrote: > I am still stuck at a issue, which i am not able to fix. > - cat of */cpufreq/ondemand/** isn't showing anything on console, but all > pointers are correctly set and i can see the right values with printk() The culprit is the part where i changed pr

Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors

2013-03-27 Thread Viresh Kumar
On 27 March 2013 09:59, Viresh Kumar wrote: > On 27 March 2013 01:18, Jacob Shin wrote: >> Hmm .. I don't think this works for both ondemand and conservative >> governors running at the same time . Hi Jacob, This must be early morning for you and you must be looking for something to start with

Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors

2013-03-26 Thread Viresh Kumar
On 27 March 2013 01:18, Jacob Shin wrote: > On Wed, Mar 27, 2013 at 01:02:15AM +0530, Viresh Kumar wrote: >> +struct dbs_data *gdbs_data; >> + > > Hmm .. I don't think this works for both ondemand and conservative > governors running at the same time . Yes, this should fix it (untested for now, i

Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors

2013-03-26 Thread Jacob Shin
On Wed, Mar 27, 2013 at 01:02:15AM +0530, Viresh Kumar wrote: > On 26 March 2013 20:50, Jacob Shin wrote: > > Hi, latest bleeding-edge is spewing this out on boot: > > > > [3.585157] [ cut here ] > > [3.592227] WARNING: at fs/sysfs/dir.c:536 sysfs_add_one+0xc8/0x100

Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors

2013-03-26 Thread Viresh Kumar
On 26 March 2013 20:50, Jacob Shin wrote: > Hi, latest bleeding-edge is spewing this out on boot: > > [3.585157] [ cut here ] > [3.592227] WARNING: at fs/sysfs/dir.c:536 sysfs_add_one+0xc8/0x100() > [3.599521] Hardware name: Dinar > [3.606878] sysfs: cannot

Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors

2013-03-26 Thread Jacob Shin
On Fri, Mar 22, 2013 at 12:44:40AM +0100, Rafael J. Wysocki wrote: > On Wednesday, March 20, 2013 10:59:13 AM Viresh Kumar wrote: > > On 4 March 2013 13:07, Viresh Kumar wrote: > > > Currently, there can't be multiple instances of single governor_type. If > > > we have > > > a multi-package syste

Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors

2013-03-22 Thread Viresh Kumar
On 22 March 2013 17:41, Rafael J. Wysocki wrote: > Well, if the submitter wants to cheat, she/he certainly can this way, but > what's the benefit, honestly? If the reviewer actually notices that there are > more differences than the submitter admits to, the consequences may be quite > unpleasant

Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors

2013-03-22 Thread Rafael J. Wysocki
On Friday, March 22, 2013 05:21:19 PM Viresh Kumar wrote: > On Fri, Mar 22, 2013 at 5:25 PM, Rafael J. Wysocki wrote: > > On Friday, March 22, 2013 07:50:54 AM Viresh Kumar wrote: > > >> Hmm... I always thought fixups are way easy to review (and i still > >> believe that's > >> true) as they just

Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors

2013-03-22 Thread Viresh Kumar
On Fri, Mar 22, 2013 at 5:25 PM, Rafael J. Wysocki wrote: > On Friday, March 22, 2013 07:50:54 AM Viresh Kumar wrote: >> Hmm... I always thought fixups are way easy to review (and i still >> believe that's >> true) as they just contain what got changed and so people don't have to >> review >> wh

Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors

2013-03-22 Thread Rafael J. Wysocki
On Friday, March 22, 2013 07:50:54 AM Viresh Kumar wrote: > On 22 March 2013 05:14, Rafael J. Wysocki wrote: > > On Wednesday, March 20, 2013 10:59:13 AM Viresh Kumar wrote: > > >> I have queued all patches i had for 3.10 here: > >> > >> http://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=s

Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors

2013-03-21 Thread Viresh Kumar
On 22 March 2013 05:14, Rafael J. Wysocki wrote: > On Wednesday, March 20, 2013 10:59:13 AM Viresh Kumar wrote: >> I have queued all patches i had for 3.10 here: >> >> http://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=shortlog;h=refs/heads/for-3.10 > > OK, applied these to linux-pm.git/bl

Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors

2013-03-21 Thread Rafael J. Wysocki
On Wednesday, March 20, 2013 10:59:13 AM Viresh Kumar wrote: > On 4 March 2013 13:07, Viresh Kumar wrote: > > Currently, there can't be multiple instances of single governor_type. If we > > have > > a multi-package system, where we have multiple instances of struct policy > > (per > > package),

Re: [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors

2013-03-19 Thread Viresh Kumar
On 4 March 2013 13:07, Viresh Kumar wrote: > Currently, there can't be multiple instances of single governor_type. If we > have > a multi-package system, where we have multiple instances of struct policy (per > package), we can't have multiple instances of same governor. i.e. We can't > have > m

[PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors

2013-03-03 Thread Viresh Kumar
Currently, there can't be multiple instances of single governor_type. If we have a multi-package system, where we have multiple instances of struct policy (per package), we can't have multiple instances of same governor. i.e. We can't have multiple instances of ondemand governor for multiple packag