Re: [PATCH V3 2/5] spi: s3c64xx: added support for polling mode

2013-04-03 Thread Girish KS
On Wed, Apr 3, 2013 at 5:19 PM, Mark Brown wrote: > On Wed, Apr 03, 2013 at 05:00:04PM +0530, Girish KS wrote: >> On Mon, Apr 1, 2013 at 6:42 PM, Mark Brown > >> >> - if (!sdd->pdev->dev.of_node) { >> >> + if (!sdd->pdev->dev.of_node && !is_polling(sdd)) { >> >> res = platfor

Re: [PATCH V3 2/5] spi: s3c64xx: added support for polling mode

2013-04-03 Thread Mark Brown
On Wed, Apr 03, 2013 at 05:00:04PM +0530, Girish KS wrote: > On Mon, Apr 1, 2013 at 6:42 PM, Mark Brown > >> - if (!sdd->pdev->dev.of_node) { > >> + if (!sdd->pdev->dev.of_node && !is_polling(sdd)) { > >> res = platform_get_resource(pdev, IORESOURCE_DMA, 0); > >>

Re: [PATCH V3 2/5] spi: s3c64xx: added support for polling mode

2013-04-03 Thread Girish KS
On Mon, Apr 1, 2013 at 6:42 PM, Mark Brown wrote: > On Wed, Mar 13, 2013 at 12:13:31PM +0530, Girish K S wrote: > >> Some SoC's that adopt this controller might not have have dma >> interface. This patch adds support for complete polling mode >> and gives flexibity for the user to select poll/dma

Re: [PATCH V3 2/5] spi: s3c64xx: added support for polling mode

2013-04-01 Thread Mark Brown
On Wed, Mar 13, 2013 at 12:13:31PM +0530, Girish K S wrote: > Some SoC's that adopt this controller might not have have dma > interface. This patch adds support for complete polling mode > and gives flexibity for the user to select poll/dma mode. Ouch, that sounds like a regression. > @@ -419,6

[PATCH V3 2/5] spi: s3c64xx: added support for polling mode

2013-03-12 Thread Girish K S
From: Girish K S The 64xx spi driver supports partial polling mode. Only the last chunk of the transfer length is transferred or recieved in polling mode. Some SoC's that adopt this controller might not have have dma interface. This patch adds support for complete polling mode and gives flexibit