Re: [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for tx_status

2016-08-30 Thread Vinod Koul
On Tue, Aug 30, 2016 at 01:51:02PM -0400, Sinan Kaya wrote: > On 8/30/2016 1:37 PM, Sinan Kaya wrote: > > On 8/30/2016 1:04 PM, Vinod Koul wrote: > >> On Tue, Aug 23, 2016 at 12:48:11AM -0400, Sinan Kaya wrote: > >> > >>> spin_lock_init(&lldev->lock); > >>> - tasklet_init(&lldev->rst_task, hidma_

Re: [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for tx_status

2016-08-30 Thread Sinan Kaya
On 8/30/2016 1:37 PM, Sinan Kaya wrote: > On 8/30/2016 1:04 PM, Vinod Koul wrote: >> On Tue, Aug 23, 2016 at 12:48:11AM -0400, Sinan Kaya wrote: >> >>> spin_lock_init(&lldev->lock); >>> - tasklet_init(&lldev->rst_task, hidma_ll_abort, (unsigned long)lldev); >> >> ?? >> >> This is not describe

Re: [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for tx_status

2016-08-30 Thread Sinan Kaya
On 8/30/2016 1:04 PM, Vinod Koul wrote: > On Tue, Aug 23, 2016 at 12:48:11AM -0400, Sinan Kaya wrote: > >> spin_lock_init(&lldev->lock); >> -tasklet_init(&lldev->rst_task, hidma_ll_abort, (unsigned long)lldev); > > ?? > > This is not described in changlog? If you are not using in anywhe

Re: [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for tx_status

2016-08-30 Thread Vinod Koul
On Tue, Aug 23, 2016 at 12:48:11AM -0400, Sinan Kaya wrote: > spin_lock_init(&lldev->lock); > - tasklet_init(&lldev->rst_task, hidma_ll_abort, (unsigned long)lldev); ?? This is not described in changlog? If you are not using in anywhere else, then rst_task variable should be removed to

[PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for tx_status

2016-08-22 Thread Sinan Kaya
The HIDMA driver is capable of error detection. However, the error was not being passed back to the client when tx_status API is called. Changing the error handling behavior to follow this oder. 1. dmaengine asserts error interrupt 2. Driver receives and mark's the txn as error 3. Driver complete