Re: [PATCH V3 6/8] mm: and drivers core: Convert hugetlb_report_node_meminfo to sysfs_emit

2020-09-28 Thread Greg Kroah-Hartman
On Mon, Sep 28, 2020 at 05:53:07PM -0700, Joe Perches wrote: > On Sat, 2020-09-19 at 08:22 +0200, Greg Kroah-Hartman wrote: > > On Wed, Sep 16, 2020 at 01:40:43PM -0700, Joe Perches wrote: > > > Convert the unbound sprintf in hugetlb_report_node_meminfo to use > > > sysfs_emit_at so that no

Re: [PATCH V3 6/8] mm: and drivers core: Convert hugetlb_report_node_meminfo to sysfs_emit

2020-09-28 Thread Joe Perches
On Sat, 2020-09-19 at 08:22 +0200, Greg Kroah-Hartman wrote: > On Wed, Sep 16, 2020 at 01:40:43PM -0700, Joe Perches wrote: > > Convert the unbound sprintf in hugetlb_report_node_meminfo to use > > sysfs_emit_at so that no possible overrun of a PAGE_SIZE buf can occur. [] > I'll take a look at it

Re: [PATCH V3 6/8] mm: and drivers core: Convert hugetlb_report_node_meminfo to sysfs_emit

2020-09-25 Thread Joe Perches
On Sat, 2020-09-19 at 08:22 +0200, Greg Kroah-Hartman wrote: > I'll take a look at it on Monday... Thoughts?

Re: [PATCH V3 6/8] mm: and drivers core: Convert hugetlb_report_node_meminfo to sysfs_emit

2020-09-19 Thread Joe Perches
On Sat, 2020-09-19 at 08:22 +0200, Greg Kroah-Hartman wrote: > I'll take a look at it on Monday... It's decidedly not urgent/critical. There are several logical defects all over the kernel for these unbounded sprintfs, but I don't know of an actual instance where the PAGE_SIZE buf is overfilled.

Re: [PATCH V3 6/8] mm: and drivers core: Convert hugetlb_report_node_meminfo to sysfs_emit

2020-09-19 Thread Greg Kroah-Hartman
On Wed, Sep 16, 2020 at 01:40:43PM -0700, Joe Perches wrote: > Convert the unbound sprintf in hugetlb_report_node_meminfo to use > sysfs_emit_at so that no possible overrun of a PAGE_SIZE buf can occur. > > Signed-off-by: Joe Perches > --- > drivers/base/node.c | 2 +- >

Re: [PATCH V3 6/8] mm: and drivers core: Convert hugetlb_report_node_meminfo to sysfs_emit

2020-09-18 Thread Mike Kravetz
On 9/16/20 1:40 PM, Joe Perches wrote: > Convert the unbound sprintf in hugetlb_report_node_meminfo to use > sysfs_emit_at so that no possible overrun of a PAGE_SIZE buf can occur. > > Signed-off-by: Joe Perches Acked-by: Mike Kravetz -- Mike Kravetz

[PATCH V3 6/8] mm: and drivers core: Convert hugetlb_report_node_meminfo to sysfs_emit

2020-09-16 Thread Joe Perches
Convert the unbound sprintf in hugetlb_report_node_meminfo to use sysfs_emit_at so that no possible overrun of a PAGE_SIZE buf can occur. Signed-off-by: Joe Perches --- drivers/base/node.c | 2 +- include/linux/hugetlb.h | 4 ++-- mm/hugetlb.c| 18 ++ 3 files