Re: [PATCH V3 6/9] mtd: add a new field for ecc info in the nand_flash_dev{}

2013-04-26 Thread Huang Shijie
于 2013年04月26日 14:15, Brian Norris 写道: > How does that look? It's actually quite similar to the construct Artem > used with mfr_id and dev_id, except that we give the struct a name. > And this time, it actually compiles! > It's ok to me. :) I will use it in the next version. thanks Huang Shijie

Re: [PATCH V3 6/9] mtd: add a new field for ecc info in the nand_flash_dev{}

2013-04-26 Thread Brian Norris
On Thu, Apr 25, 2013 at 1:56 AM, Huang Shijie wrote: > 于 2013年04月25日 14:57, Brian Norris 写道: > >> >> A bit late on this one, but is there a good reason this wasn't just 2 >> separate 16-bit fields? We already have a few, and I don't see why >> this couldn't be the same. >> > I just want to make

Re: [PATCH V3 6/9] mtd: add a new field for ecc info in the nand_flash_dev{}

2013-04-26 Thread Brian Norris
On Thu, Apr 25, 2013 at 1:56 AM, Huang Shijie b32...@freescale.com wrote: 于 2013年04月25日 14:57, Brian Norris 写道: A bit late on this one, but is there a good reason this wasn't just 2 separate 16-bit fields? We already have a few, and I don't see why this couldn't be the same. I just want to

Re: [PATCH V3 6/9] mtd: add a new field for ecc info in the nand_flash_dev{}

2013-04-26 Thread Huang Shijie
于 2013年04月26日 14:15, Brian Norris 写道: How does that look? It's actually quite similar to the construct Artem used with mfr_id and dev_id, except that we give the struct a name. And this time, it actually compiles! It's ok to me. :) I will use it in the next version. thanks Huang Shijie --

Re: [PATCH V3 6/9] mtd: add a new field for ecc info in the nand_flash_dev{}

2013-04-25 Thread Huang Shijie
于 2013年04月25日 14:57, Brian Norris 写道: A bit late on this one, but is there a good reason this wasn't just 2 separate 16-bit fields? We already have a few, and I don't see why this couldn't be the same. I just want to make the ecc_strength/ecc_size more coupled for the nand_flash_dev{}. If we

Re: [PATCH V3 6/9] mtd: add a new field for ecc info in the nand_flash_dev{}

2013-04-25 Thread Brian Norris
Last nitpicks for v3 :) On Tue, Apr 23, 2013 at 1:54 AM, Huang Shijie wrote: > Add the @ecc_info in the nand_flash_dev{}. > The lower 16 bits are used to store the ECC bits, while the upper 16 bits > are used to store the ECC data chunk size. A bit late on this one, but is there a good reason

Re: [PATCH V3 6/9] mtd: add a new field for ecc info in the nand_flash_dev{}

2013-04-25 Thread Brian Norris
Last nitpicks for v3 :) On Tue, Apr 23, 2013 at 1:54 AM, Huang Shijie b32...@freescale.com wrote: Add the @ecc_info in the nand_flash_dev{}. The lower 16 bits are used to store the ECC bits, while the upper 16 bits are used to store the ECC data chunk size. A bit late on this one, but is

Re: [PATCH V3 6/9] mtd: add a new field for ecc info in the nand_flash_dev{}

2013-04-25 Thread Huang Shijie
于 2013年04月25日 14:57, Brian Norris 写道: A bit late on this one, but is there a good reason this wasn't just 2 separate 16-bit fields? We already have a few, and I don't see why this couldn't be the same. I just want to make the ecc_strength/ecc_size more coupled for the nand_flash_dev{}. If we

[PATCH V3 6/9] mtd: add a new field for ecc info in the nand_flash_dev{}

2013-04-23 Thread Huang Shijie
Add the @ecc_info in the nand_flash_dev{}. The lower 16 bits are used to store the ECC bits, while the upper 16 bits are used to store the ECC data chunk size. Signed-off-by: Huang Shijie --- include/linux/mtd/nand.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff

[PATCH V3 6/9] mtd: add a new field for ecc info in the nand_flash_dev{}

2013-04-23 Thread Huang Shijie
Add the @ecc_info in the nand_flash_dev{}. The lower 16 bits are used to store the ECC bits, while the upper 16 bits are used to store the ECC data chunk size. Signed-off-by: Huang Shijie b32...@freescale.com --- include/linux/mtd/nand.h | 10 ++ 1 files changed, 10 insertions(+), 0