Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-28 Thread Paul Moore
On Wed, Apr 27, 2016 at 9:31 PM, Richard Guy Briggs wrote: > On 16/04/22, Peter Hurley wrote: >> 2. The existing usage is always tsk==current > > My understanding is that when it is called via: > > copy_process() > audit_free() >

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-28 Thread Paul Moore
On Wed, Apr 27, 2016 at 9:31 PM, Richard Guy Briggs wrote: > On 16/04/22, Peter Hurley wrote: >> 2. The existing usage is always tsk==current > > My understanding is that when it is called via: > > copy_process() > audit_free() > __audit_free() >

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-28 Thread Peter Hurley
On 04/28/2016 12:28 PM, Richard Guy Briggs wrote: > On 16/04/27, Peter Hurley wrote: >> On 04/27/2016 06:31 PM, Richard Guy Briggs wrote: >>> On 16/04/22, Peter Hurley wrote: On 04/21/2016 11:14 AM, Richard Guy Briggs wrote: > The tty field was missing from AUDIT_LOGIN events. > >

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-28 Thread Peter Hurley
On 04/28/2016 12:28 PM, Richard Guy Briggs wrote: > On 16/04/27, Peter Hurley wrote: >> On 04/27/2016 06:31 PM, Richard Guy Briggs wrote: >>> On 16/04/22, Peter Hurley wrote: On 04/21/2016 11:14 AM, Richard Guy Briggs wrote: > The tty field was missing from AUDIT_LOGIN events. > >

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-28 Thread Richard Guy Briggs
On 16/04/27, Peter Hurley wrote: > On 04/27/2016 06:31 PM, Richard Guy Briggs wrote: > > On 16/04/22, Peter Hurley wrote: > >> On 04/21/2016 11:14 AM, Richard Guy Briggs wrote: > >>> The tty field was missing from AUDIT_LOGIN events. > >>> > >>> Refactor code to create a new function

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-28 Thread Richard Guy Briggs
On 16/04/27, Peter Hurley wrote: > On 04/27/2016 06:31 PM, Richard Guy Briggs wrote: > > On 16/04/22, Peter Hurley wrote: > >> On 04/21/2016 11:14 AM, Richard Guy Briggs wrote: > >>> The tty field was missing from AUDIT_LOGIN events. > >>> > >>> Refactor code to create a new function

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-27 Thread Peter Hurley
On 04/27/2016 06:31 PM, Richard Guy Briggs wrote: > On 16/04/22, Peter Hurley wrote: >> On 04/21/2016 11:14 AM, Richard Guy Briggs wrote: >>> The tty field was missing from AUDIT_LOGIN events. >>> >>> Refactor code to create a new function audit_get_tty(), using it to >>> replace the call in

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-27 Thread Peter Hurley
On 04/27/2016 06:31 PM, Richard Guy Briggs wrote: > On 16/04/22, Peter Hurley wrote: >> On 04/21/2016 11:14 AM, Richard Guy Briggs wrote: >>> The tty field was missing from AUDIT_LOGIN events. >>> >>> Refactor code to create a new function audit_get_tty(), using it to >>> replace the call in

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-27 Thread Richard Guy Briggs
On 16/04/22, Peter Hurley wrote: > On 04/21/2016 11:14 AM, Richard Guy Briggs wrote: > > The tty field was missing from AUDIT_LOGIN events. > > > > Refactor code to create a new function audit_get_tty(), using it to > > replace the call in audit_log_task_info() and to add it to > >

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-27 Thread Richard Guy Briggs
On 16/04/22, Peter Hurley wrote: > On 04/21/2016 11:14 AM, Richard Guy Briggs wrote: > > The tty field was missing from AUDIT_LOGIN events. > > > > Refactor code to create a new function audit_get_tty(), using it to > > replace the call in audit_log_task_info() and to add it to > >

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-26 Thread Peter Hurley
On 04/26/2016 03:34 PM, Paul Moore wrote: > On Fri, Apr 22, 2016 at 1:16 PM, Peter Hurley > wrote: >> On 04/21/2016 11:14 AM, Richard Guy Briggs wrote: >>> diff --git a/include/linux/audit.h b/include/linux/audit.h >>> index b40ed5d..32cdafb 100644 >>> ---

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-26 Thread Peter Hurley
On 04/26/2016 03:34 PM, Paul Moore wrote: > On Fri, Apr 22, 2016 at 1:16 PM, Peter Hurley > wrote: >> On 04/21/2016 11:14 AM, Richard Guy Briggs wrote: >>> diff --git a/include/linux/audit.h b/include/linux/audit.h >>> index b40ed5d..32cdafb 100644 >>> --- a/include/linux/audit.h >>> +++

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-26 Thread Paul Moore
On Fri, Apr 22, 2016 at 1:16 PM, Peter Hurley wrote: > On 04/21/2016 11:14 AM, Richard Guy Briggs wrote: >> diff --git a/include/linux/audit.h b/include/linux/audit.h >> index b40ed5d..32cdafb 100644 >> --- a/include/linux/audit.h >> +++ b/include/linux/audit.h >> @@

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-26 Thread Paul Moore
On Fri, Apr 22, 2016 at 1:16 PM, Peter Hurley wrote: > On 04/21/2016 11:14 AM, Richard Guy Briggs wrote: >> diff --git a/include/linux/audit.h b/include/linux/audit.h >> index b40ed5d..32cdafb 100644 >> --- a/include/linux/audit.h >> +++ b/include/linux/audit.h >> @@ -26,6 +26,7 @@ >> #include

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-22 Thread Peter Hurley
On 04/21/2016 11:14 AM, Richard Guy Briggs wrote: > The tty field was missing from AUDIT_LOGIN events. > > Refactor code to create a new function audit_get_tty(), using it to > replace the call in audit_log_task_info() and to add it to > audit_log_set_loginuid(). Lock and bump the kref to

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-22 Thread Peter Hurley
On 04/21/2016 11:14 AM, Richard Guy Briggs wrote: > The tty field was missing from AUDIT_LOGIN events. > > Refactor code to create a new function audit_get_tty(), using it to > replace the call in audit_log_task_info() and to add it to > audit_log_set_loginuid(). Lock and bump the kref to

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-22 Thread Paul Moore
On Thu, Apr 21, 2016 at 11:50 PM, Richard Guy Briggs wrote: > On 16/04/21, Paul Moore wrote: >> On Thu, Apr 21, 2016 at 2:14 PM, Richard Guy Briggs wrote: >> > The tty field was missing from AUDIT_LOGIN events. >> > >> > Refactor code to create a new function

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-22 Thread Paul Moore
On Thu, Apr 21, 2016 at 11:50 PM, Richard Guy Briggs wrote: > On 16/04/21, Paul Moore wrote: >> On Thu, Apr 21, 2016 at 2:14 PM, Richard Guy Briggs wrote: >> > The tty field was missing from AUDIT_LOGIN events. >> > >> > Refactor code to create a new function audit_get_tty(), using it to >> >

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-22 Thread Steve Grubb
On Thursday, April 21, 2016 09:29:57 PM Paul Moore wrote: > On Thu, Apr 21, 2016 at 2:14 PM, Richard Guy Briggs wrote: > > The tty field was missing from AUDIT_LOGIN events. > > > > Refactor code to create a new function audit_get_tty(), using it to > > replace the call in

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-22 Thread Steve Grubb
On Thursday, April 21, 2016 09:29:57 PM Paul Moore wrote: > On Thu, Apr 21, 2016 at 2:14 PM, Richard Guy Briggs wrote: > > The tty field was missing from AUDIT_LOGIN events. > > > > Refactor code to create a new function audit_get_tty(), using it to > > replace the call in audit_log_task_info()

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-21 Thread Richard Guy Briggs
On 16/04/21, Paul Moore wrote: > On Thu, Apr 21, 2016 at 2:14 PM, Richard Guy Briggs wrote: > > The tty field was missing from AUDIT_LOGIN events. > > > > Refactor code to create a new function audit_get_tty(), using it to > > replace the call in audit_log_task_info() and to add

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-21 Thread Richard Guy Briggs
On 16/04/21, Paul Moore wrote: > On Thu, Apr 21, 2016 at 2:14 PM, Richard Guy Briggs wrote: > > The tty field was missing from AUDIT_LOGIN events. > > > > Refactor code to create a new function audit_get_tty(), using it to > > replace the call in audit_log_task_info() and to add it to > >

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-21 Thread Paul Moore
On Thu, Apr 21, 2016 at 2:14 PM, Richard Guy Briggs wrote: > The tty field was missing from AUDIT_LOGIN events. > > Refactor code to create a new function audit_get_tty(), using it to > replace the call in audit_log_task_info() and to add it to > audit_log_set_loginuid(). Lock

Re: [PATCH V4] audit: add tty field to LOGIN event

2016-04-21 Thread Paul Moore
On Thu, Apr 21, 2016 at 2:14 PM, Richard Guy Briggs wrote: > The tty field was missing from AUDIT_LOGIN events. > > Refactor code to create a new function audit_get_tty(), using it to > replace the call in audit_log_task_info() and to add it to > audit_log_set_loginuid(). Lock and bump the kref

[PATCH V4] audit: add tty field to LOGIN event

2016-04-21 Thread Richard Guy Briggs
The tty field was missing from AUDIT_LOGIN events. Refactor code to create a new function audit_get_tty(), using it to replace the call in audit_log_task_info() and to add it to audit_log_set_loginuid(). Lock and bump the kref to protect it, adding audit_put_tty() alias to decrement it.

[PATCH V4] audit: add tty field to LOGIN event

2016-04-21 Thread Richard Guy Briggs
The tty field was missing from AUDIT_LOGIN events. Refactor code to create a new function audit_get_tty(), using it to replace the call in audit_log_task_info() and to add it to audit_log_set_loginuid(). Lock and bump the kref to protect it, adding audit_put_tty() alias to decrement it.