Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-27 Thread Madhavan Srinivasan
On Tuesday 27 May 2014 03:51 PM, Kirill A. Shutemov wrote: > Madhavan Srinivasan wrote: >> On Tuesday 20 May 2014 03:57 PM, Kirill A. Shutemov wrote: >>> Rusty Russell wrote: "Kirill A. Shutemov" writes: > Andrew Morton wrote: >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-27 Thread Kirill A. Shutemov
Madhavan Srinivasan wrote: > On Tuesday 20 May 2014 03:57 PM, Kirill A. Shutemov wrote: > > Rusty Russell wrote: > >> "Kirill A. Shutemov" writes: > >>> Andrew Morton wrote: > On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins > wrote: > > > Shouldn't FAULT_AROUND_ORDER

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-27 Thread Madhavan Srinivasan
On Tuesday 20 May 2014 03:57 PM, Kirill A. Shutemov wrote: > Rusty Russell wrote: >> "Kirill A. Shutemov" writes: >>> Andrew Morton wrote: On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins wrote: > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be >

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-27 Thread Madhavan Srinivasan
On Tuesday 20 May 2014 03:57 PM, Kirill A. Shutemov wrote: Rusty Russell wrote: Kirill A. Shutemov kirill.shute...@linux.intel.com writes: Andrew Morton wrote: On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins hu...@google.com wrote: Shouldn't FAULT_AROUND_ORDER and fault_around_order

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-27 Thread Kirill A. Shutemov
Madhavan Srinivasan wrote: On Tuesday 20 May 2014 03:57 PM, Kirill A. Shutemov wrote: Rusty Russell wrote: Kirill A. Shutemov kirill.shute...@linux.intel.com writes: Andrew Morton wrote: On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins hu...@google.com wrote: Shouldn't

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-27 Thread Madhavan Srinivasan
On Tuesday 27 May 2014 03:51 PM, Kirill A. Shutemov wrote: Madhavan Srinivasan wrote: On Tuesday 20 May 2014 03:57 PM, Kirill A. Shutemov wrote: Rusty Russell wrote: Kirill A. Shutemov kirill.shute...@linux.intel.com writes: Andrew Morton wrote: On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-23 Thread Kirill A. Shutemov
Andrew Morton wrote: > On Wed, 21 May 2014 16:40:27 +0300 (EEST) "Kirill A. Shutemov" > wrote: > > > > Or something. Can we please get some code commentary over > > > do_fault_around() describing this design decision and explaining the > > > reasoning behind it? > > > > I'll do this. But if

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-23 Thread Kirill A. Shutemov
Andrew Morton wrote: On Wed, 21 May 2014 16:40:27 +0300 (EEST) Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Or something. Can we please get some code commentary over do_fault_around() describing this design decision and explaining the reasoning behind it? I'll do

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-21 Thread Andrew Morton
On Wed, 21 May 2014 16:40:27 +0300 (EEST) "Kirill A. Shutemov" wrote: > > Or something. Can we please get some code commentary over > > do_fault_around() describing this design decision and explaining the > > reasoning behind it? > > I'll do this. But if do_fault_around() rework is needed, I

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-21 Thread Kirill A. Shutemov
Andrew Morton wrote: > On Tue, 20 May 2014 13:27:38 +0300 (EEST) "Kirill A. Shutemov" > wrote: > > > Rusty Russell wrote: > > > "Kirill A. Shutemov" writes: > > > > Andrew Morton wrote: > > > >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins > > > >> wrote: > > > >> > > > >> >

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-21 Thread Kirill A. Shutemov
Andrew Morton wrote: On Tue, 20 May 2014 13:27:38 +0300 (EEST) Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Rusty Russell wrote: Kirill A. Shutemov kirill.shute...@linux.intel.com writes: Andrew Morton wrote: On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-21 Thread Andrew Morton
On Wed, 21 May 2014 16:40:27 +0300 (EEST) Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Or something. Can we please get some code commentary over do_fault_around() describing this design decision and explaining the reasoning behind it? I'll do this. But if do_fault_around()

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-20 Thread Andrew Morton
On Tue, 20 May 2014 13:27:38 +0300 (EEST) "Kirill A. Shutemov" wrote: > Rusty Russell wrote: > > "Kirill A. Shutemov" writes: > > > Andrew Morton wrote: > > >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins > > >> wrote: > > >> > > >> > Shouldn't FAULT_AROUND_ORDER and

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-20 Thread Kirill A. Shutemov
Rusty Russell wrote: > "Kirill A. Shutemov" writes: > > Andrew Morton wrote: > >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins > >> wrote: > >> > >> > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be > >> > the order of the fault-around size in bytes, and

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-20 Thread Madhavan Srinivasan
On Tuesday 20 May 2014 01:02 PM, Andrew Morton wrote: > On Tue, 20 May 2014 15:52:07 +0930 Rusty Russell > wrote: > >> "Kirill A. Shutemov" writes: >>> Andrew Morton wrote: On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins wrote: > Shouldn't FAULT_AROUND_ORDER and

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-20 Thread Andrew Morton
On Tue, 20 May 2014 15:52:07 +0930 Rusty Russell wrote: > "Kirill A. Shutemov" writes: > > Andrew Morton wrote: > >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins > >> wrote: > >> > >> > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be > >> > the order of the

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-20 Thread Rusty Russell
"Kirill A. Shutemov" writes: > Andrew Morton wrote: >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins >> wrote: >> >> > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be >> > the order of the fault-around size in bytes, and fault_around_pages() >> > use 1UL <<

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-20 Thread Rusty Russell
Kirill A. Shutemov kirill.shute...@linux.intel.com writes: Andrew Morton wrote: On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins hu...@google.com wrote: Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be the order of the fault-around size in bytes, and

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-20 Thread Andrew Morton
On Tue, 20 May 2014 15:52:07 +0930 Rusty Russell ru...@rustcorp.com.au wrote: Kirill A. Shutemov kirill.shute...@linux.intel.com writes: Andrew Morton wrote: On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins hu...@google.com wrote: Shouldn't FAULT_AROUND_ORDER and

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-20 Thread Madhavan Srinivasan
On Tuesday 20 May 2014 01:02 PM, Andrew Morton wrote: On Tue, 20 May 2014 15:52:07 +0930 Rusty Russell ru...@rustcorp.com.au wrote: Kirill A. Shutemov kirill.shute...@linux.intel.com writes: Andrew Morton wrote: On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins hu...@google.com

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-20 Thread Kirill A. Shutemov
Rusty Russell wrote: Kirill A. Shutemov kirill.shute...@linux.intel.com writes: Andrew Morton wrote: On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins hu...@google.com wrote: Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be the order of the fault-around

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-20 Thread Andrew Morton
On Tue, 20 May 2014 13:27:38 +0300 (EEST) Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Rusty Russell wrote: Kirill A. Shutemov kirill.shute...@linux.intel.com writes: Andrew Morton wrote: On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins hu...@google.com wrote:

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-19 Thread Hugh Dickins
On Tue, 20 May 2014, Rusty Russell wrote: > Hugh Dickins writes: > >> On Monday 19 May 2014 05:42 AM, Rusty Russell wrote: > >> > > >> > Perhaps we try to generalize from two data points (a slight improvement > >> > over doing it from 1!), eg: > >> > > >> > /* 4 seems good for 4k-page x86, 0

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-19 Thread Rusty Russell
Hugh Dickins writes: > On Mon, 19 May 2014, Madhavan Srinivasan wrote: >> On Monday 19 May 2014 05:42 AM, Rusty Russell wrote: >> > Hugh Dickins writes: >> >> On Thu, 15 May 2014, Madhavan Srinivasan wrote: >> >>> >> >>> Hi Ingo, >> >>> >> >>> Do you have any comments for the latest version of

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-19 Thread Madhavan Srinivasan
On Tuesday 20 May 2014 04:53 AM, Hugh Dickins wrote: > On Mon, 19 May 2014, Madhavan Srinivasan wrote: >> On Monday 19 May 2014 05:42 AM, Rusty Russell wrote: >>> Hugh Dickins writes: On Thu, 15 May 2014, Madhavan Srinivasan wrote: > > Hi Ingo, > > Do you have any comments

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-19 Thread Kirill A. Shutemov
Andrew Morton wrote: > On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins > wrote: > > > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be > > the order of the fault-around size in bytes, and fault_around_pages() > > use 1UL << (fault_around_order - PAGE_SHIFT) > > Yes.

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-19 Thread Andrew Morton
On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins wrote: > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be > the order of the fault-around size in bytes, and fault_around_pages() > use 1UL << (fault_around_order - PAGE_SHIFT) Yes. And shame on me for missing it (this

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-19 Thread Hugh Dickins
On Mon, 19 May 2014, Madhavan Srinivasan wrote: > On Monday 19 May 2014 05:42 AM, Rusty Russell wrote: > > Hugh Dickins writes: > >> On Thu, 15 May 2014, Madhavan Srinivasan wrote: > >>> > >>> Hi Ingo, > >>> > >>> Do you have any comments for the latest version of the patchset. If > >>> not,

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-19 Thread Hugh Dickins
On Mon, 19 May 2014, Madhavan Srinivasan wrote: On Monday 19 May 2014 05:42 AM, Rusty Russell wrote: Hugh Dickins hu...@google.com writes: On Thu, 15 May 2014, Madhavan Srinivasan wrote: Hi Ingo, Do you have any comments for the latest version of the patchset. If not, kindly can

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-19 Thread Andrew Morton
On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins hu...@google.com wrote: Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be the order of the fault-around size in bytes, and fault_around_pages() use 1UL (fault_around_order - PAGE_SHIFT) Yes. And shame on me for missing

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-19 Thread Kirill A. Shutemov
Andrew Morton wrote: On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins hu...@google.com wrote: Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be the order of the fault-around size in bytes, and fault_around_pages() use 1UL (fault_around_order - PAGE_SHIFT)

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-19 Thread Madhavan Srinivasan
On Tuesday 20 May 2014 04:53 AM, Hugh Dickins wrote: On Mon, 19 May 2014, Madhavan Srinivasan wrote: On Monday 19 May 2014 05:42 AM, Rusty Russell wrote: Hugh Dickins hu...@google.com writes: On Thu, 15 May 2014, Madhavan Srinivasan wrote: Hi Ingo, Do you have any comments for the latest

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-19 Thread Rusty Russell
Hugh Dickins hu...@google.com writes: On Mon, 19 May 2014, Madhavan Srinivasan wrote: On Monday 19 May 2014 05:42 AM, Rusty Russell wrote: Hugh Dickins hu...@google.com writes: On Thu, 15 May 2014, Madhavan Srinivasan wrote: Hi Ingo, Do you have any comments for the latest version

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-19 Thread Hugh Dickins
On Tue, 20 May 2014, Rusty Russell wrote: Hugh Dickins hu...@google.com writes: On Monday 19 May 2014 05:42 AM, Rusty Russell wrote: Perhaps we try to generalize from two data points (a slight improvement over doing it from 1!), eg: /* 4 seems good for 4k-page x86, 0 seems good

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-18 Thread Madhavan Srinivasan
On Monday 19 May 2014 05:42 AM, Rusty Russell wrote: > Hugh Dickins writes: >> On Thu, 15 May 2014, Madhavan Srinivasan wrote: >>> >>> Hi Ingo, >>> >>> Do you have any comments for the latest version of the patchset. If >>> not, kindly can you pick it up as is. >>> >>> >>> With regards >>>

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-18 Thread Rusty Russell
Hugh Dickins writes: > On Thu, 15 May 2014, Madhavan Srinivasan wrote: >> >> Hi Ingo, >> >> Do you have any comments for the latest version of the patchset. If >> not, kindly can you pick it up as is. >> >> >> With regards >> Maddy >> >> > Kirill A. Shutemov with 8c6e50b029 commit

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-18 Thread Rusty Russell
Hugh Dickins hu...@google.com writes: On Thu, 15 May 2014, Madhavan Srinivasan wrote: Hi Ingo, Do you have any comments for the latest version of the patchset. If not, kindly can you pick it up as is. With regards Maddy Kirill A. Shutemov with 8c6e50b029 commit introduced

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-18 Thread Madhavan Srinivasan
On Monday 19 May 2014 05:42 AM, Rusty Russell wrote: Hugh Dickins hu...@google.com writes: On Thu, 15 May 2014, Madhavan Srinivasan wrote: Hi Ingo, Do you have any comments for the latest version of the patchset. If not, kindly can you pick it up as is. With regards Maddy Kirill

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-15 Thread Hugh Dickins
On Thu, 15 May 2014, Madhavan Srinivasan wrote: > > Hi Ingo, > > Do you have any comments for the latest version of the patchset. If > not, kindly can you pick it up as is. > > > With regards > Maddy > > > Kirill A. Shutemov with 8c6e50b029 commit introduced > > vm_ops->map_pages() for

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-15 Thread Madhavan Srinivasan
Hi Ingo, Do you have any comments for the latest version of the patchset. If not, kindly can you pick it up as is. With regards Maddy > Kirill A. Shutemov with 8c6e50b029 commit introduced > vm_ops->map_pages() for mapping easy accessible pages around > fault address in hope to reduce

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-15 Thread Madhavan Srinivasan
Hi Ingo, Do you have any comments for the latest version of the patchset. If not, kindly can you pick it up as is. With regards Maddy Kirill A. Shutemov with 8c6e50b029 commit introduced vm_ops-map_pages() for mapping easy accessible pages around fault address in hope to reduce

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-15 Thread Hugh Dickins
On Thu, 15 May 2014, Madhavan Srinivasan wrote: Hi Ingo, Do you have any comments for the latest version of the patchset. If not, kindly can you pick it up as is. With regards Maddy Kirill A. Shutemov with 8c6e50b029 commit introduced vm_ops-map_pages() for mapping easy

[PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-08 Thread Madhavan Srinivasan
Kirill A. Shutemov with 8c6e50b029 commit introduced vm_ops->map_pages() for mapping easy accessible pages around fault address in hope to reduce number of minor page faults. This patch creates infrastructure to modify the FAULT_AROUND_ORDER value using mm/Kconfig. This will enable architecture

[PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-08 Thread Madhavan Srinivasan
Kirill A. Shutemov with 8c6e50b029 commit introduced vm_ops-map_pages() for mapping easy accessible pages around fault address in hope to reduce number of minor page faults. This patch creates infrastructure to modify the FAULT_AROUND_ORDER value using mm/Kconfig. This will enable architecture