Re: [PATCH V4 1/2] nvme: add NVME_CTRL_RESET_PREPARE state

2018-01-17 Thread jianchao.wang
Hi James Thanks for you detailed, kindly response and directive. That's really appreciated. On 01/18/2018 02:24 PM, James Smart wrote: >> So in the patch, RESETTING in nvme-fc/rdma is changed to RESET_PREPARE. Then >> we get: >> nvme-fc/rdma RESET_PREPARE -> RECONNECTING -> LIVE >> nvme-pci

Re: [PATCH V4 1/2] nvme: add NVME_CTRL_RESET_PREPARE state

2018-01-17 Thread James Smart
Thanks jianchoa. This helped. On 1/17/2018 7:13 PM, jianchao.wang wrote: Actually, this patchset is to fix a issue in nvme_timeout. Please consider the following scenario. nvme_reset_ctrl -> set state to RESETTING -> queue reset_work (scheduling) nvm

Re: [PATCH V4 1/2] nvme: add NVME_CTRL_RESET_PREPARE state

2018-01-17 Thread jianchao.wang
Hi James Thanks for your kindly and detailed response. That's really appreciated! And sorry for my bad description. On 01/18/2018 05:01 AM, James Smart wrote: > I'm having a hard time following why this patch is being requested. Help me > catch on. > Actually, this patchset is to fix a issu

Re: [PATCH V4 1/2] nvme: add NVME_CTRL_RESET_PREPARE state

2018-01-17 Thread James Smart
I'm having a hard time following why this patch is being requested. Help me catch on. On 1/16/2018 8:54 PM, Jianchao Wang wrote: Currently, the ctrl->state will be changed to NVME_CTRL_RESETTING before queue the reset work. This is not so strict. There could be a big gap before the reset_wo

Re: [PATCH V4 1/2] nvme: add NVME_CTRL_RESET_PREPARE state

2018-01-17 Thread jianchao.wang
Hi max On 01/17/2018 05:19 PM, jianchao.wang wrote: > Hi Max > > Thanks for your kindly response. > > I have merged the response to you together below. > On 01/17/2018 05:06 PM, Max Gurtovoy wrote: >>>   case NVME_CTRL_RECONNECTING: >>>   switch (old_state) { >>>   case NVME_CTRL

Re: [PATCH V4 1/2] nvme: add NVME_CTRL_RESET_PREPARE state

2018-01-17 Thread jianchao.wang
Hi Max Thanks for your kindly response. I have merged the response to you together below. On 01/17/2018 05:06 PM, Max Gurtovoy wrote: >>   case NVME_CTRL_RECONNECTING: >>   switch (old_state) { >>   case NVME_CTRL_LIVE: >> -    case NVME_CTRL_RESETTING: >> +    case NVME_C

Re: [PATCH V4 1/2] nvme: add NVME_CTRL_RESET_PREPARE state

2018-01-17 Thread Max Gurtovoy
hi Jianchao Wang, On 1/17/2018 6:54 AM, Jianchao Wang wrote: Currently, the ctrl->state will be changed to NVME_CTRL_RESETTING before queue the reset work. This is not so strict. There could be a big gap before the reset_work callback is invoked. In addition, there is some disable work in the re

[PATCH V4 1/2] nvme: add NVME_CTRL_RESET_PREPARE state

2018-01-16 Thread Jianchao Wang
Currently, the ctrl->state will be changed to NVME_CTRL_RESETTING before queue the reset work. This is not so strict. There could be a big gap before the reset_work callback is invoked. In addition, there is some disable work in the reset_work callback, strictly speaking, not part of reset work, an