Re: [PATCH V4 1/5] nvme: do atomically bit operations on nvme_request.flags

Hi Christoph Thanks for your precious time for reviewing this. On 03/08/2018 03:57 PM, Christoph Hellwig wrote: >> -u8 flags; >> u16 status; >> +unsigned long flags; > Please align the field name like the others, though Yes, I will change

Re: [PATCH V4 1/5] nvme: do atomically bit operations on nvme_request.flags

Hi Christoph Thanks for your precious time for reviewing this. On 03/08/2018 03:57 PM, Christoph Hellwig wrote: >> -u8 flags; >> u16 status; >> +unsigned long flags; > Please align the field name like the others, though Yes, I will change

Re: [PATCH V4 1/5] nvme: do atomically bit operations on nvme_request.flags

On Thu, Mar 08, 2018 at 02:19:27PM +0800, Jianchao Wang wrote: > Do atomically bit operations on nvme_request.flags instead of > regular read/write, then we could add other flags and set/clear > them safely. > > Signed-off-by: Jianchao Wang Looks good, assuming an

Re: [PATCH V4 1/5] nvme: do atomically bit operations on nvme_request.flags

On Thu, Mar 08, 2018 at 02:19:27PM +0800, Jianchao Wang wrote: > Do atomically bit operations on nvme_request.flags instead of > regular read/write, then we could add other flags and set/clear > them safely. > > Signed-off-by: Jianchao Wang Looks good, assuming an actual need for this shows up

[PATCH V4 1/5] nvme: do atomically bit operations on nvme_request.flags

Do atomically bit operations on nvme_request.flags instead of regular read/write, then we could add other flags and set/clear them safely. Signed-off-by: Jianchao Wang --- drivers/nvme/host/core.c | 4 ++-- drivers/nvme/host/lightnvm.c | 4 ++--

[PATCH V4 1/5] nvme: do atomically bit operations on nvme_request.flags

Do atomically bit operations on nvme_request.flags instead of regular read/write, then we could add other flags and set/clear them safely. Signed-off-by: Jianchao Wang --- drivers/nvme/host/core.c | 4 ++-- drivers/nvme/host/lightnvm.c | 4 ++-- drivers/nvme/host/nvme.h | 4 ++--