Re: [PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-17 Thread Dongdong Liu
Hi Tomasz 在 2016/11/17 16:28, Tomasz Nowicki 写道: Hi Dongdong, I rewrite your code so that it could be used for ThunderX as well. The rewrited code looks good to me. This assumes _UID&segment is the right way of looking up corelated RC. Of course acpi_get_rc_resources() and its acpi_* helper

Re: [PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-17 Thread Tomasz Nowicki
Hi Dongdong, I rewrite your code so that it could be used for ThunderX as well. This assumes _UID&segment is the right way of looking up corelated RC. Of course acpi_get_rc_resources() and its acpi_* helpers should go to pci-acpi.c. Tomasz static int acpi_get_rc_addr(struct acpi_device *adev,

Re: [PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-16 Thread Dongdong Liu
Hi Bjorn 在 2016/11/17 7:00, Bjorn Helgaas 写道: On Mon, Nov 14, 2016 at 05:33:20PM -0600, Bjorn Helgaas wrote: On Wed, Nov 09, 2016 at 05:14:57PM +0800, Dongdong Liu wrote: PCIe controller in Hip05/HIP06/HIP07 SoCs is not ECAM compliant. It is non ECAM only for the RC bus config space;for any oth

Re: [PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-16 Thread Dongdong Liu
Hi Bjorn 在 2016/11/17 3:31, Bjorn Helgaas 写道: On Wed, Nov 16, 2016 at 07:59:38PM +0800, Dongdong Liu wrote: Hi Bjorn Many Thanks for your review 在 2016/11/15 7:33, Bjorn Helgaas 写道: On Wed, Nov 09, 2016 at 05:14:57PM +0800, Dongdong Liu wrote: PCIe controller in Hip05/HIP06/HIP07 SoCs is no

Re: [PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-16 Thread Bjorn Helgaas
On Mon, Nov 14, 2016 at 05:33:20PM -0600, Bjorn Helgaas wrote: > On Wed, Nov 09, 2016 at 05:14:57PM +0800, Dongdong Liu wrote: > > PCIe controller in Hip05/HIP06/HIP07 SoCs is not ECAM compliant. > > It is non ECAM only for the RC bus config space;for any other bus > > underneath the root bus we su

Re: [PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-16 Thread Bjorn Helgaas
On Wed, Nov 16, 2016 at 07:59:38PM +0800, Dongdong Liu wrote: > Hi Bjorn > > Many Thanks for your review > > 在 2016/11/15 7:33, Bjorn Helgaas 写道: > >On Wed, Nov 09, 2016 at 05:14:57PM +0800, Dongdong Liu wrote: > >>PCIe controller in Hip05/HIP06/HIP07 SoCs is not ECAM compliant. > >>It is non ECA

Re: [PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-16 Thread Dongdong Liu
Hi Bjorn Many Thanks for your review 在 2016/11/15 7:33, Bjorn Helgaas 写道: On Wed, Nov 09, 2016 at 05:14:57PM +0800, Dongdong Liu wrote: PCIe controller in Hip05/HIP06/HIP07 SoCs is not ECAM compliant. It is non ECAM only for the RC bus config space;for any other bus underneath the root bus we

Re: [PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-14 Thread Bjorn Helgaas
On Wed, Nov 09, 2016 at 05:14:57PM +0800, Dongdong Liu wrote: > PCIe controller in Hip05/HIP06/HIP07 SoCs is not ECAM compliant. > It is non ECAM only for the RC bus config space;for any other bus > underneath the root bus we support ECAM access. > Add specific quirks for PCI config space accessors

[PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-09 Thread Dongdong Liu
PCIe controller in Hip05/HIP06/HIP07 SoCs is not ECAM compliant. It is non ECAM only for the RC bus config space;for any other bus underneath the root bus we support ECAM access. Add specific quirks for PCI config space accessors.This involves: 1. New initialization call hisi_pcie_init() to obtain