Re: [PATCH V4 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support

2015-01-23 Thread Wolfram Sang
Mostly good, except one thing: > +config I2C_DESIGNWARE_BAYTRAIL > + bool "Intel Baytrail I2C semaphore support" > + depends on I2C_DESIGNWARE_PLATFORM > + select IOSF_MBI This needs some dependency on something Baytrail specific. Otherwise, it causes lots of build errors: With ARM

Re: [PATCH V4 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support

2015-01-23 Thread Mika Westerberg
On Thu, Jan 22, 2015 at 12:48:51PM -0800, David E. Box wrote: > > It would be nice if it was possible to compile this as a module. > > In the makefile the driver is now part of the composite object for > I2C_DESIGNWARE_PLATFORM. So if selected it will compile as the platform driver > is compiled.

Re: [PATCH V4 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support

2015-01-23 Thread Mika Westerberg
On Thu, Jan 22, 2015 at 12:48:51PM -0800, David E. Box wrote: It would be nice if it was possible to compile this as a module. In the makefile the driver is now part of the composite object for I2C_DESIGNWARE_PLATFORM. So if selected it will compile as the platform driver is compiled. This

Re: [PATCH V4 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support

2015-01-23 Thread Wolfram Sang
Mostly good, except one thing: +config I2C_DESIGNWARE_BAYTRAIL + bool Intel Baytrail I2C semaphore support + depends on I2C_DESIGNWARE_PLATFORM + select IOSF_MBI This needs some dependency on something Baytrail specific. Otherwise, it causes lots of build errors: With ARM

Re: [PATCH V4 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support

2015-01-22 Thread David E. Box
Hi Mika, On Thu, Jan 22, 2015 at 04:28:19PM +0200, Mika Westerberg wrote: > On Thu, Jan 15, 2015 at 01:12:17AM -0800, David E. Box wrote: > > This patch implements an I2C bus sharing mechanism between the host and > > platform > > hardware on select Intel BayTrail SoC platforms using the

Re: [PATCH V4 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support

2015-01-22 Thread Mika Westerberg
On Thu, Jan 15, 2015 at 01:12:17AM -0800, David E. Box wrote: > This patch implements an I2C bus sharing mechanism between the host and > platform > hardware on select Intel BayTrail SoC platforms using the X-Powers AXP288 > PMIC. > > On these platforms access to the PMIC must be shared with

Re: [PATCH V4 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support

2015-01-22 Thread Mika Westerberg
On Thu, Jan 15, 2015 at 01:12:17AM -0800, David E. Box wrote: This patch implements an I2C bus sharing mechanism between the host and platform hardware on select Intel BayTrail SoC platforms using the X-Powers AXP288 PMIC. On these platforms access to the PMIC must be shared with platform

Re: [PATCH V4 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support

2015-01-22 Thread David E. Box
Hi Mika, On Thu, Jan 22, 2015 at 04:28:19PM +0200, Mika Westerberg wrote: On Thu, Jan 15, 2015 at 01:12:17AM -0800, David E. Box wrote: This patch implements an I2C bus sharing mechanism between the host and platform hardware on select Intel BayTrail SoC platforms using the X-Powers

[PATCH V4 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support

2015-01-15 Thread David E. Box
This patch implements an I2C bus sharing mechanism between the host and platform hardware on select Intel BayTrail SoC platforms using the X-Powers AXP288 PMIC. On these platforms access to the PMIC must be shared with platform hardware. The hardware unit assumes full control of the I2C bus and

[PATCH V4 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support

2015-01-15 Thread David E. Box
This patch implements an I2C bus sharing mechanism between the host and platform hardware on select Intel BayTrail SoC platforms using the X-Powers AXP288 PMIC. On these platforms access to the PMIC must be shared with platform hardware. The hardware unit assumes full control of the I2C bus and