Re: [PATCH V4 2/6] perf/amd/iommu: Modify functions to query max banks and counters

2016-02-21 Thread Suravee Suthikulpanit
Hi, On 02/18/2016 06:11 PM, Borislav Petkov wrote: On Thu, Feb 11, 2016 at 04:15:23PM +0700, Suravee Suthikulpanit wrote: Currently, amd_iommu_pc_get_max_[banks|counters]() require devid, which should not be the case. Why? Commit message could use an explanation. Also, these don't

Re: [PATCH V4 2/6] perf/amd/iommu: Modify functions to query max banks and counters

2016-02-21 Thread Suravee Suthikulpanit
Hi, On 02/18/2016 06:11 PM, Borislav Petkov wrote: On Thu, Feb 11, 2016 at 04:15:23PM +0700, Suravee Suthikulpanit wrote: Currently, amd_iommu_pc_get_max_[banks|counters]() require devid, which should not be the case. Why? Commit message could use an explanation. Also, these don't

Re: [PATCH V4 2/6] perf/amd/iommu: Modify functions to query max banks and counters

2016-02-18 Thread Borislav Petkov
On Thu, Feb 11, 2016 at 04:15:23PM +0700, Suravee Suthikulpanit wrote: > Currently, amd_iommu_pc_get_max_[banks|counters]() require devid, > which should not be the case. Why? Commit message could use an explanation. > Also, these don't properly support > multi-IOMMU system. > > Current and

Re: [PATCH V4 2/6] perf/amd/iommu: Modify functions to query max banks and counters

2016-02-18 Thread Borislav Petkov
On Thu, Feb 11, 2016 at 04:15:23PM +0700, Suravee Suthikulpanit wrote: > Currently, amd_iommu_pc_get_max_[banks|counters]() require devid, > which should not be the case. Why? Commit message could use an explanation. > Also, these don't properly support > multi-IOMMU system. > > Current and

[PATCH V4 2/6] perf/amd/iommu: Modify functions to query max banks and counters

2016-02-11 Thread Suravee Suthikulpanit
Currently, amd_iommu_pc_get_max_[banks|counters]() require devid, which should not be the case. Also, these don't properly support multi-IOMMU system. Current and future AMD systems with IOMMU that support perf counter would likely contain homogeneous IOMMUs where multiple IOMMUs are availalbe.

[PATCH V4 2/6] perf/amd/iommu: Modify functions to query max banks and counters

2016-02-11 Thread Suravee Suthikulpanit
Currently, amd_iommu_pc_get_max_[banks|counters]() require devid, which should not be the case. Also, these don't properly support multi-IOMMU system. Current and future AMD systems with IOMMU that support perf counter would likely contain homogeneous IOMMUs where multiple IOMMUs are availalbe.