Re: [PATCH V4 4/4] gpio: tegra: Add support for gpio debounce

2016-04-25 Thread Laxman Dewangan
On Monday 25 April 2016 11:06 AM, Alexandre Courbot wrote: Sorry, just realized I commented on v3... On Fri, Apr 22, 2016 at 7:09 PM, Laxman Dewangan wrote: + spinlock_t dbc_lock[4]; /* Lock for updating debounce count register */ I'm nit'ing here, but maybe one spinlock shared by all

Re: [PATCH V4 4/4] gpio: tegra: Add support for gpio debounce

2016-04-24 Thread Alexandre Courbot
Sorry, just realized I commented on v3... On Fri, Apr 22, 2016 at 7:09 PM, Laxman Dewangan wrote: > NVIDIA's Tegra210 support the HW debounce in the GPIO controller > for all its GPIO pins. > > Add support for setting debounce timing by implementing the > set_debounce callback of gpiochip. > > Si

Re: [PATCH V4 4/4] gpio: tegra: Add support for gpio debounce

2016-04-22 Thread Stephen Warren
On 04/22/2016 04:09 AM, Laxman Dewangan wrote: NVIDIA's Tegra210 support the HW debounce in the GPIO controller for all its GPIO pins. Add support for setting debounce timing by implementing the set_debounce callback of gpiochip. Reviewed-by: Stephen Warren

[PATCH V4 4/4] gpio: tegra: Add support for gpio debounce

2016-04-22 Thread Laxman Dewangan
NVIDIA's Tegra210 support the HW debounce in the GPIO controller for all its GPIO pins. Add support for setting debounce timing by implementing the set_debounce callback of gpiochip. Signed-off-by: Laxman Dewangan --- Changes from V1: - Write debounce count before enable. - Make sure the deboun