RE: [PATCH V4 5/5] clk: imx8qxp: Support building i.MX8QXP clock driver as module

2020-07-01 Thread Anson Huang
> Subject: Re: [PATCH V4 5/5] clk: imx8qxp: Support building i.MX8QXP clock > driver as module > > On Thu, Jul 2, 2020 at 11:55 AM Anson Huang > wrote: > [...] > > > > +{ > > > > + return platform_driver_register(_lpcg_clk_dr

Re: [PATCH V4 5/5] clk: imx8qxp: Support building i.MX8QXP clock driver as module

2020-07-01 Thread Dong Aisheng
On Thu, Jul 2, 2020 at 11:55 AM Anson Huang wrote: [...] > > > +{ > > > + return platform_driver_register(_lpcg_clk_driver); > > > +} > > > +device_initcall(imx8qxp_lpcg_clk_init); > > > > Any reason to change to device_initcall which looks a bit strange? > > Is it because the following

RE: [PATCH V4 5/5] clk: imx8qxp: Support building i.MX8QXP clock driver as module

2020-07-01 Thread Anson Huang
> Subject: Re: [PATCH V4 5/5] clk: imx8qxp: Support building i.MX8QXP clock > driver as module > > On Thu, Jul 2, 2020 at 10:20 AM Anson Huang > wrote: > > > > Change configuration to "tristate", use device_initcall() instead of > > builtin_platfo

Re: [PATCH V4 5/5] clk: imx8qxp: Support building i.MX8QXP clock driver as module

2020-07-01 Thread Dong Aisheng
On Thu, Jul 2, 2020 at 10:20 AM Anson Huang wrote: > > Change configuration to "tristate", use device_initcall() instead > of builtin_platform_driver(), add module author, description and > license to support building i.MX8QXP clock drivers as module. > > Signed-off-by: Anson Huang > --- >

[PATCH V4 5/5] clk: imx8qxp: Support building i.MX8QXP clock driver as module

2020-07-01 Thread Anson Huang
Change configuration to "tristate", use device_initcall() instead of builtin_platform_driver(), add module author, description and license to support building i.MX8QXP clock drivers as module. Signed-off-by: Anson Huang --- Changes since V3: - use device_initcall() instead of