Re: [PATCH V5 1/3] mm/nobootmem: Fix unused variable

2014-01-21 Thread David Rientjes
On Tue, 21 Jan 2014, Philipp Hachtmann wrote: > > Not sure why you don't just do a one line patch: > > > > - phys_addr_t size; > > + phys_addr_t size __maybe_unused; > > to fix it. > > Just because I did not know that __maybe_unused thing. > - phys_addr_t size; + phys_addr_t

Re: [PATCH V5 1/3] mm/nobootmem: Fix unused variable

2014-01-21 Thread David Rientjes
On Tue, 21 Jan 2014, Philipp Hachtmann wrote: Not sure why you don't just do a one line patch: - phys_addr_t size; + phys_addr_t size __maybe_unused; to fix it. Just because I did not know that __maybe_unused thing. - phys_addr_t size; + phys_addr_t size = 0;

Re: [PATCH V5 1/3] mm/nobootmem: Fix unused variable

2014-01-20 Thread Philipp Hachtmann
Am Mon, 20 Jan 2014 22:16:33 -0800 (PST) schrieb David Rientjes : > Not sure why you don't just do a one line patch: > > - phys_addr_t size; > + phys_addr_t size __maybe_unused; > to fix it. Just because I did not know that __maybe_unused thing. Discussion of this fix seems to be

Re: [PATCH V5 1/3] mm/nobootmem: Fix unused variable

2014-01-20 Thread David Rientjes
On Mon, 20 Jan 2014, Philipp Hachtmann wrote: > diff --git a/mm/nobootmem.c b/mm/nobootmem.c > index e2906a5..0215c77 100644 > --- a/mm/nobootmem.c > +++ b/mm/nobootmem.c > @@ -116,23 +116,29 @@ static unsigned long __init > __free_memory_core(phys_addr_t start, > static unsigned long __init

Re: [PATCH V5 1/3] mm/nobootmem: Fix unused variable

2014-01-20 Thread Robin Holt
On Mon, Jan 20, 2014 at 5:32 AM, Philipp Hachtmann wrote: > This fixes an unused variable warning in nobootmem.c > > Signed-off-by: Philipp Hachtmann > --- > mm/nobootmem.c | 28 +--- > 1 file changed, 17 insertions(+), 11 deletions(-) > > diff --git a/mm/nobootmem.c

[PATCH V5 1/3] mm/nobootmem: Fix unused variable

2014-01-20 Thread Philipp Hachtmann
This fixes an unused variable warning in nobootmem.c Signed-off-by: Philipp Hachtmann --- mm/nobootmem.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/mm/nobootmem.c b/mm/nobootmem.c index e2906a5..0215c77 100644 --- a/mm/nobootmem.c +++

Re: [PATCH V5 1/3] mm/nobootmem: Fix unused variable

2014-01-20 Thread Robin Holt
On Mon, Jan 20, 2014 at 5:32 AM, Philipp Hachtmann pha...@linux.vnet.ibm.com wrote: This fixes an unused variable warning in nobootmem.c Signed-off-by: Philipp Hachtmann pha...@linux.vnet.ibm.com --- mm/nobootmem.c | 28 +--- 1 file changed, 17 insertions(+), 11

Re: [PATCH V5 1/3] mm/nobootmem: Fix unused variable

2014-01-20 Thread David Rientjes
On Mon, 20 Jan 2014, Philipp Hachtmann wrote: diff --git a/mm/nobootmem.c b/mm/nobootmem.c index e2906a5..0215c77 100644 --- a/mm/nobootmem.c +++ b/mm/nobootmem.c @@ -116,23 +116,29 @@ static unsigned long __init __free_memory_core(phys_addr_t start, static unsigned long __init

Re: [PATCH V5 1/3] mm/nobootmem: Fix unused variable

2014-01-20 Thread Philipp Hachtmann
Am Mon, 20 Jan 2014 22:16:33 -0800 (PST) schrieb David Rientjes rient...@google.com: Not sure why you don't just do a one line patch: - phys_addr_t size; + phys_addr_t size __maybe_unused; to fix it. Just because I did not know that __maybe_unused thing. Discussion of this fix

[PATCH V5 1/3] mm/nobootmem: Fix unused variable

2014-01-20 Thread Philipp Hachtmann
This fixes an unused variable warning in nobootmem.c Signed-off-by: Philipp Hachtmann pha...@linux.vnet.ibm.com --- mm/nobootmem.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/mm/nobootmem.c b/mm/nobootmem.c index e2906a5..0215c77 100644 ---