Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-18 Thread Arnd Bergmann
On Monday, November 14, 2016 11:11:11 AM CET One Thousand Gnomes wrote: > > > It's not a safe assumption for x86 at least. There are a few systems with > > > multiple ISA busses particularly older laptops with a docking station. > > > > But do they have multiple ISA domains? There is no real

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-18 Thread Arnd Bergmann
On Monday, November 14, 2016 11:11:11 AM CET One Thousand Gnomes wrote: > > > It's not a safe assumption for x86 at least. There are a few systems with > > > multiple ISA busses particularly older laptops with a docking station. > > > > But do they have multiple ISA domains? There is no real

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-14 Thread One Thousand Gnomes
> > It's not a safe assumption for x86 at least. There are a few systems with > > multiple ISA busses particularly older laptops with a docking station. > > But do they have multiple ISA domains? There is no real harm in supporting > it, the (small) downsides I can think of are: I don't

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-14 Thread One Thousand Gnomes
> > It's not a safe assumption for x86 at least. There are a few systems with > > multiple ISA busses particularly older laptops with a docking station. > > But do they have multiple ISA domains? There is no real harm in supporting > it, the (small) downsides I can think of are: I don't

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-11 Thread liviu.du...@arm.com
.@vger.kernel.org; linux-...@vger.kernel.org; linux- > > ser...@vger.kernel.org; miny...@acm.org; b...@kernel.crashing.org; > > zourongr...@gmail.com; John Garry; zhichang.yua...@gmail.com; > > kant...@163.com; xuwei (O) > > Subject: Re: [PATCH V5 2/3] ARM64 LPC: Add missing range excep

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-11 Thread liviu.du...@arm.com
.@vger.kernel.org; linux-...@vger.kernel.org; linux- > > ser...@vger.kernel.org; miny...@acm.org; b...@kernel.crashing.org; > > zourongr...@gmail.com; John Garry; zhichang.yua...@gmail.com; > > kant...@163.com; xuwei (O) > > Subject: Re: [PATCH V5 2/3] ARM64 LPC: Add missing range excep

RE: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-10 Thread Gabriele Paoloni
zourongr...@gmail.com; John Garry; zhichang.yua...@gmail.com; > kant...@163.com; xuwei (O) > Subject: Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for > special ISA > > On Wed, Nov 09, 2016 at 04:16:17PM +, Gabriele Paoloni wrote: > > Hi Liviu > > >

RE: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-10 Thread Gabriele Paoloni
zourongr...@gmail.com; John Garry; zhichang.yua...@gmail.com; > kant...@163.com; xuwei (O) > Subject: Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for > special ISA > > On Wed, Nov 09, 2016 at 04:16:17PM +, Gabriele Paoloni wrote: > > Hi Liviu > > >

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread Benjamin Herrenschmidt
On Wed, 2016-11-09 at 11:20 +, Mark Rutland wrote: > The big change would be to handle !MMIO translations, for which we'd > need a runtime registry of ISA bus instance to find the relevant > accessor ops and instance-specific data. Yes. We do something a bit like that on ppc, we find the PCI

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread Benjamin Herrenschmidt
On Wed, 2016-11-09 at 11:20 +, Mark Rutland wrote: > The big change would be to handle !MMIO translations, for which we'd > need a runtime registry of ISA bus instance to find the relevant > accessor ops and instance-specific data. Yes. We do something a bit like that on ppc, we find the PCI

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread zhichang.yuan
Hi,Liviu, Thanks for your comments! On 2016/11/10 0:50, liviu.du...@arm.com wrote: > On Wed, Nov 09, 2016 at 04:16:17PM +, Gabriele Paoloni wrote: >> Hi Liviu >> >> Thanks for reviewing >> > > [removed some irrelevant part of discussion, avoid crazy formatting] > +/** + *

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread zhichang.yuan
Hi,Liviu, Thanks for your comments! On 2016/11/10 0:50, liviu.du...@arm.com wrote: > On Wed, Nov 09, 2016 at 04:16:17PM +, Gabriele Paoloni wrote: >> Hi Liviu >> >> Thanks for reviewing >> > > [removed some irrelevant part of discussion, avoid crazy formatting] > +/** + *

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread Arnd Bergmann
On Wednesday, November 9, 2016 1:54:53 PM CET One Thousand Gnomes wrote: > > I think it is a relatively safe assumption that there is only one > > ISA bridge. A lot of old drivers hardcode PIO or memory addresses > > It's not a safe assumption for x86 at least. There are a few systems with >

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread Arnd Bergmann
On Wednesday, November 9, 2016 1:54:53 PM CET One Thousand Gnomes wrote: > > I think it is a relatively safe assumption that there is only one > > ISA bridge. A lot of old drivers hardcode PIO or memory addresses > > It's not a safe assumption for x86 at least. There are a few systems with >

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread liviu.du...@arm.com
On Wed, Nov 09, 2016 at 04:16:17PM +, Gabriele Paoloni wrote: > Hi Liviu > > Thanks for reviewing > [removed some irrelevant part of discussion, avoid crazy formatting] > > > +/** > > > + * addr_is_indirect_io - check whether the input taddr is for > > indirectIO. > > > + * @taddr: the io

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread liviu.du...@arm.com
On Wed, Nov 09, 2016 at 04:16:17PM +, Gabriele Paoloni wrote: > Hi Liviu > > Thanks for reviewing > [removed some irrelevant part of discussion, avoid crazy formatting] > > > +/** > > > + * addr_is_indirect_io - check whether the input taddr is for > > indirectIO. > > > + * @taddr: the io

RE: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread Gabriele Paoloni
zourongr...@gmail.com; John Garry; Gabriele Paoloni; > zhichang.yua...@gmail.com; kant...@163.com; xuwei (O) > Subject: Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for > special ISA > > On Tue, Nov 08, 2016 at 11:47:08AM +0800, zhichang.yuan wrote: > > This patch solve

RE: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread Gabriele Paoloni
zourongr...@gmail.com; John Garry; Gabriele Paoloni; > zhichang.yua...@gmail.com; kant...@163.com; xuwei (O) > Subject: Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for > special ISA > > On Tue, Nov 08, 2016 at 11:47:08AM +0800, zhichang.yuan wrote: > > This patch solve

RE: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread Gabriele Paoloni
.@gmail.com; John Garry; Gabriele > Paoloni; zhichang.yua...@gmail.com; kant...@163.com; xuwei (O); > marc.zyng...@arm.com > Subject: Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for > special ISA > > > I think it is a relatively safe assumption that there is only

RE: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread Gabriele Paoloni
.@gmail.com; John Garry; Gabriele > Paoloni; zhichang.yua...@gmail.com; kant...@163.com; xuwei (O); > marc.zyng...@arm.com > Subject: Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for > special ISA > > > I think it is a relatively safe assumption that there is only

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread One Thousand Gnomes
> I think it is a relatively safe assumption that there is only one > ISA bridge. A lot of old drivers hardcode PIO or memory addresses It's not a safe assumption for x86 at least. There are a few systems with multiple ISA busses particularly older laptops with a docking station. > when talking

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread One Thousand Gnomes
> I think it is a relatively safe assumption that there is only one > ISA bridge. A lot of old drivers hardcode PIO or memory addresses It's not a safe assumption for x86 at least. There are a few systems with multiple ISA busses particularly older laptops with a docking station. > when talking

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread liviu . dudau
On Tue, Nov 08, 2016 at 11:47:08AM +0800, zhichang.yuan wrote: > This patch solves two issues: > 1) parse and get the right I/O range from DTS node whose parent does not > define the corresponding ranges property; > > There are some special ISA/LPC devices that work on a specific I/O range where

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread liviu . dudau
On Tue, Nov 08, 2016 at 11:47:08AM +0800, zhichang.yuan wrote: > This patch solves two issues: > 1) parse and get the right I/O range from DTS node whose parent does not > define the corresponding ranges property; > > There are some special ISA/LPC devices that work on a specific I/O range where

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread Mark Rutland
On Wed, Nov 09, 2016 at 10:12:59AM +1100, Benjamin Herrenschmidt wrote: > On Tue, 2016-11-08 at 11:49 +, Mark Rutland wrote: > > I believe that we could theoretically have multiple independent LPC/ISA > > busses, as is possible with PCI on !x86 systems. If the current ISA code > > assumes a

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread Mark Rutland
On Wed, Nov 09, 2016 at 10:12:59AM +1100, Benjamin Herrenschmidt wrote: > On Tue, 2016-11-08 at 11:49 +, Mark Rutland wrote: > > I believe that we could theoretically have multiple independent LPC/ISA > > busses, as is possible with PCI on !x86 systems. If the current ISA code > > assumes a

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-08 Thread Benjamin Herrenschmidt
On Tue, 2016-11-08 at 11:49 +, Mark Rutland wrote: > > My understanding of ISA (which may be flawed) is that it's not part of > the PCI host bridge, but rather on x86 it happens to share the IO space > with PCI. Sort-of. On some systems it actually goes through PCI and there's a PCI->ISA

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-08 Thread Benjamin Herrenschmidt
On Tue, 2016-11-08 at 11:49 +, Mark Rutland wrote: > > My understanding of ISA (which may be flawed) is that it's not part of > the PCI host bridge, but rather on x86 it happens to share the IO space > with PCI. Sort-of. On some systems it actually goes through PCI and there's a PCI->ISA

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-08 Thread Mark Rutland
On Tue, Nov 08, 2016 at 05:19:54PM +0100, Arnd Bergmann wrote: > On Tuesday, November 8, 2016 11:49:53 AM CET Mark Rutland wrote: > > My understanding of ISA (which may be flawed) is that it's not part of > > the PCI host bridge, but rather on x86 it happens to share the IO space > > with PCI. >

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-08 Thread Mark Rutland
On Tue, Nov 08, 2016 at 05:19:54PM +0100, Arnd Bergmann wrote: > On Tuesday, November 8, 2016 11:49:53 AM CET Mark Rutland wrote: > > My understanding of ISA (which may be flawed) is that it's not part of > > the PCI host bridge, but rather on x86 it happens to share the IO space > > with PCI. >

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-08 Thread Arnd Bergmann
On Tuesday, November 8, 2016 11:49:53 AM CET Mark Rutland wrote: > On Tue, Nov 08, 2016 at 11:47:08AM +0800, zhichang.yuan wrote: > > +Hisilicon Hip06 low-pin-count device > > + Usually LPC controller is part of PCI host bridge, so the legacy ISA > > ports > > + locate on LPC bus can be

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-08 Thread Arnd Bergmann
On Tuesday, November 8, 2016 11:49:53 AM CET Mark Rutland wrote: > On Tue, Nov 08, 2016 at 11:47:08AM +0800, zhichang.yuan wrote: > > +Hisilicon Hip06 low-pin-count device > > + Usually LPC controller is part of PCI host bridge, so the legacy ISA > > ports > > + locate on LPC bus can be

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-08 Thread Mark Rutland
On Tue, Nov 08, 2016 at 11:47:08AM +0800, zhichang.yuan wrote: > +Hisilicon Hip06 low-pin-count device > + Usually LPC controller is part of PCI host bridge, so the legacy ISA ports > + locate on LPC bus can be accessed direclty. But some SoCs have independent > + LPC controller, and access the

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-08 Thread Mark Rutland
On Tue, Nov 08, 2016 at 11:47:08AM +0800, zhichang.yuan wrote: > +Hisilicon Hip06 low-pin-count device > + Usually LPC controller is part of PCI host bridge, so the legacy ISA ports > + locate on LPC bus can be accessed direclty. But some SoCs have independent > + LPC controller, and access the

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-07 Thread kbuild test robot
Hi zhichang.yuan, [auto build test ERROR on arm64/for-next/core] [also build test ERROR on v4.9-rc4 next-20161028] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-07 Thread kbuild test robot
Hi zhichang.yuan, [auto build test ERROR on arm64/for-next/core] [also build test ERROR on v4.9-rc4 next-20161028] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-07 Thread kbuild test robot
Hi zhichang.yuan, [auto build test ERROR on arm64/for-next/core] [also build test ERROR on v4.9-rc4 next-20161028] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-07 Thread kbuild test robot
Hi zhichang.yuan, [auto build test ERROR on arm64/for-next/core] [also build test ERROR on v4.9-rc4 next-20161028] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-07 Thread zhichang.yuan
This patch solves two issues: 1) parse and get the right I/O range from DTS node whose parent does not define the corresponding ranges property; There are some special ISA/LPC devices that work on a specific I/O range where it is not correct to specify a ranges property in DTS parent node as cpu

[PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-07 Thread zhichang.yuan
This patch solves two issues: 1) parse and get the right I/O range from DTS node whose parent does not define the corresponding ranges property; There are some special ISA/LPC devices that work on a specific I/O range where it is not correct to specify a ranges property in DTS parent node as cpu