Re: [PATCH V5 4/5] kbuild: Add support to build overlays (%.dtbo)

2021-01-20 Thread David Gibson
On Thu, Jan 21, 2021 at 09:43:00AM +0530, Viresh Kumar wrote: > On 21-01-21, 11:49, David Gibson wrote: > > If you're using overlays, you probably need the -@ flag, for both the > > base file and the overlays, which AFAICT is not already the case. > > I think the idea was to do that in the platfor

Re: [PATCH V5 4/5] kbuild: Add support to build overlays (%.dtbo)

2021-01-20 Thread Frank Rowand
On 1/20/21 10:13 PM, Viresh Kumar wrote: > On 21-01-21, 11:49, David Gibson wrote: >> If you're using overlays, you probably need the -@ flag, for both the >> base file and the overlays, which AFAICT is not already the case. > > I think the idea was to do that in the platform specific Makefiles, >

Re: [PATCH V5 4/5] kbuild: Add support to build overlays (%.dtbo)

2021-01-20 Thread Viresh Kumar
On 21-01-21, 11:49, David Gibson wrote: > If you're using overlays, you probably need the -@ flag, for both the > base file and the overlays, which AFAICT is not already the case. I think the idea was to do that in the platform specific Makefiles, unless I have misunderstood that from earlier disc

Re: [PATCH V5 4/5] kbuild: Add support to build overlays (%.dtbo)

2021-01-20 Thread David Gibson
On Wed, Jan 20, 2021 at 12:36:46PM +0530, Viresh Kumar wrote: > Add support for building DT overlays (%.dtbo). The overlay's source file > will have the usual extension, i.e. .dts, though the blob will have > .dtbo extension to distinguish it from normal blobs. > > Signed-off-by: Viresh Kumar > -

Re: [PATCH V5 4/5] kbuild: Add support to build overlays (%.dtbo)

2021-01-20 Thread Viresh Kumar
On 20-01-21, 20:04, Masahiro Yamada wrote: > The DTC rule takes one source input, and one output file. > > It cannot generate .dtb and .dtbo at the same time. > > That is why a grouped target does not fit here. Okay, thanks for taking time to explain this. Will fix this in the next version. --

Re: [PATCH V5 4/5] kbuild: Add support to build overlays (%.dtbo)

2021-01-20 Thread Masahiro Yamada
On Wed, Jan 20, 2021 at 6:55 PM Viresh Kumar wrote: > > On 20-01-21, 17:58, Masahiro Yamada wrote: > > > +%.dtb %.dtbo: include/config/kernel.release scripts_dtc > > > $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ > > > > > > No, this is wrong because it does not work > > as grouped target

Re: [PATCH V5 4/5] kbuild: Add support to build overlays (%.dtbo)

2021-01-20 Thread Viresh Kumar
On 20-01-21, 17:58, Masahiro Yamada wrote: > > +%.dtb %.dtbo: include/config/kernel.release scripts_dtc > > $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ > > > No, this is wrong because it does not work > as grouped targets. > > You need to separate them. > > > > %.dtb: include/config

Re: [PATCH V5 4/5] kbuild: Add support to build overlays (%.dtbo)

2021-01-20 Thread Masahiro Yamada
On Wed, Jan 20, 2021 at 4:07 PM Viresh Kumar wrote: > > Add support for building DT overlays (%.dtbo). The overlay's source file > will have the usual extension, i.e. .dts, though the blob will have > .dtbo extension to distinguish it from normal blobs. > > Signed-off-by: Viresh Kumar > --- > .g

[PATCH V5 4/5] kbuild: Add support to build overlays (%.dtbo)

2021-01-19 Thread Viresh Kumar
Add support for building DT overlays (%.dtbo). The overlay's source file will have the usual extension, i.e. .dts, though the blob will have .dtbo extension to distinguish it from normal blobs. Signed-off-by: Viresh Kumar --- .gitignore | 3 +-- Makefile | 4 ++-- s