Re: [PATCH V6 01/18] x86: Make page cache mode a real type

2015-01-22 Thread Juergen Gross
On 01/22/2015 12:06 PM, Thomas Gleixner wrote: On Thu, 22 Jan 2015, Juergen Gross wrote: On 01/22/2015 08:11 AM, Steven Noonan wrote: I notice these two symbols are exported GPL-only. This breaks builds of several out-of-tree non-GPL modules such as the NVIDIA driver, and VMware modules, etc.

Re: [PATCH V6 01/18] x86: Make page cache mode a real type

2015-01-22 Thread Thomas Gleixner
On Thu, 22 Jan 2015, Juergen Gross wrote: > On 01/22/2015 08:11 AM, Steven Noonan wrote: > > I notice these two symbols are exported GPL-only. This breaks builds > > of several out-of-tree non-GPL modules such as the NVIDIA driver, and > > VMware modules, etc. What is the appropriate code path for

Re: [PATCH V6 01/18] x86: Make page cache mode a real type

2015-01-22 Thread Juergen Gross
On 01/22/2015 08:11 AM, Steven Noonan wrote: On Mon, Nov 3, 2014 at 5:01 AM, Juergen Gross wrote: At the moment there are a lot of places that handle setting or getting the page cache mode by treating the pgprot bits equal to the cache mode. This is only true because there are a lot of

Re: [PATCH V6 01/18] x86: Make page cache mode a real type

2015-01-22 Thread Juergen Gross
On 01/22/2015 12:06 PM, Thomas Gleixner wrote: On Thu, 22 Jan 2015, Juergen Gross wrote: On 01/22/2015 08:11 AM, Steven Noonan wrote: I notice these two symbols are exported GPL-only. This breaks builds of several out-of-tree non-GPL modules such as the NVIDIA driver, and VMware modules, etc.

Re: [PATCH V6 01/18] x86: Make page cache mode a real type

2015-01-22 Thread Juergen Gross
On 01/22/2015 08:11 AM, Steven Noonan wrote: On Mon, Nov 3, 2014 at 5:01 AM, Juergen Gross jgr...@suse.com wrote: At the moment there are a lot of places that handle setting or getting the page cache mode by treating the pgprot bits equal to the cache mode. This is only true because there are a

Re: [PATCH V6 01/18] x86: Make page cache mode a real type

2015-01-22 Thread Thomas Gleixner
On Thu, 22 Jan 2015, Juergen Gross wrote: On 01/22/2015 08:11 AM, Steven Noonan wrote: I notice these two symbols are exported GPL-only. This breaks builds of several out-of-tree non-GPL modules such as the NVIDIA driver, and VMware modules, etc. What is the appropriate code path for

Re: [PATCH V6 01/18] x86: Make page cache mode a real type

2015-01-21 Thread Steven Noonan
On Mon, Nov 3, 2014 at 5:01 AM, Juergen Gross wrote: > At the moment there are a lot of places that handle setting or getting > the page cache mode by treating the pgprot bits equal to the cache mode. > This is only true because there are a lot of assumptions about the setup > of the PAT MSR.

Re: [PATCH V6 01/18] x86: Make page cache mode a real type

2015-01-21 Thread Steven Noonan
On Mon, Nov 3, 2014 at 5:01 AM, Juergen Gross jgr...@suse.com wrote: At the moment there are a lot of places that handle setting or getting the page cache mode by treating the pgprot bits equal to the cache mode. This is only true because there are a lot of assumptions about the setup of the

[PATCH V6 01/18] x86: Make page cache mode a real type

2014-11-03 Thread Juergen Gross
At the moment there are a lot of places that handle setting or getting the page cache mode by treating the pgprot bits equal to the cache mode. This is only true because there are a lot of assumptions about the setup of the PAT MSR. Otherwise the cache type needs to get translated into pgprot bits

[PATCH V6 01/18] x86: Make page cache mode a real type

2014-11-03 Thread Juergen Gross
At the moment there are a lot of places that handle setting or getting the page cache mode by treating the pgprot bits equal to the cache mode. This is only true because there are a lot of assumptions about the setup of the PAT MSR. Otherwise the cache type needs to get translated into pgprot bits