Re: [PATCH V6 1/2] PHY: Exynos: Add Exynos5250 SATA PHY driver

2014-01-27 Thread Yuvaraj Kumar
On Fri, Jan 10, 2014 at 8:35 PM, Tomasz Figa wrote: > Hi Yuvaraj, > > In general this version looks pretty good, but I have some questions inline. > > On 10.01.2014 08:00, Yuvaraj Kumar C D wrote: > [snip] > >> diff --git a/drivers/phy/phy-exynos5250-sata-i2c.c >>

Re: [PATCH V6 1/2] PHY: Exynos: Add Exynos5250 SATA PHY driver

2014-01-27 Thread Yuvaraj Kumar
On Fri, Jan 10, 2014 at 8:35 PM, Tomasz Figa t.f...@samsung.com wrote: Hi Yuvaraj, In general this version looks pretty good, but I have some questions inline. On 10.01.2014 08:00, Yuvaraj Kumar C D wrote: [snip] diff --git a/drivers/phy/phy-exynos5250-sata-i2c.c

Re: [PATCH V6 1/2] PHY: Exynos: Add Exynos5250 SATA PHY driver

2014-01-17 Thread Yuvaraj Kumar
Sorry for the late reply. On Fri, Jan 10, 2014 at 8:35 PM, Tomasz Figa wrote: > Hi Yuvaraj, > > In general this version looks pretty good, but I have some questions inline. Please find my comments inline. > > On 10.01.2014 08:00, Yuvaraj Kumar C D wrote: > [snip] > >> diff --git

Re: [PATCH V6 1/2] PHY: Exynos: Add Exynos5250 SATA PHY driver

2014-01-17 Thread Yuvaraj Kumar
Sorry for the late reply. On Fri, Jan 10, 2014 at 8:35 PM, Tomasz Figa t.f...@samsung.com wrote: Hi Yuvaraj, In general this version looks pretty good, but I have some questions inline. Please find my comments inline. On 10.01.2014 08:00, Yuvaraj Kumar C D wrote: [snip] diff --git

Re: [PATCH V6 1/2] PHY: Exynos: Add Exynos5250 SATA PHY driver

2014-01-10 Thread Tomasz Figa
Hi Yuvaraj, In general this version looks pretty good, but I have some questions inline. On 10.01.2014 08:00, Yuvaraj Kumar C D wrote: [snip] diff --git a/drivers/phy/phy-exynos5250-sata-i2c.c b/drivers/phy/phy-exynos5250-sata-i2c.c new file mode 100644 index 000..206e337 --- /dev/null

Re: [PATCH V6 1/2] PHY: Exynos: Add Exynos5250 SATA PHY driver

2014-01-10 Thread Tomasz Figa
Hi Yuvaraj, In general this version looks pretty good, but I have some questions inline. On 10.01.2014 08:00, Yuvaraj Kumar C D wrote: [snip] diff --git a/drivers/phy/phy-exynos5250-sata-i2c.c b/drivers/phy/phy-exynos5250-sata-i2c.c new file mode 100644 index 000..206e337 --- /dev/null

[PATCH V6 1/2] PHY: Exynos: Add Exynos5250 SATA PHY driver

2014-01-09 Thread Yuvaraj Kumar C D
This patch adds the SATA PHY driver for Exynos5250.Exynos5250 SATA PHY comprises of CMU and TRSV blocks which are of I2C register Map. So this patch also adds a i2c client driver, which is used configure the CMU and TRSV block of exynos5250 SATA PHY. This patch incorporates the generic PHY

[PATCH V6 1/2] PHY: Exynos: Add Exynos5250 SATA PHY driver

2014-01-09 Thread Yuvaraj Kumar C D
This patch adds the SATA PHY driver for Exynos5250.Exynos5250 SATA PHY comprises of CMU and TRSV blocks which are of I2C register Map. So this patch also adds a i2c client driver, which is used configure the CMU and TRSV block of exynos5250 SATA PHY. This patch incorporates the generic PHY