Re: [PATCH V6 2/2] genirq/affinity: Spread vectors on node according to nr_cpu ratio

2019-08-22 Thread Derrick, Jonathan
lgtm. Don't know how often we'll see these configurations but it looks like it'll be handled gracefully Thanks for the effort Reviewed-by: Jon Derrick On Mon, 2019-08-19 at 20:49 +0800, Ming Lei wrote: > Now __irq_build_affinity_masks() spreads vectors evenly per node, and > all vectors may not

Re: [PATCH V6 2/2] genirq/affinity: Spread vectors on node according to nr_cpu ratio

2019-08-22 Thread Keith Busch
On Mon, Aug 19, 2019 at 05:49:37AM -0700, Ming Lei wrote: > Now __irq_build_affinity_masks() spreads vectors evenly per node, and > all vectors may not be spread in case that each numa node has different > CPU number, then the warning in irq_build_affinity_masks() can > be triggered. > > Improve

Re: [PATCH V6 2/2] genirq/affinity: Spread vectors on node according to nr_cpu ratio

2019-08-21 Thread Ming Lei
On Mon, Aug 19, 2019 at 04:02:21PM +0200, Thomas Gleixner wrote: > On Mon, 19 Aug 2019, Ming Lei wrote: > > On Mon, Aug 19, 2019 at 03:13:58PM +0200, Thomas Gleixner wrote: > > > On Mon, 19 Aug 2019, Ming Lei wrote: > > > > > > > Cc: Jon Derrick > > > > Cc: Jens Axboe > > > > Reported-by: Jon

Re: [PATCH V6 2/2] genirq/affinity: Spread vectors on node according to nr_cpu ratio

2019-08-19 Thread Thomas Gleixner
On Mon, 19 Aug 2019, Ming Lei wrote: > On Mon, Aug 19, 2019 at 03:13:58PM +0200, Thomas Gleixner wrote: > > On Mon, 19 Aug 2019, Ming Lei wrote: > > > > > Cc: Jon Derrick > > > Cc: Jens Axboe > > > Reported-by: Jon Derrick > > > Reviewed-by: Jon Derrick > > > Reviewed-by: Keith Busch > > >

Re: [PATCH V6 2/2] genirq/affinity: Spread vectors on node according to nr_cpu ratio

2019-08-19 Thread Ming Lei
On Mon, Aug 19, 2019 at 03:13:58PM +0200, Thomas Gleixner wrote: > On Mon, 19 Aug 2019, Ming Lei wrote: > > > Cc: Jon Derrick > > Cc: Jens Axboe > > Reported-by: Jon Derrick > > Reviewed-by: Jon Derrick > > Reviewed-by: Keith Busch > > This version is sufficiently different from the

Re: [PATCH V6 2/2] genirq/affinity: Spread vectors on node according to nr_cpu ratio

2019-08-19 Thread Thomas Gleixner
On Mon, 19 Aug 2019, Ming Lei wrote: > Cc: Jon Derrick > Cc: Jens Axboe > Reported-by: Jon Derrick > Reviewed-by: Jon Derrick > Reviewed-by: Keith Busch This version is sufficiently different from the previous one, so I do not consider the reviewed-by tags still being valid and meaningful.

[PATCH V6 2/2] genirq/affinity: Spread vectors on node according to nr_cpu ratio

2019-08-19 Thread Ming Lei
Now __irq_build_affinity_masks() spreads vectors evenly per node, and all vectors may not be spread in case that each numa node has different CPU number, then the warning in irq_build_affinity_masks() can be triggered. Improve current spreading algorithm by assigning vectors according to the