Re: [PATCH V6 5/5] remoteproc: qcom: Add q6v5-wcss rproc ops

Hi, On 5/18/2018 5:59 PM, Vinod wrote: > On 14-05-18, 16:16, Sricharan R wrote: > >> +static int q6v5_wcss_start(struct rproc *rproc) >> +{ >> +struct q6v5 *qproc = rproc->priv; >> +int ret = 0; > > Superfluous initialization > ok. >> + >> +ret = q6v5_clk_enable(qproc->dev,

Re: [PATCH V6 5/5] remoteproc: qcom: Add q6v5-wcss rproc ops

Hi, On 5/18/2018 5:59 PM, Vinod wrote: > On 14-05-18, 16:16, Sricharan R wrote: > >> +static int q6v5_wcss_start(struct rproc *rproc) >> +{ >> +struct q6v5 *qproc = rproc->priv; >> +int ret = 0; > > Superfluous initialization > ok. >> + >> +ret = q6v5_clk_enable(qproc->dev,

Re: [PATCH V6 5/5] remoteproc: qcom: Add q6v5-wcss rproc ops

On 14-05-18, 16:16, Sricharan R wrote: > +static int q6v5_wcss_start(struct rproc *rproc) > +{ > + struct q6v5 *qproc = rproc->priv; > + int ret = 0; Superfluous initialization > + > + ret = q6v5_clk_enable(qproc->dev, qproc->active_clks, > +

Re: [PATCH V6 5/5] remoteproc: qcom: Add q6v5-wcss rproc ops

On 14-05-18, 16:16, Sricharan R wrote: > +static int q6v5_wcss_start(struct rproc *rproc) > +{ > + struct q6v5 *qproc = rproc->priv; > + int ret = 0; Superfluous initialization > + > + ret = q6v5_clk_enable(qproc->dev, qproc->active_clks, > +

[PATCH V6 5/5] remoteproc: qcom: Add q6v5-wcss rproc ops

q6v5-wcss core's start function is mostly common with the q6v5 of msm8996. So reuse that and add the stop function. Signed-off-by: Sricharan R --- drivers/remoteproc/qcom_q6v5_pil.c | 227 + 1 file changed, 227 insertions(+) diff

[PATCH V6 5/5] remoteproc: qcom: Add q6v5-wcss rproc ops

q6v5-wcss core's start function is mostly common with the q6v5 of msm8996. So reuse that and add the stop function. Signed-off-by: Sricharan R --- drivers/remoteproc/qcom_q6v5_pil.c | 227 + 1 file changed, 227 insertions(+) diff --git