Re: [PATCH V8 1/2] printk: remove tabular output for NULL pointer

On Fri, 2017-10-27 at 10:57 +1100, Tobin C. Harding wrote: > On Thu, Oct 26, 2017 at 07:47:19AM -0700, Joe Perches wrote: > > On Thu, 2017-10-26 at 20:37 +1100, Tobin C. Harding wrote: > > > On Thu, Oct 26, 2017 at 01:05:39AM -0700, Joe Perches wrote: > > > > On Thu, 2017-10-26 at 17:27 +1100,

Re: [PATCH V8 1/2] printk: remove tabular output for NULL pointer

On Fri, 2017-10-27 at 10:57 +1100, Tobin C. Harding wrote: > On Thu, Oct 26, 2017 at 07:47:19AM -0700, Joe Perches wrote: > > On Thu, 2017-10-26 at 20:37 +1100, Tobin C. Harding wrote: > > > On Thu, Oct 26, 2017 at 01:05:39AM -0700, Joe Perches wrote: > > > > On Thu, 2017-10-26 at 17:27 +1100,

Re: [PATCH V8 1/2] printk: remove tabular output for NULL pointer

On Thu, Oct 26, 2017 at 07:47:19AM -0700, Joe Perches wrote: > On Thu, 2017-10-26 at 20:37 +1100, Tobin C. Harding wrote: > > On Thu, Oct 26, 2017 at 01:05:39AM -0700, Joe Perches wrote: > > > On Thu, 2017-10-26 at 17:27 +1100, Tobin C. Harding wrote: > > > > Hi Joe, > > > > > > > > thanks for

Re: [PATCH V8 1/2] printk: remove tabular output for NULL pointer

On Thu, Oct 26, 2017 at 07:47:19AM -0700, Joe Perches wrote: > On Thu, 2017-10-26 at 20:37 +1100, Tobin C. Harding wrote: > > On Thu, Oct 26, 2017 at 01:05:39AM -0700, Joe Perches wrote: > > > On Thu, 2017-10-26 at 17:27 +1100, Tobin C. Harding wrote: > > > > Hi Joe, > > > > > > > > thanks for

Re: [PATCH V8 1/2] printk: remove tabular output for NULL pointer

On Thu, 2017-10-26 at 20:37 +1100, Tobin C. Harding wrote: > On Thu, Oct 26, 2017 at 01:05:39AM -0700, Joe Perches wrote: > > On Thu, 2017-10-26 at 17:27 +1100, Tobin C. Harding wrote: > > > Hi Joe, > > > > > > thanks for your review. > > > > > > On Wed, Oct 25, 2017 at 09:57:23PM -0700, Joe

Re: [PATCH V8 1/2] printk: remove tabular output for NULL pointer

On Thu, 2017-10-26 at 20:37 +1100, Tobin C. Harding wrote: > On Thu, Oct 26, 2017 at 01:05:39AM -0700, Joe Perches wrote: > > On Thu, 2017-10-26 at 17:27 +1100, Tobin C. Harding wrote: > > > Hi Joe, > > > > > > thanks for your review. > > > > > > On Wed, Oct 25, 2017 at 09:57:23PM -0700, Joe

Re: [PATCH V8 1/2] printk: remove tabular output for NULL pointer

On Thu, Oct 26, 2017 at 01:05:39AM -0700, Joe Perches wrote: > On Thu, 2017-10-26 at 17:27 +1100, Tobin C. Harding wrote: > > Hi Joe, > > > > thanks for your review. > > > > On Wed, Oct 25, 2017 at 09:57:23PM -0700, Joe Perches wrote: > > > On Thu, 2017-10-26 at 13:53 +1100, Tobin C. Harding

Re: [PATCH V8 1/2] printk: remove tabular output for NULL pointer

On Thu, Oct 26, 2017 at 01:05:39AM -0700, Joe Perches wrote: > On Thu, 2017-10-26 at 17:27 +1100, Tobin C. Harding wrote: > > Hi Joe, > > > > thanks for your review. > > > > On Wed, Oct 25, 2017 at 09:57:23PM -0700, Joe Perches wrote: > > > On Thu, 2017-10-26 at 13:53 +1100, Tobin C. Harding

Re: [PATCH V8 1/2] printk: remove tabular output for NULL pointer

On Thu, 2017-10-26 at 17:27 +1100, Tobin C. Harding wrote: > Hi Joe, > > thanks for your review. > > On Wed, Oct 25, 2017 at 09:57:23PM -0700, Joe Perches wrote: > > On Thu, 2017-10-26 at 13:53 +1100, Tobin C. Harding wrote: > > > Currently pointer() checks for a NULL pointer argument and then

Re: [PATCH V8 1/2] printk: remove tabular output for NULL pointer

On Thu, 2017-10-26 at 17:27 +1100, Tobin C. Harding wrote: > Hi Joe, > > thanks for your review. > > On Wed, Oct 25, 2017 at 09:57:23PM -0700, Joe Perches wrote: > > On Thu, 2017-10-26 at 13:53 +1100, Tobin C. Harding wrote: > > > Currently pointer() checks for a NULL pointer argument and then

Re: [PATCH V8 1/2] printk: remove tabular output for NULL pointer

Hi Joe, thanks for your review. On Wed, Oct 25, 2017 at 09:57:23PM -0700, Joe Perches wrote: > On Thu, 2017-10-26 at 13:53 +1100, Tobin C. Harding wrote: > > Currently pointer() checks for a NULL pointer argument and then if so > > attempts to print "(null)" with _some_ standard width. This

Re: [PATCH V8 1/2] printk: remove tabular output for NULL pointer

Hi Joe, thanks for your review. On Wed, Oct 25, 2017 at 09:57:23PM -0700, Joe Perches wrote: > On Thu, 2017-10-26 at 13:53 +1100, Tobin C. Harding wrote: > > Currently pointer() checks for a NULL pointer argument and then if so > > attempts to print "(null)" with _some_ standard width. This

Re: [PATCH V8 1/2] printk: remove tabular output for NULL pointer

On Thu, 2017-10-26 at 13:53 +1100, Tobin C. Harding wrote: > Currently pointer() checks for a NULL pointer argument and then if so > attempts to print "(null)" with _some_ standard width. This width cannot > correctly be ascertained here because many of the printk specifiers > print pointers of

Re: [PATCH V8 1/2] printk: remove tabular output for NULL pointer

On Thu, 2017-10-26 at 13:53 +1100, Tobin C. Harding wrote: > Currently pointer() checks for a NULL pointer argument and then if so > attempts to print "(null)" with _some_ standard width. This width cannot > correctly be ascertained here because many of the printk specifiers > print pointers of

[PATCH V8 1/2] printk: remove tabular output for NULL pointer

Currently pointer() checks for a NULL pointer argument and then if so attempts to print "(null)" with _some_ standard width. This width cannot correctly be ascertained here because many of the printk specifiers print pointers of varying widths. Remove the attempt to print NULL pointers with a

[PATCH V8 1/2] printk: remove tabular output for NULL pointer

Currently pointer() checks for a NULL pointer argument and then if so attempts to print "(null)" with _some_ standard width. This width cannot correctly be ascertained here because many of the printk specifiers print pointers of varying widths. Remove the attempt to print NULL pointers with a