Re: [PATCH V8 5/8] percpu-refcount: introduce __percpu_ref_tryget_live

Hello, On Wed, Oct 04, 2017 at 03:20:40AM +0800, Ming Lei wrote: > On Tue, Oct 03, 2017 at 07:14:59AM -0700, Tejun Heo wrote: > > Hello, > > > > On Tue, Oct 03, 2017 at 10:04:03PM +0800, Ming Lei wrote: > > > Block layer need to call this function after holding > > > rcu lock in a real hot path,

Re: [PATCH V8 5/8] percpu-refcount: introduce __percpu_ref_tryget_live

Hello, On Wed, Oct 04, 2017 at 03:20:40AM +0800, Ming Lei wrote: > On Tue, Oct 03, 2017 at 07:14:59AM -0700, Tejun Heo wrote: > > Hello, > > > > On Tue, Oct 03, 2017 at 10:04:03PM +0800, Ming Lei wrote: > > > Block layer need to call this function after holding > > > rcu lock in a real hot path,

Re: [PATCH V8 5/8] percpu-refcount: introduce __percpu_ref_tryget_live

On Tue, Oct 03, 2017 at 06:40:24PM +, Bart Van Assche wrote: > On Tue, 2017-10-03 at 22:04 +0800, Ming Lei wrote: > > Block layer need to call this function after holding > > rcu lock in a real hot path, so introduce this helper. > > Since it is allowed to nest rcu_read_lock_sched() calls I

Re: [PATCH V8 5/8] percpu-refcount: introduce __percpu_ref_tryget_live

On Tue, Oct 03, 2017 at 06:40:24PM +, Bart Van Assche wrote: > On Tue, 2017-10-03 at 22:04 +0800, Ming Lei wrote: > > Block layer need to call this function after holding > > rcu lock in a real hot path, so introduce this helper. > > Since it is allowed to nest rcu_read_lock_sched() calls I

Re: [PATCH V8 5/8] percpu-refcount: introduce __percpu_ref_tryget_live

On Tue, Oct 03, 2017 at 07:14:59AM -0700, Tejun Heo wrote: > Hello, > > On Tue, Oct 03, 2017 at 10:04:03PM +0800, Ming Lei wrote: > > Block layer need to call this function after holding > > rcu lock in a real hot path, so introduce this helper. > > The patch description is too anemic. It

Re: [PATCH V8 5/8] percpu-refcount: introduce __percpu_ref_tryget_live

On Tue, Oct 03, 2017 at 07:14:59AM -0700, Tejun Heo wrote: > Hello, > > On Tue, Oct 03, 2017 at 10:04:03PM +0800, Ming Lei wrote: > > Block layer need to call this function after holding > > rcu lock in a real hot path, so introduce this helper. > > The patch description is too anemic. It

Re: [PATCH V8 5/8] percpu-refcount: introduce __percpu_ref_tryget_live

On Tue, 2017-10-03 at 22:04 +0800, Ming Lei wrote: > Block layer need to call this function after holding > rcu lock in a real hot path, so introduce this helper. Since it is allowed to nest rcu_read_lock_sched() calls I don't think that this patch is necessary. Bart.

Re: [PATCH V8 5/8] percpu-refcount: introduce __percpu_ref_tryget_live

On Tue, 2017-10-03 at 22:04 +0800, Ming Lei wrote: > Block layer need to call this function after holding > rcu lock in a real hot path, so introduce this helper. Since it is allowed to nest rcu_read_lock_sched() calls I don't think that this patch is necessary. Bart.

Re: [PATCH V8 5/8] percpu-refcount: introduce __percpu_ref_tryget_live

Hello, On Tue, Oct 03, 2017 at 10:04:03PM +0800, Ming Lei wrote: > Block layer need to call this function after holding > rcu lock in a real hot path, so introduce this helper. The patch description is too anemic. It doesn't even describe what changes are being made, let alone justifying them.

Re: [PATCH V8 5/8] percpu-refcount: introduce __percpu_ref_tryget_live

Hello, On Tue, Oct 03, 2017 at 10:04:03PM +0800, Ming Lei wrote: > Block layer need to call this function after holding > rcu lock in a real hot path, so introduce this helper. The patch description is too anemic. It doesn't even describe what changes are being made, let alone justifying them.

[PATCH V8 5/8] percpu-refcount: introduce __percpu_ref_tryget_live

Block layer need to call this function after holding rcu lock in a real hot path, so introduce this helper. Cc: Bart Van Assche Cc: Tejun Heo Signed-off-by: Ming Lei --- include/linux/percpu-refcount.h | 27

[PATCH V8 5/8] percpu-refcount: introduce __percpu_ref_tryget_live

Block layer need to call this function after holding rcu lock in a real hot path, so introduce this helper. Cc: Bart Van Assche Cc: Tejun Heo Signed-off-by: Ming Lei --- include/linux/percpu-refcount.h | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff