Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-26 Thread Linus Walleij
On Thu, Oct 25, 2018 at 3:55 PM wrote: > >> + fsl,weim-cs-timing = <0x024400b1 0x1010 0x20081100 > >> + 0x 0xa240 0x>; > > > > Is it just a copy/paste from > > Documentation/devicetree/bindings/bus/imx-weim.txt > > leftover? > >

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-26 Thread Linus Walleij
On Thu, Oct 25, 2018 at 3:55 PM wrote: > >> + fsl,weim-cs-timing = <0x024400b1 0x1010 0x20081100 > >> + 0x 0xa240 0x>; > > > > Is it just a copy/paste from > > Documentation/devicetree/bindings/bus/imx-weim.txt > > leftover? > >

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-26 Thread Lee Jones
On Thu, 25 Oct 2018, thesve...@gmail.com wrote: > >> This is why the bridge driver has a dependency on a pwm. > >> If the pwm could be enabled individually, I could drop this dependency. > >> Can you think of a way? > > > > How about using the pwm-clock device tree binding to turn the PWM into >

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-26 Thread Lee Jones
On Thu, 25 Oct 2018, thesve...@gmail.com wrote: > >> This is why the bridge driver has a dependency on a pwm. > >> If the pwm could be enabled individually, I could drop this dependency. > >> Can you think of a way? > > > > How about using the pwm-clock device tree binding to turn the PWM into >

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-25 Thread thesven73
>> This is why the bridge driver has a dependency on a pwm. >> If the pwm could be enabled individually, I could drop this dependency. >> Can you think of a way? > > How about using the pwm-clock device tree binding to turn the PWM into > a clock? >

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-25 Thread thesven73
>> This is why the bridge driver has a dependency on a pwm. >> If the pwm could be enabled individually, I could drop this dependency. >> Can you think of a way? > > How about using the pwm-clock device tree binding to turn the PWM into > a clock? >

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-25 Thread David Lechner
On 10/25/2018 08:55 AM, thesve...@gmail.com wrote: > Hi Linus, thank you for the patch review !! > >>> + - pwms : the pwm connected to the bridge's 'pwm input'. >> >> That is really unintuitive and needs a detailed explanation. What >> is a bridge doing with a PWM? Is it 100% certain this is a

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-25 Thread David Lechner
On 10/25/2018 08:55 AM, thesve...@gmail.com wrote: > Hi Linus, thank you for the patch review !! > >>> + - pwms : the pwm connected to the bridge's 'pwm input'. >> >> That is really unintuitive and needs a detailed explanation. What >> is a bridge doing with a PWM? Is it 100% certain this is a

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-25 Thread thesven73
Hi Linus, thank you for the patch review !! >> + - pwms : the pwm connected to the bridge's 'pwm input'. > > That is really unintuitive and needs a detailed explanation. What > is a bridge doing with a PWM? Is it 100% certain this is a PWM, > it's not just a clock? A pwm is a pule WIDTH

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-25 Thread thesven73
Hi Linus, thank you for the patch review !! >> + - pwms : the pwm connected to the bridge's 'pwm input'. > > That is really unintuitive and needs a detailed explanation. What > is a bridge doing with a PWM? Is it 100% certain this is a PWM, > it's not just a clock? A pwm is a pule WIDTH

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-25 Thread thesven73
Hi Rob, thank you so much for taking a look at this patch ! >> +This chip communicates with the SoC over the WEIM bus. It is >> +expected that its Device Tree node is specified as the child of a node >> +corresponding to the WEIM bus used for communication. > >By WEIM you are referring to i.MX

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-25 Thread thesven73
Hi Rob, thank you so much for taking a look at this patch ! >> +This chip communicates with the SoC over the WEIM bus. It is >> +expected that its Device Tree node is specified as the child of a node >> +corresponding to the WEIM bus used for communication. > >By WEIM you are referring to i.MX

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-25 Thread Linus Walleij
Hi Sven, thanks for your patch! On Wed, Oct 24, 2018 at 4:25 PM Sven Van Asbroeck wrote: > + - pwms : the pwm connected to the bridge's 'pwm input'. That is really unintuitive and needs a detailed explanation. What is a bridge doing with a PWM? Is it 100% certain this is a PWM, it's not just

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-25 Thread Linus Walleij
Hi Sven, thanks for your patch! On Wed, Oct 24, 2018 at 4:25 PM Sven Van Asbroeck wrote: > + - pwms : the pwm connected to the bridge's 'pwm input'. That is really unintuitive and needs a detailed explanation. What is a bridge doing with a PWM? Is it 100% certain this is a PWM, it's not just

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-24 Thread Lee Jones
On Wed, 24 Oct 2018, Sven Van Asbroeck wrote: > This patch adds devicetree binding documentation for the > Arcx anybus bridge. > > Signed-off-by: Sven Van Asbroeck > --- > .../bindings/mfd/arcx,anybus-bridge.txt | 37 +++ > .../devicetree/bindings/vendor-prefixes.txt |

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-24 Thread Lee Jones
On Wed, 24 Oct 2018, Sven Van Asbroeck wrote: > This patch adds devicetree binding documentation for the > Arcx anybus bridge. > > Signed-off-by: Sven Van Asbroeck > --- > .../bindings/mfd/arcx,anybus-bridge.txt | 37 +++ > .../devicetree/bindings/vendor-prefixes.txt |

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-24 Thread Rob Herring
On Wed, Oct 24, 2018 at 10:24:54AM -0400, Sven Van Asbroeck wrote: > This patch adds devicetree binding documentation for the > Arcx anybus bridge. > > Signed-off-by: Sven Van Asbroeck > --- > .../bindings/mfd/arcx,anybus-bridge.txt | 37 +++ >

Re: [PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-24 Thread Rob Herring
On Wed, Oct 24, 2018 at 10:24:54AM -0400, Sven Van Asbroeck wrote: > This patch adds devicetree binding documentation for the > Arcx anybus bridge. > > Signed-off-by: Sven Van Asbroeck > --- > .../bindings/mfd/arcx,anybus-bridge.txt | 37 +++ >

[PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-24 Thread Sven Van Asbroeck
This patch adds devicetree binding documentation for the Arcx anybus bridge. Signed-off-by: Sven Van Asbroeck --- .../bindings/mfd/arcx,anybus-bridge.txt | 37 +++ .../devicetree/bindings/vendor-prefixes.txt | 1 + 2 files changed, 38 insertions(+) create mode 100644

[PATCH anybus v1 2/4] dt-bindings: anybus-bridge: document devicetree binding.

2018-10-24 Thread Sven Van Asbroeck
This patch adds devicetree binding documentation for the Arcx anybus bridge. Signed-off-by: Sven Van Asbroeck --- .../bindings/mfd/arcx,anybus-bridge.txt | 37 +++ .../devicetree/bindings/vendor-prefixes.txt | 1 + 2 files changed, 38 insertions(+) create mode 100644