Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-12 Thread Sven Van Asbroeck
On Thu, Nov 8, 2018 at 9:07 AM Arnd Bergmann wrote: > > > > +struct anybuss_host { > > + struct device *dev; > > + struct anybuss_client *client; > > + struct reset_control *reset; > > + struct regmap *regmap; > > + int irq; > > + struct task_struct *qthread; >

Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-12 Thread Sven Van Asbroeck
On Thu, Nov 8, 2018 at 9:07 AM Arnd Bergmann wrote: > > > > +struct anybuss_host { > > + struct device *dev; > > + struct anybuss_client *client; > > + struct reset_control *reset; > > + struct regmap *regmap; > > + int irq; > > + struct task_struct *qthread; >

Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-10 Thread Geert Uytterhoeven
On Fri, Nov 9, 2018 at 10:03 PM Arnd Bergmann wrote: > On Fri, Nov 9, 2018 at 5:25 PM Sven Van Asbroeck wrote: > > On Thu, Nov 8, 2018 at 9:07 AM Arnd Bergmann wrote: > > > > +struct anybus_mbox_hdr { > > > > + u16 id; > > > > + u16 info; > > > > + u16 cmd_num; > > > > +

Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-10 Thread Geert Uytterhoeven
On Fri, Nov 9, 2018 at 10:03 PM Arnd Bergmann wrote: > On Fri, Nov 9, 2018 at 5:25 PM Sven Van Asbroeck wrote: > > On Thu, Nov 8, 2018 at 9:07 AM Arnd Bergmann wrote: > > > > +struct anybus_mbox_hdr { > > > > + u16 id; > > > > + u16 info; > > > > + u16 cmd_num; > > > > +

Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-09 Thread Arnd Bergmann
On Fri, Nov 9, 2018 at 5:25 PM Sven Van Asbroeck wrote: > > On Thu, Nov 8, 2018 at 9:07 AM Arnd Bergmann wrote: > > > > > +struct anybus_mbox_hdr { > > > + u16 id; > > > + u16 info; > > > + u16 cmd_num; > > > + u16 data_size; > > > + u16 frame_count; > > > +

Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-09 Thread Arnd Bergmann
On Fri, Nov 9, 2018 at 5:25 PM Sven Van Asbroeck wrote: > > On Thu, Nov 8, 2018 at 9:07 AM Arnd Bergmann wrote: > > > > > +struct anybus_mbox_hdr { > > > + u16 id; > > > + u16 info; > > > + u16 cmd_num; > > > + u16 data_size; > > > + u16 frame_count; > > > +

Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-09 Thread Sven Van Asbroeck
On Thu, Nov 8, 2018 at 9:07 AM Arnd Bergmann wrote: > > > +struct anybus_mbox_hdr { > > + u16 id; > > + u16 info; > > + u16 cmd_num; > > + u16 data_size; > > + u16 frame_count; > > + u16 frame_num; > > + u16 offset_high; > > + u16 offset_low; > > +

Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-09 Thread Sven Van Asbroeck
On Thu, Nov 8, 2018 at 9:07 AM Arnd Bergmann wrote: > > > +struct anybus_mbox_hdr { > > + u16 id; > > + u16 info; > > + u16 cmd_num; > > + u16 data_size; > > + u16 frame_count; > > + u16 frame_num; > > + u16 offset_high; > > + u16 offset_low; > > +

Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-08 Thread Arnd Bergmann
On Thu, Nov 8, 2018 at 4:47 PM Sven Van Asbroeck wrote: > On Thu, Nov 8, 2018 at 9:07 AM Arnd Bergmann wrote: > > I see this is called from the interrupt handler at the moment, which > > means you cannot call sleeping functions, but it also means that > > the timeout may never happen because the

Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-08 Thread Arnd Bergmann
On Thu, Nov 8, 2018 at 4:47 PM Sven Van Asbroeck wrote: > On Thu, Nov 8, 2018 at 9:07 AM Arnd Bergmann wrote: > > I see this is called from the interrupt handler at the moment, which > > means you cannot call sleeping functions, but it also means that > > the timeout may never happen because the

Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-08 Thread Sven Van Asbroeck
On Thu, Nov 8, 2018 at 9:07 AM Arnd Bergmann wrote: > > It looks like you build your own object management here. Maybe > use kobject, or at least kref instead of the refcount_t based > low-level implementation? Excellent point. I'll replace with krefs. > > > I see this is called from the

Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-08 Thread Sven Van Asbroeck
On Thu, Nov 8, 2018 at 9:07 AM Arnd Bergmann wrote: > > It looks like you build your own object management here. Maybe > use kobject, or at least kref instead of the refcount_t based > low-level implementation? Excellent point. I'll replace with krefs. > > > I see this is called from the

Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-08 Thread Arnd Bergmann
On Sun, Nov 4, 2018 at 4:55 PM wrote: > From: Sven Van Asbroeck > +struct anybus_mbox_hdr { > + u16 id; > + u16 info; > + u16 cmd_num; > + u16 data_size; > + u16 frame_count; > + u16 frame_num; > + u16 offset_high; > + u16 offset_low; > +

Re: [PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-08 Thread Arnd Bergmann
On Sun, Nov 4, 2018 at 4:55 PM wrote: > From: Sven Van Asbroeck > +struct anybus_mbox_hdr { > + u16 id; > + u16 info; > + u16 cmd_num; > + u16 data_size; > + u16 frame_count; > + u16 frame_num; > + u16 offset_high; > + u16 offset_low; > +

[PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-04 Thread thesven73
From: Sven Van Asbroeck The Anybus-S/Anybus-M is a series of interchangeable fieldbus communication modules featuring on board memory and processing power. All software and hardware functionality required to communicate on the fieldbus is incorporated in the module itself, allowing the

[PATCH anybus v3 4/6] bus: support HMS Anybus-S bus

2018-11-04 Thread thesven73
From: Sven Van Asbroeck The Anybus-S/Anybus-M is a series of interchangeable fieldbus communication modules featuring on board memory and processing power. All software and hardware functionality required to communicate on the fieldbus is incorporated in the module itself, allowing the