Re: [PATCH cgroup/for-3.13-fixes] cgroup: fix oops in cgroup init failure path

2013-12-09 Thread Li Zefan
On 2013/12/6 5:18, Tejun Heo wrote: > Hello, Vladimir. > > Thanks a lot for the report and fix; however, I really wanna make sure > that only online css's become visible, so I wrote up a different fix. > Can you please test this one? > Oh, I spotted this bug when reviewing a bug fix months ago.

Re: [PATCH cgroup/for-3.13-fixes] cgroup: fix oops in cgroup init failure path

2013-12-06 Thread Vladimir Davydov
On 12/06/2013 08:25 PM, Tejun Heo wrote: > On Fri, Dec 06, 2013 at 11:13:12AM -0500, Tejun Heo wrote: >>> Second, it's not clear to me why we need the CSS_ONLINE flag at all if >>> we never assign css's that we fail to online to a cgroup. AFAIU we will >>> never see such css's, because in all place

Re: [PATCH cgroup/for-3.13-fixes] cgroup: fix oops in cgroup init failure path

2013-12-06 Thread Vladimir Davydov
On 12/06/2013 08:13 PM, Tejun Heo wrote: > Hello, Vladimir. > > On Fri, Dec 06, 2013 at 11:02:07AM +0400, Vladimir Davydov wrote: >> This patch fixes this bug, but I have a couple of questions regarding it. >> >> First, cgroup_load_subsys() also calls css_online(), and if it fails, it >> calls cgro

Re: [PATCH cgroup/for-3.13-fixes] cgroup: fix oops in cgroup init failure path

2013-12-06 Thread Tejun Heo
On Fri, Dec 06, 2013 at 11:13:12AM -0500, Tejun Heo wrote: > > Second, it's not clear to me why we need the CSS_ONLINE flag at all if > > we never assign css's that we fail to online to a cgroup. AFAIU we will > > never see such css's, because in all places we call offline_css(), > > namely cgroup_

Re: [PATCH cgroup/for-3.13-fixes] cgroup: fix oops in cgroup init failure path

2013-12-06 Thread Tejun Heo
Hello, Vladimir. On Fri, Dec 06, 2013 at 11:02:07AM +0400, Vladimir Davydov wrote: > This patch fixes this bug, but I have a couple of questions regarding it. > > First, cgroup_load_subsys() also calls css_online(), and if it fails, it > calls cgroup_unload_subsys() to rollback. The latter functi

Re: [PATCH cgroup/for-3.13-fixes] cgroup: fix oops in cgroup init failure path

2013-12-05 Thread Vladimir Davydov
On 12/06/2013 01:18 AM, Tejun Heo wrote: > Hello, Vladimir. > > Thanks a lot for the report and fix; however, I really wanna make sure > that only online css's become visible, so I wrote up a different fix. > Can you please test this one? Hi, Tejun This patch fixes this bug, but I have a couple o

[PATCH cgroup/for-3.13-fixes] cgroup: fix oops in cgroup init failure path

2013-12-05 Thread Tejun Heo
Hello, Vladimir. Thanks a lot for the report and fix; however, I really wanna make sure that only online css's become visible, so I wrote up a different fix. Can you please test this one? Thanks a lot! -- 8< -- ae7f164a0940 ("cgroup: move cgroup->subsys[] assignment to online_css()") mov