Re: [PATCH debugfs: implement symbolic links

2007-02-14 Thread Greg KH
On Wed, Feb 14, 2007 at 09:03:24AM +0100, Peter 1 Oberparleiter wrote: > Greg KH <[EMAIL PROTECTED]> wrote on 14.02.2007 02:27:32: > > On Tue, Feb 13, 2007 at 12:13:54PM +0100, Peter Oberparleiter wrote: > > > This function can be useful > > > for people moving functionality from /proc to debugfs

Re: [PATCH debugfs: implement symbolic links

2007-02-14 Thread Peter 1 Oberparleiter
Greg KH <[EMAIL PROTECTED]> wrote on 14.02.2007 02:27:32: > On Tue, Feb 13, 2007 at 12:13:54PM +0100, Peter Oberparleiter wrote: > > This function can be useful > > for people moving functionality from /proc to debugfs (e.g. the > > gcov-kernel patch). > > You aren't really creating debugfs

Re: [PATCH debugfs: implement symbolic links

2007-02-14 Thread Peter 1 Oberparleiter
Greg KH [EMAIL PROTECTED] wrote on 14.02.2007 02:27:32: On Tue, Feb 13, 2007 at 12:13:54PM +0100, Peter Oberparleiter wrote: This function can be useful for people moving functionality from /proc to debugfs (e.g. the gcov-kernel patch). You aren't really creating debugfs symlinks from

Re: [PATCH debugfs: implement symbolic links

2007-02-14 Thread Greg KH
On Wed, Feb 14, 2007 at 09:03:24AM +0100, Peter 1 Oberparleiter wrote: Greg KH [EMAIL PROTECTED] wrote on 14.02.2007 02:27:32: On Tue, Feb 13, 2007 at 12:13:54PM +0100, Peter Oberparleiter wrote: This function can be useful for people moving functionality from /proc to debugfs (e.g. the

Re: [PATCH debugfs: implement symbolic links

2007-02-13 Thread Cornelia Huck
On Tue, 13 Feb 2007 17:31:42 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > > That makes it easy to get return code checking wrong (especially > > considering the comment above), and a number of callers do get it wrong. > > They do? For example, fs/ocfs2/super.c only checks for NULL (while neither

Re: [PATCH debugfs: implement symbolic links

2007-02-13 Thread Greg KH
On Tue, Feb 13, 2007 at 04:45:51PM +0100, Cornelia Huck wrote: > On Tue, 13 Feb 2007 12:13:54 +0100, > Peter Oberparleiter <[EMAIL PROTECTED]> wrote: > > Not especially related to this patch (which just does the same as the > other debugfs functions), but: > > > + * If debugfs is not enabled in

Re: [PATCH debugfs: implement symbolic links

2007-02-13 Thread Greg KH
On Tue, Feb 13, 2007 at 12:13:54PM +0100, Peter Oberparleiter wrote: > From: Peter Oberparleiter <[EMAIL PROTECTED]> > > debugfs: implement symbolic links > > Implement a new function debugfs_create_symlink() which can be used > to create symbolic links in debugfs. This function can be useful >

Re: [PATCH debugfs: implement symbolic links

2007-02-13 Thread Cornelia Huck
On Tue, 13 Feb 2007 12:13:54 +0100, Peter Oberparleiter <[EMAIL PROTECTED]> wrote: Not especially related to this patch (which just does the same as the other debugfs functions), but: > + * If debugfs is not enabled in the kernel, the value -%ENODEV will be > + * returned. It is not wise to

[PATCH debugfs: implement symbolic links

2007-02-13 Thread Peter Oberparleiter
From: Peter Oberparleiter <[EMAIL PROTECTED]> debugfs: implement symbolic links Implement a new function debugfs_create_symlink() which can be used to create symbolic links in debugfs. This function can be useful for people moving functionality from /proc to debugfs (e.g. the gcov-kernel patch).

[PATCH debugfs: implement symbolic links

2007-02-13 Thread Peter Oberparleiter
From: Peter Oberparleiter [EMAIL PROTECTED] debugfs: implement symbolic links Implement a new function debugfs_create_symlink() which can be used to create symbolic links in debugfs. This function can be useful for people moving functionality from /proc to debugfs (e.g. the gcov-kernel patch).

Re: [PATCH debugfs: implement symbolic links

2007-02-13 Thread Cornelia Huck
On Tue, 13 Feb 2007 12:13:54 +0100, Peter Oberparleiter [EMAIL PROTECTED] wrote: Not especially related to this patch (which just does the same as the other debugfs functions), but: + * If debugfs is not enabled in the kernel, the value -%ENODEV will be + * returned. It is not wise to check

Re: [PATCH debugfs: implement symbolic links

2007-02-13 Thread Greg KH
On Tue, Feb 13, 2007 at 12:13:54PM +0100, Peter Oberparleiter wrote: From: Peter Oberparleiter [EMAIL PROTECTED] debugfs: implement symbolic links Implement a new function debugfs_create_symlink() which can be used to create symbolic links in debugfs. This function can be useful for

Re: [PATCH debugfs: implement symbolic links

2007-02-13 Thread Greg KH
On Tue, Feb 13, 2007 at 04:45:51PM +0100, Cornelia Huck wrote: On Tue, 13 Feb 2007 12:13:54 +0100, Peter Oberparleiter [EMAIL PROTECTED] wrote: Not especially related to this patch (which just does the same as the other debugfs functions), but: + * If debugfs is not enabled in the

Re: [PATCH debugfs: implement symbolic links

2007-02-13 Thread Cornelia Huck
On Tue, 13 Feb 2007 17:31:42 -0800, Greg KH [EMAIL PROTECTED] wrote: That makes it easy to get return code checking wrong (especially considering the comment above), and a number of callers do get it wrong. They do? For example, fs/ocfs2/super.c only checks for NULL (while neither