Re: [PATCH drm/hisilicon 2/3] drm/irq: Add the new api to install irq

2020-12-03 Thread Sam Ravnborg
Hi Tian, > > + ret = devm_add_action_or_reset(dev->dev, devm_drm_irq_uninstall, dev); > > + if (ret) > > + devm_drm_irq_uninstall(dev); > devm_add_action_or_reset() will call devm_drm_irq_uninstall() if ret is > != 0. See include/device.h. > > I guess that is the "_or_reset" part

Re: [PATCH drm/hisilicon 2/3] drm/irq: Add the new api to install irq

2020-12-03 Thread Sam Ravnborg
Hi Tian. On Wed, Dec 02, 2020 at 04:47:14PM +0800, Tian Tao wrote: > Add new api devm_drm_irq_install() to register interrupts, > no need to call drm_irq_uninstall() when the drm module is removed. > > Signed-off-by: Tian Tao Just a few details to fix. Sam > --- >

Re: [PATCH drm/hisilicon 2/3] drm/irq: Add the new api to install irq

2020-12-02 Thread Thomas Zimmermann
Hi Am 02.12.20 um 09:47 schrieb Tian Tao: Add new api devm_drm_irq_install() to register interrupts, no need to call drm_irq_uninstall() when the drm module is removed. Signed-off-by: Tian Tao --- drivers/gpu/drm/drm_irq.c | 35 +++ include/drm/drm_irq.h

[PATCH drm/hisilicon 2/3] drm/irq: Add the new api to install irq

2020-12-02 Thread Tian Tao
Add new api devm_drm_irq_install() to register interrupts, no need to call drm_irq_uninstall() when the drm module is removed. Signed-off-by: Tian Tao --- drivers/gpu/drm/drm_irq.c | 35 +++ include/drm/drm_irq.h | 2 +- 2 files changed, 36 insertions(+), 1

Re: [PATCH drm/hisilicon 2/3] drm/irq: Add the new api to install irq

2020-11-26 Thread Thomas Zimmermann
Hi Am 26.11.20 um 13:02 schrieb Tian Tao: Add new api devm_drm_irq_install() to register interrupts, no need to call drm_irq_uninstall() when the drm module is removed. Signed-off-by: Tian Tao --- drivers/gpu/drm/drm_irq.c | 34 ++ include/drm/drm_irq.h

[PATCH drm/hisilicon 2/3] drm/irq: Add the new api to install irq

2020-11-26 Thread Tian Tao
Add new api devm_drm_irq_install() to register interrupts, no need to call drm_irq_uninstall() when the drm module is removed. Signed-off-by: Tian Tao --- drivers/gpu/drm/drm_irq.c | 34 ++ include/drm/drm_irq.h | 2 +- 2 files changed, 35 insertions(+), 1