Re: [PATCH ftrace/core] tracing: irqsoff: Account for additional preempt_disable

2018-08-10 Thread Steven Rostedt
On Fri, 10 Aug 2018 06:01:34 -0700 Joel Fernandes wrote: > > Even though, it should be verified or atleast commented on the function > > header. > > Ok. ftrace/core has been fixed since since so this patch is outdated > and isn't needed any more, but I agree a separate patch doc comment >

Re: [PATCH ftrace/core] tracing: irqsoff: Account for additional preempt_disable

2018-08-10 Thread Steven Rostedt
On Fri, 10 Aug 2018 06:01:34 -0700 Joel Fernandes wrote: > > Even though, it should be verified or atleast commented on the function > > header. > > Ok. ftrace/core has been fixed since since so this patch is outdated > and isn't needed any more, but I agree a separate patch doc comment >

Re: [PATCH ftrace/core] tracing: irqsoff: Account for additional preempt_disable

2018-08-10 Thread Joel Fernandes
On Fri, Aug 10, 2018 at 5:55 AM, Masami Hiramatsu wrote: [..] >> >> >> The other way to fix this is to just use SRCU for all tracepoints. >> >> However we can't do that because we can't use NMIs from RCU context. >> >> >> >> Fixes: c3bc8fd637a9 ("tracing: Centralize preemptirq tracepoints >> >>

Re: [PATCH ftrace/core] tracing: irqsoff: Account for additional preempt_disable

2018-08-10 Thread Joel Fernandes
On Fri, Aug 10, 2018 at 5:55 AM, Masami Hiramatsu wrote: [..] >> >> >> The other way to fix this is to just use SRCU for all tracepoints. >> >> However we can't do that because we can't use NMIs from RCU context. >> >> >> >> Fixes: c3bc8fd637a9 ("tracing: Centralize preemptirq tracepoints >> >>

Re: [PATCH ftrace/core] tracing: irqsoff: Account for additional preempt_disable

2018-08-10 Thread Masami Hiramatsu
On Mon, 6 Aug 2018 07:14:35 -0700 Joel Fernandes wrote: > On Mon, Aug 6, 2018 at 7:05 AM, Masami Hiramatsu wrote: > > On Sun, 5 Aug 2018 20:40:49 -0700 > > "Joel Fernandes (Google)" wrote: > > > >> Recently we tried to make the preemptirqsoff tracer to use irqsoff > >> tracepoint probes.

Re: [PATCH ftrace/core] tracing: irqsoff: Account for additional preempt_disable

2018-08-10 Thread Masami Hiramatsu
On Mon, 6 Aug 2018 07:14:35 -0700 Joel Fernandes wrote: > On Mon, Aug 6, 2018 at 7:05 AM, Masami Hiramatsu wrote: > > On Sun, 5 Aug 2018 20:40:49 -0700 > > "Joel Fernandes (Google)" wrote: > > > >> Recently we tried to make the preemptirqsoff tracer to use irqsoff > >> tracepoint probes.

Re: [PATCH ftrace/core] tracing: irqsoff: Account for additional preempt_disable

2018-08-06 Thread Joel Fernandes
On Mon, Aug 6, 2018 at 7:05 AM, Masami Hiramatsu wrote: > On Sun, 5 Aug 2018 20:40:49 -0700 > "Joel Fernandes (Google)" wrote: > >> Recently we tried to make the preemptirqsoff tracer to use irqsoff >> tracepoint probes. However this causes issues as reported by Masami: >> >> [2.271078] Testing

Re: [PATCH ftrace/core] tracing: irqsoff: Account for additional preempt_disable

2018-08-06 Thread Joel Fernandes
On Mon, Aug 6, 2018 at 7:05 AM, Masami Hiramatsu wrote: > On Sun, 5 Aug 2018 20:40:49 -0700 > "Joel Fernandes (Google)" wrote: > >> Recently we tried to make the preemptirqsoff tracer to use irqsoff >> tracepoint probes. However this causes issues as reported by Masami: >> >> [2.271078] Testing

Re: [PATCH ftrace/core] tracing: irqsoff: Account for additional preempt_disable

2018-08-06 Thread Masami Hiramatsu
On Sun, 5 Aug 2018 20:40:49 -0700 "Joel Fernandes (Google)" wrote: > Recently we tried to make the preemptirqsoff tracer to use irqsoff > tracepoint probes. However this causes issues as reported by Masami: > > [2.271078] Testing tracer preemptirqsoff: .. no entries found ..FAILED! >

Re: [PATCH ftrace/core] tracing: irqsoff: Account for additional preempt_disable

2018-08-06 Thread Masami Hiramatsu
On Sun, 5 Aug 2018 20:40:49 -0700 "Joel Fernandes (Google)" wrote: > Recently we tried to make the preemptirqsoff tracer to use irqsoff > tracepoint probes. However this causes issues as reported by Masami: > > [2.271078] Testing tracer preemptirqsoff: .. no entries found ..FAILED! >

[PATCH ftrace/core] tracing: irqsoff: Account for additional preempt_disable

2018-08-05 Thread Joel Fernandes (Google)
Recently we tried to make the preemptirqsoff tracer to use irqsoff tracepoint probes. However this causes issues as reported by Masami: [2.271078] Testing tracer preemptirqsoff: .. no entries found ..FAILED! [2.381015] WARNING: CPU: 0 PID: 1 at /home/mhiramat/ksrc/linux/kernel/ trace/trace.c:1512

[PATCH ftrace/core] tracing: irqsoff: Account for additional preempt_disable

2018-08-05 Thread Joel Fernandes (Google)
Recently we tried to make the preemptirqsoff tracer to use irqsoff tracepoint probes. However this causes issues as reported by Masami: [2.271078] Testing tracer preemptirqsoff: .. no entries found ..FAILED! [2.381015] WARNING: CPU: 0 PID: 1 at /home/mhiramat/ksrc/linux/kernel/ trace/trace.c:1512